[options] Remove key and doc_string from gnc_register_query_option.

It's always used as an internal option with no UI component so it doesn't
use them.
This commit is contained in:
John Ralls 2022-08-06 10:40:04 -07:00
parent 6faaf3b427
commit e29ab5336f
3 changed files with 8 additions and 10 deletions

View File

@ -759,7 +759,7 @@ wrap_unique_ptr(GncOptionDBPtr, GncOptionDB);
%ignore gnc_register_multichoice_option(GncOptionDB*, const char*, const char*, const char*, const char*, const char*, GncMultichoiceOptionChoices&&);
%ignore gnc_register_list_option(GncOptionDB*, const char*, const char*, const char*, const char*, const char*, GncMultichoiceOptionChoices&&);
%ignore gnc_register_number_Plot_size_option(GncOptionDB*, const char*, const char*, const char*, const char*, int);
%ignore gnc_register_query_option(GncOptionDB*, const char*, const char*, const char*, const char*, QofQuery*);
%ignore gnc_register_query_option(GncOptionDB*, const char*, const char*, const QofQuery*);
%ignore gnc_register_color_option(GncOptionDB*, const char*, const char*, const char*, const char*, std::string);
%ignore gnc_register_currency_option(GncOptionDB*, const char*, const char*, const char*, const char*, gnc_commodity*);
%ignore gnc_register_currency_option(GncOptionDB*, const char*, const char*, const char*, const char*, const char*);

View File

@ -833,10 +833,9 @@ gnc_register_number_plot_size_option(GncOptionDB* db,
void
gnc_register_query_option(GncOptionDB* db, const char* section,
const char* name, const char* key,
const char* doc_string, const QofQuery* value)
const char* name, const QofQuery* value)
{
GncOption option{section, name, key, doc_string, value,
GncOption option{section, name, "", "", value,
GncOptionUIType::INTERNAL};
db->register_option(section, std::move(option));
}

View File

@ -516,25 +516,24 @@ inline void gnc_register_number_plot_size_option(const GncOptionDBPtr& db,
/**
* Create a new QofQuery option and register it in the options database.
*
* Query options have no UI component so they don't get a key or a docstring.
*
* @param db A GncOptionDB* for calling from C. Caller retains ownership.
* @param section The database section for the option.
* @param name The option name.
* @param doc_string A description of the option. This will be used in tooltips and should be marked for translation.
* @param value The initial and default value for the option.
*/
void gnc_register_query_option(GncOptionDB* db, const char* section,
const char* name, const char* key,
const char* doc_string, const QofQuery* value);
const char* name, const QofQuery* value);
/**
* As above but takes a const GncOptionDBPtr& (const std::unique_ptr<GncOptionDB>&) for calling from C++.
*/
inline void gnc_register_query_option(GncOptionDBPtr& db, const char* section,
const char* name, const char* key,
const char* doc_string,
const char* name,
const QofQuery* value)
{
gnc_register_query_option(db.get(), section, name, key, doc_string, value);
gnc_register_query_option(db.get(), section, name, value);
}
/**