IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

[account.cpp] use HashTable for splits

Browse Source 
reduces xml loading time from 3.5s to 3.1s, i.e. 11% improvement
This commit is contained in:
Christopher Lam 2024-05-12 23:58:44 +08:00
parent b28ca9bdb4
commit e54e9d8086
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libgnucash/engine/Account.cpp
View File

@ -333,6 +333,7 @@ gnc_account_init(Account* acc)
priv->include_sub_account_balances = {}; priv->include_sub_account_balances = {};
new (&priv->splits) SplitsVec (); new (&priv->splits) SplitsVec ();
priv->splits_hash = g_hash_table_new (g_direct_hash, g_direct_equal);
priv->sort_dirty = FALSE; priv->sort_dirty = FALSE;
} }
@ -1470,6 +1471,7 @@ xaccFreeAccount (Account *acc)
priv->balance_dirty = FALSE; priv->balance_dirty = FALSE;
priv->sort_dirty = FALSE; priv->sort_dirty = FALSE;
priv->splits.~SplitsVec(); priv->splits.~SplitsVec();
g_hash_table_destroy (priv->splits_hash);
/* qof_instance_release (&acc->inst); */ /* qof_instance_release (&acc->inst); */
g_object_unref(acc); g_object_unref(acc);
@ -1556,6 +1558,7 @@ xaccAccountCommitEdit (Account *acc)
else else
{ {
priv->splits.clear(); priv->splits.clear();
g_hash_table_remove_all (priv->splits_hash);
} }
/* It turns out there's a case where this assertion does not hold: /* It turns out there's a case where this assertion does not hold:
@ -1966,8 +1969,8 @@ gnc_account_insert_split (Account *acc, Split *s)
g_return_val_if_fail(GNC_IS_SPLIT(s), FALSE); g_return_val_if_fail(GNC_IS_SPLIT(s), FALSE);
priv = GET_PRIVATE(acc); priv = GET_PRIVATE(acc);
if (std::find (priv->splits.begin(), priv->splits.end(), s) != priv->splits.end()) if (!g_hash_table_add (priv->splits_hash, s))
return FALSE; return false;
priv->splits.push_back (s); priv->splits.push_back (s);
@ -1997,10 +2000,9 @@ gnc_account_remove_split (Account *acc, Split *s)
priv = GET_PRIVATE(acc); priv = GET_PRIVATE(acc);
if (!g_hash_table_remove (priv->splits_hash, s))
return false;
auto it = std::remove (priv->splits.begin(), priv->splits.end(), s); auto it = std::remove (priv->splits.begin(), priv->splits.end(), s);
if (it == priv->splits.end())
return FALSE;
priv->splits.erase (it, priv->splits.end()); priv->splits.erase (it, priv->splits.end());
//FIXME: find better event type //FIXME: find better event type
qof_event_gen(&acc->inst, QOF_EVENT_MODIFY, nullptr); qof_event_gen(&acc->inst, QOF_EVENT_MODIFY, nullptr);

1
libgnucash/engine/AccountP.hpp
View File

@ -120,6 +120,7 @@ typedef struct AccountPrivate
gboolean balance_dirty; /* balances in splits incorrect */ gboolean balance_dirty; /* balances in splits incorrect */
std::vector<Split*> splits; /* list of split pointers */ std::vector<Split*> splits; /* list of split pointers */
GHashTable* splits_hash;
gboolean sort_dirty; /* sort order of splits is bad */ gboolean sort_dirty; /* sort order of splits is bad */
LotList *lots; /* list of lot pointers */ LotList *lots; /* list of lot pointers */