From ea2a54bf9e5440aebb1f999410be9d163fdf6108 Mon Sep 17 00:00:00 2001 From: Robert Fewell <14uBobIT@gmail.com> Date: Sat, 19 Jun 2021 12:43:18 +0100 Subject: [PATCH] Bug 798162 - Type Ahead Initialization Problem If navigating by the keyboard and you tab to the transfer cell and then type a letter, we get to gnc_item_edit_show_popup which starts to create and hopefully show the pop up list. But on first use, cell height obtained by gnc_item_list_get_cell_height can be 1 pixel less than required. This should be corrected by the check_popup_height_is_true function which calls gnc_item_edit_update via an idle function. As part of that function, a check is made for item_edit->show_popup being set but that was only getting set in the gnc_item_edit_popup_toggled call back so the pop up would not show. To fix set item_edit->show_popup after setting the toggle button arrow direction. --- gnucash/register/register-gnome/gnucash-item-edit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gnucash/register/register-gnome/gnucash-item-edit.c b/gnucash/register/register-gnome/gnucash-item-edit.c index 3b1d10a022..1c2d6bf433 100644 --- a/gnucash/register/register-gnome/gnucash-item-edit.c +++ b/gnucash/register/register-gnome/gnucash-item-edit.c @@ -1082,6 +1082,7 @@ gnc_item_edit_show_popup (GncItemEdit *item_edit) // set the popup arrow direction up item_edit->popup_toggle.arrow_down = FALSE; + item_edit->show_popup = TRUE; if (item_edit->popup_set_focus) item_edit->popup_set_focus (item_edit->popup_item,