IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

[gnc-features] don't repeatedly g_strconcat gchars*

Browse Source
This commit is contained in:
Christopher Lam 2021-10-19 22:54:00 +08:00
parent 31a0300abe
commit f0970c8eb4
1 changed files with 9 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
libgnucash/engine/gnc-features.c
View File

@ -31,6 +31,7 @@
#include "qof.h"
#include "gnc-features.h"
#include "gnc-glib-utils.h"
typedef struct
{
@ -115,20 +116,15 @@ gchar *gnc_features_test_unknown (QofBook *book)
&features_list);
if (features_list)
{
GList *i;
char* msg = g_strdup(_("This Dataset contains features not supported "
"by this version of GnuCash. You must use a "
"newer version of GnuCash in order to support "
"the following features:"
));
for (i = features_list; i; i = i->next)
{
char *tmp = g_strconcat(msg, "\n* ", i->data, NULL);
g_free (msg);
msg = tmp;
}
const char* sep = "\n* ";
const char* header = _("This Dataset contains features not supported "
"by this version of GnuCash. You must use a "
"newer version of GnuCash in order to support "
"the following features:");
char *features_str = gnc_g_list_stringjoin (features_list, sep);
char *msg = g_strconcat (header, sep, features_str, NULL);
g_free (features_str);
g_list_free(features_list);
return msg;
}