IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Bug 747377: Fix overly restrictive input validation for IBAN of SEPA transfer.

Browse Source 
Only in some countries the IBAN is really restricted to numeric-only
(most notably in Germany, "DE"). In some other countries parts of the
IBAN may be alphas. These checks could be extended for more countries,
but since aqbanking with the SEPA transfers is used mostly in Germany,
we just leave it with the exception rule for Germany.
This commit is contained in:
Christian Stimming 2015-04-12 22:26:31 +02:00
parent 79546ff6a5
commit f9376318ad
1 changed files with 40 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
src/import-export/aqb/dialog-ab-trans.c
View File

@ -1348,16 +1348,53 @@ gnc_ab_trans_dialog_ibanentry_filter_cb (GtkEditable *editable,
if (gnc_ab_trans_isSEPA(td->trans_type))
{
// SEPA: Only alphas in the first two places (only upper case, though), then only digits
enum {
ALPHA
, ALNUM
, NUMERIC
} allowed_characterclass;
// SEPA: Only alphas in the first two places (at index 0, 1)
if (*position + i < 2)
{
if (g_ascii_isalpha(c))
g_string_append_c(result, g_ascii_toupper(c));
allowed_characterclass = ALPHA;
}
// SEPA: Next two places are digits only (index 2, 3)
else if (*position + i < 4)
{
allowed_characterclass = NUMERIC;
}
// SEPA: The rest depends on the country code: Either Alpha-numeric or numeric only
else
{
const gchar* acct_text = gtk_entry_get_text(GTK_ENTRY(td->recp_account_entry));
// Special case for German ("DE") IBAN: Numeric only. Otherwise allow alpha-numeric
if (acct_text[0] == 'D' && acct_text[1] == 'E')
{
allowed_characterclass = NUMERIC;
}
else
{
allowed_characterclass = ALNUM;
}
}
// Do the actual character class check. Alphas are only allowed in
// uppercase, though.
switch (allowed_characterclass)
{
case ALPHA:
if (g_ascii_isalpha(c))
g_string_append_c(result, g_ascii_toupper(c));
break;
case ALNUM:
if (g_ascii_isalnum(c))
g_string_append_c(result, g_ascii_toupper(c));
break;
case NUMERIC:
if (g_ascii_isdigit(c))
g_string_append_c(result, c);
break;
}
}
else