IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Bug 799272 - Crashes when pasting a copied transaction

Browse Source 
Clear the copied_item, copied_class, and copied_leader_guid on book
close to ensure that they're not carried across sessions.
This commit is contained in:
John Ralls 2024-04-11 17:35:38 -07:00
parent 8c94132f13
commit fafc745b1b
1 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
gnucash/register/ledger-core/split-register.c
View File

@ -35,6 +35,7 @@
#include "gnc-component-manager.h" #include "gnc-component-manager.h"
#include "split-register-p.h" #include "split-register-p.h"
#include "gnc-date.h" #include "gnc-date.h"
#include <gnc-hooks.h>
#include "gnc-ledger-display.h" #include "gnc-ledger-display.h"
#include "gnc-prefs.h" #include "gnc-prefs.h"
#include "gnc-ui.h" #include "gnc-ui.h"
@ -88,6 +89,19 @@ static gboolean gnc_split_register_auto_calc (SplitRegister *reg,
/** implementations *******************************************************/ /** implementations *******************************************************/
static void
clear_copied_item()
{
if (copied_item.ftype == GNC_TYPE_SPLIT)
gnc_float_split_free (copied_item.fs);
if (copied_item.ftype == GNC_TYPE_TRANSACTION)
gnc_float_txn_free (copied_item.ft);
copied_item.ftype = 0;
copied_item.fs = NULL;
copied_class = CURSOR_CLASS_NONE;
copied_leader_guid = *guid_null();
}
static void static void
gnc_copy_split_onto_split (Split* from, Split* to, gboolean use_cut_semantics) gnc_copy_split_onto_split (Split* from, Split* to, gboolean use_cut_semantics)
{ {
@ -821,11 +835,7 @@ gnc_split_register_copy_current_internal (SplitRegister* reg,
} }
/* unprotect the old object, if any */ /* unprotect the old object, if any */
if (copied_item.ftype == GNC_TYPE_SPLIT) clear_copied_item();
gnc_float_split_free (copied_item.fs);
if (copied_item.ftype == GNC_TYPE_TRANSACTION)
gnc_float_txn_free (copied_item.ft);
copied_item.ftype = 0;
if (new_fs) if (new_fs)
{ {
@ -839,6 +849,7 @@ gnc_split_register_copy_current_internal (SplitRegister* reg,
} }
copied_class = cursor_class; copied_class = cursor_class;
gnc_hook_add_dangler (HOOK_BOOK_CLOSED, clear_copied_item, NULL, NULL);
LEAVE ("%s %s", use_cut_semantics ? "cut" : "copied", LEAVE ("%s %s", use_cut_semantics ? "cut" : "copied",
cursor_class == CURSOR_CLASS_SPLIT ? "split" : "transaction"); cursor_class == CURSOR_CLASS_SPLIT ? "split" : "transaction");
} }