IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Bug#496178: freeing the result of guid_to_string(…) causes memory corruption; use guid_to_string_buff(…) for clarity.

Browse Source 
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@16670 57a11ea4-9604-0410-9ed3-97b8803252fd
This commit is contained in:
Joshua Sled 2007-12-16 17:17:27 +00:00
parent 52ce5b4602
commit fe19947fc0
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/app-utils/gnc-sx-instance-model.c
View File

@ -261,11 +261,10 @@ Account*
gnc_sx_get_template_transaction_account(SchedXaction *sx)
{
Account *template_root, *sx_template_acct;
const char *sx_guid_str;
char sx_guid_str[GUID_ENCODING_LENGTH];
template_root = gnc_book_get_template_root(gnc_get_current_book());
sx_guid_str = guid_to_string(xaccSchedXactionGetGUID(sx));
/* Get account named after guid string. */
guid_to_string_buff(xaccSchedXactionGetGUID(sx), sx_guid_str);
sx_template_acct = gnc_account_lookup_by_name(template_root, sx_guid_str);
return sx_template_acct;
}
@ -924,13 +923,12 @@ _get_template_split_account(GncSxInstance *instance, Split *template_split, Acco
*split_acct = xaccAccountLookup(acct_guid, gnc_get_current_book());
if (*split_acct == NULL)
{
const char *guid_str;
char guid_str[GUID_ENCODING_LENGTH];
GString *err;
guid_str = guid_to_string((const GUID*)acct_guid);
guid_to_string_buff((const GUID*)acct_guid, guid_str);
err = g_string_new("");
g_string_printf(err, "Unknown account for guid [%s], cancelling SX [%s] creation.",
guid_str, xaccSchedXactionGetName(instance->parent->sx));
g_free((char*)guid_str);
g_critical("%s", err->str);
if (creation_errors != NULL)
*creation_errors = g_list_append(*creation_errors, err);