view_selection_function added to only allow adding a row to the selection if GNCImport_Add is set for the transaction.
Explicit selection clearing
try explicitly clearing the row in the add, update and clear toggle callbacks - before refresh row and add debugging info which showed that the selection is called after exiting the above callbacks and as the view_selection_function has no knowledge that the add checkbox has just been toggled it allows the row to be selected. Requires a flag to be set in the add_toggle_cb which prevents selection in the view_selection_function and is cleared there.
Fix row being selected after A(dd)toggled
When the A is toggled on from U+R or R the row is automatically selected and if the row is toggled back to U+R or R selected, it cannot be unselected. Add a global add-toggled flag set in the gnc_gen_trans_add-toggled_cb and used in the treeview multiple selection function to prevent a row being selected immediately after the A has been toggled.
Fix to Multiple selection to ensure the match dialog comes up on double click on a reconciled or update row and implement a view_selection_function so that only rows flagged for addition can be added to a selection
Fixes requested by Bob-IT
removed global add_toggled variable and added it to _main_matcher_info structure. modified gnc_gen_trans_add_toggled_cb and view_selection_function to use the _main_matcher_info member.
* profit/sales/expense are sorted within currency groups. each group
is prepended by currency-mnemonic header. header is rendered only
if num(currencies) > 1.
* markup/customername have no currency grouping.
* customername sorting ensures 'No Customer' entries are last.
and all-accounts which will never be null? because it's made of
income-accounts and expense-accounts, and (null? income-accounts) has
already been handled by previous cond
* this is an optional upgrade -- (find-first-account type) will find
the first account of appropriate type; (find-first-account type
#:currency curr) will filter to appropriate currency too
If you have some blank lines, just newlines at the end of file and you
have an account column and do not remove them you will get an error
advising that there is no account column selected or account specified
so this change removes them from being parsed.
If the transactions are read only or voided and selected for editing a
blank split is added that allows you to change the transaction so in
these cases make the blank split read only.
Currently when you paste a split you can not cancel the changes as they
are already committed. By opening the transaction for editing before
the split paste the cancel option is now available.
Add some test for when cutting splits from transactions that prevent
the cutting of the anchor split and warn when the split is a reconciled
one or when cutting the transaction that it contains reconciled splits.
The conditional (null? (xaccSplitGetAccount split)) can never be true
because it was already handled previously in code via the
"(null? (xaccSplitGetAccount (car splits))" cond clause to handle bug
639082
* eradicate gnc-default-currency from .scm code
This parallels aec61497 whereby customer & vendor total amounts were
rendered with default_currency instead of owner currency
The New multiselect feature used two boolean values that was set up as
pointers but there was a error with one if statement that stopped the
double-click to run the match dialogue. Changed all occurrences to just
use boolean values.
Previously where prices were less than 1, the commodities involved were
swapped and the price inverted, this is no longer required so removed
in the price importer and the transfer dialogue.
Change the way the sorting is done for the Commodity and Currency
combo's for the Price Import. For the Commodity combo group all non
currencies together at the start and add a separator row.
Currently when you use the 'Commodity From' column for Price imports it
can match against the wrong commodity like COP (Conoco Philips) would
match against the currency COP (Columbian Peso). To fix this add a new
column type 'From Namespace' and rename 'Commodity From' to
'From Symbol' so they match the Security Editor.
