Patch by Mike Pieper. Thanks!
Explanation for why this is necessary: The previous (old) behaviour
changed in 62f7aa66. Before this commit (or when AQBANKING6 is not
set) it calls AB_JobSepaTransfer_new. For AQBANKING6 it calls
AB_Transaction_new. AB_Transaction_new is not using gui. Therefore
gui->state stays on INIT, while before it made several status changes
(=> RUNNING, FINISHED, HIDDEN). On second call to gnc_GWEN_Gui_get it
checks the state and finds it still in INIT which seems to be wrong.
So the right fix is to either use gui in AB_Transaction_new or to
remove first allocation, which is done here.
If you use a filter and then use Ctrl-A to select all rows for deletion
all entries are deleted. This is due to the use of a tree store and the
Ctrl-A selecting the parent rows also.
To fix this a tree view 'select' function is used that does not allow
the parent rows to be selected with a filter.
Caused by a previous commit that did not allow for just pressing the
enter key without changes to move to the next transaction. This was
part of a change to stop being asked to create a new account many times
when the transfer cell had been changed and declining it. To fix this
when gnc_split_reg_record returns false, test for the current cursor
changed flag being not set to proceed to do the move.
With this commit the col headers are now properly formatted. Change
tests because the tag is now th instead of td therefore sxml (looking
for td) can't find them anymore.
* shorten identifier names
* compact functions
* use eq? as appropriate instead of equal? when comparing symbols
* omit splitting up and recombining accounts
* minimise use of set! and define vars in let* formals
* instead of (if pred? (begin ...)) use (when pred? ...)
* use efficient gnc:accounts-and-all-descendants
(unless book ...) is equivalent to (if (not book) ...) therefore this
snippet was incorrect.
previous commit ensures book always returns a non-#f object therefore
there's no need to handle #f anymore.
Previously de_DE locale will add a *global* 'Tax/Tax Number'
option. This is immediately translated.
This change will upgrade it to be present in all locales, and can be
queried by any report.
these were already tested -- see previous tests *do* include
'unrealized losses'. augment by adding another couple foreign transfer
to change the unrealized gain/loss amount.
This reverts commit adae341d, "Use cmake_symbol_check to test for
AB_Banking_RuntimeConfig_SetCharValue". We received multiple reports
that the cmake check fails and the behaviour unexpectedly does not use
the new function. As this is completely counter-intuitive as long as the
new-enough aqbanking version are there, we better just stick
to the aqbanking version numbers, especially because this function is used
only in exactly one place here.
With the newest (beta) aqbanking versions there is a renamed
version of the previous getter of the txn purpose available, which
had been switched to a different semantic in between.
Reuse adjusting-splits and filter for positive values.
This function was buggy... see total-query is defined as the
output of qof-query-merge-in-place, or qof-query-destroy, both
returning #unspecified; this fails when passed to qof-query-run.
