Commit Graph

17306 Commits

Author SHA1 Message Date
Geert Janssens
323f8165df Merge branch 'maint' 2016-03-19 15:34:09 +01:00
Geert Janssens
a0fa6d2fe7 Merge branch 'maint'
Resolved Conflicts:
	src/engine/test/utest-Transaction.cpp
	src/gnome-utils/ui/osx_accel_map
	src/libqof/qof/qofbook.cpp
2016-03-19 15:33:59 +01:00
Geert Janssens
dca13d6248 Fix doxigen comment after changed const behaviour 2016-03-19 15:31:46 +01:00
Geert Janssens
6c2c2d73a3 Bug 620281 - Adding reversing transaction to bill transactions creates undeleteable transactions 2016-03-19 14:32:14 +01:00
Geert Janssens
d1e148ef87 Refuse to void read-only transactions.
Add test case to verify
2016-03-19 14:13:46 +01:00
Geert Janssens
0f66e20005 Bug 754209 - Bills can be posted multiple times from "find bill" search results - follow up
This commit adds code to check & repair that removes the read only status of the bogus transactions so the user can go in the AP/AR account and delete these bad transactions.

Translators: this commit introduces a new translatable string.
2016-03-19 14:13:44 +01:00
John Ralls
d45886f73b Bug 733164 - Command-H Invokes Help->Help Contents
Override the Gtk-supplied accelerator for the help menu.
2016-03-17 16:51:46 -07:00
John Ralls
3109b6f6c3 Set the transaction currency during auto-completion.
When auto-completing a transaction that was originally created in another
account with a different currency the balancing code will try to apply
conversions in the wrong direction if one edits the transaction. Explicitly
setting the transaction currency to the current register's currency
prevents the conversions being applied and allows the transaction to
balance correctly.
2016-03-17 15:42:12 -07:00
John Ralls
d0e103be08 Correctly re-value splits when the transaction currency is changed.
When a transaction with existing splits had its currency changed, the
function would change the values to use the new currency's denominator
without changing the actual value. The balancing code would then apply
the price of the the new "other" split to the amount, changing it as
well. Changing the transaction currency back would convert the value in
the other split correctly so that it would equal the amount that the
balancing code wouldn't change anything. I actually detected this bug
when I wrote the test but didn't recognize it as a bug.

The new code first calculates a new price and then applies it to each
split so that the transaction balances correctly in the new transaction
currency. This also round-trips correctly
2016-03-17 15:42:12 -07:00
Geert Janssens
c2ce204434 Use PRIi64 instead of PRIx64
We obviously want our business counters to use integral numbers instead of hexadecimal...
2016-03-17 23:06:52 +01:00
Geert Janssens
a27abf766a Bug 728722 - Setting number format details appear wrong in Help, section 10.3.4. Counters Book Options Tab
This is a follow-up commit to fix the core of the issue.
With this commit gnucash is more liberal at accepting
counter formats. It will accept either li, lli, I64i and
whatever is defined for G_GINT_64 or PRIx64 on the user's
platform. Internally the code will always convert the
specifier set by the user with PRIx64, which should always
be the correct one on any platform.

Additionally a few extra tests were added to stress the
counter format code a bit more.
2016-03-17 22:37:42 +01:00
Mike Evans
8117a7c17f Bug 754209 - Bills can be posted from "find bill" search results
even if bill is already posted and results in extra $ posted to A/P

This adds a test in gncInvoice to return NULL it already posted.

Adds checks in dialog-invoice to test for already posted invoices. Messages
user and refuses to post entire selection if more than one selected.

Translators: This adds a message string.
2016-03-16 14:36:11 +00:00
Geert Janssens
1121cd0795 Bug 720934 - Barcharts with many data points have overlapping x-axis labels
Depending on the available chart width x-axis labels will be pruned
from the full list to ensure the labels that are printed will
always be readable.
2016-03-15 08:19:35 +01:00
Carsten Rinke
d1ab9e783e Bug728692 - Time bound on the Budget Barchart report 2016-03-13 14:59:44 +01:00
Chris Good
ab35b571c3 Add Tip Of The Day re using multiple windows to do comparisons - Bug 762800
Note: this introduces an untranslated string to the stable series
2016-03-13 14:06:20 +01:00
Geert Janssens
ee70922c5b Fixup previous commit
Forgot to add my changes before pushing...
2016-03-13 13:54:46 +01:00
Matt G
7ef2568939 Bug 742352 - Budget Summary section does not show expense totals
Fixed buget add up issue.
https://bugzilla.gnome.org/show_bug.cgi?id=742352
2016-03-13 13:18:47 +01:00
Gilles Dartiguelongue
c56a4d9593 Bug 760015 - guile support is automagic
Make guile support selectable
2016-03-13 13:07:03 +01:00
Robert Fewell
de8e2db3b2 Change look_for_old_mapping to return NULL
look_for_old_mapping should return NULL when we find an existing
map_account
2016-03-13 10:33:54 +01:00
Robert Fewell
a4be710fdd Rename some function to better reflect there use
Change some function names to better reflect there use and change
look_for_old_mapping to return map_account and use this to see if we
need to convert entry
2016-03-13 10:33:53 +01:00
Robert Fewell
99d0b03e0f Remove unnecessary use of g_strdup of full_name
Remove the unnecessary use of g_strdup on full_name and access it
directly
2016-03-13 10:33:51 +01:00
Robert Fewell
b714df4c8c Change some functions to reduce code duplication
and move feature setting to where KVP is actually
set
2016-03-13 10:33:50 +01:00
Robert Fewell
80e20256ad Add feature flag to prevent versions older than 2.6.12 from opening the data file. 2016-03-13 10:33:49 +01:00
Robert Fewell
213db2de52 Use GncImapInfo instead of struct imap_info where
it makes sense to.
2016-03-13 10:33:47 +01:00
Robert Fewell
427d62e805 Change when an existing entry exists we add it to
the converted entry
2016-03-13 10:33:45 +01:00
Robert Fewell
f8090fa78e Improve old separator recognition by looking for
the longest top level entry that matches the
prefix. Also test for valid map account so we are
not wasting time trying to convert a valid
full_name.
2016-03-13 10:33:43 +01:00
Robert Fewell
4e2e45e871 Modify gnc_account_imap_convert_bayes to run only
once by setting a KVP Book entry and then testing
2016-03-13 10:33:42 +01:00
Robert Fewell
cc132ce947 Add Bayesian conversion to end of file open 2016-03-13 10:33:40 +01:00
Robert Fewell
c709d50246 Check for existing guid entries and update 2016-03-13 10:33:38 +01:00
Robert Fewell
dae07facf0 Create function to change Bayesian entries based
on full account name to that of the account guid
2016-03-13 10:33:36 +01:00
Robert Fewell
57a0b46b41 Modify Imap helper function to find map account by
guid
2016-03-13 10:33:35 +01:00
Robert Fewell
82585bd8c4 Rename account_name to account_guid to reflect
change of use and remove newlines from PINFO lines
2016-03-13 10:33:33 +01:00
Robert Fewell
fd23354528 Change Bayes functions to use guid account string
instead of full account name in kvp path
2016-03-13 10:33:31 +01:00
John Ralls
71f7f45777 Merge branch 'maint' 2016-03-11 16:32:20 -08:00
John Ralls
18e6100411 Bug 763146 - Invalid exchange rate is recorded when entering multi-currency transaction
A bunch of little fixes grouped into a feature branch.
2016-03-11 15:46:45 -08:00
John Ralls
a406903705 Ensure numerator is positive before checking if the value is < 1. 2016-03-11 15:43:30 -08:00
John Ralls
1ca56c9d0d Ensure price is set when the amount is entered and user doesn't tab out. 2016-03-11 15:42:53 -08:00
John Ralls
c4ce44df64 Test rounded values, but don't store them, to minimize jitter in prices. 2016-03-11 15:10:12 -08:00
John Ralls
e26e598cdc Check price_source precedence first to save computation. 2016-03-11 15:08:11 -08:00
John Ralls
ba4acdfef1 Ensure that xferData->price_source is always set correctly.
If the user doesn't tab out of the price window before pressing return
or clicking OK gnc_xfer_price_update_cb isn't called, but it does call
gnc_xfer_update_to_amount, which does get called by
gnc_xfer_dialog_response_cb.
2016-03-11 15:03:19 -08:00
John Ralls
2ed85cefa3 Fix double semicolon. 2016-03-11 13:23:23 -08:00
John Ralls
afe7dacb85 Remove price-direction code for to default currency and alphabetic order.
It's much more important to have currency exchange rates > 1 to preserve
significant digits.
2016-03-11 12:59:01 -08:00
John Ralls
56cb0327e1 Extract functions update_price and new_price from create_price. 2016-03-11 12:22:57 -08:00
John Ralls
3a86998ea7 Merge branch 'maint' 2016-03-10 11:07:01 -08:00
John Ralls
4a60e49066 Fix typo in HTML header. 2016-03-10 10:59:53 -08:00
John Ralls
2b95816125 Bug 763111 - commodities prices editor creates hidden db entries
There were two problems: First, if there were multiple prices in the database
for a particular day only one would be displayed. Second, if one manually
created a second price on a day in the price editor the first wouldn't
be removed.
2016-03-10 10:28:41 -08:00
John Ralls
5b40df510d Bug 763279 - GnuCash has empty reports
On recent builds of gentoo, apparently because the supplied webkit dislikes
that we output xhtml in a file called foo.html. Make the header say that
we're using HTML4.
2016-03-10 10:28:41 -08:00
John Ralls
ec83e3a338 Bug 722996 - Cannot add stock price on Price Editor
gtk_combo_box_set_active() doesn't work if the model is changed after
the combo box is constructed.
2016-03-10 10:28:41 -08:00
Geert Janssens
175d404a1b Merge branch 'maint'
Resolved conflicts:
	src/core-utils/gnc-features.c
	src/core-utils/gnc-features.h
	src/engine/test/CMakeLists.txt
	src/gnc-module/test/test-dynload.c
	src/import-export/import-match-map.c
2016-03-10 15:52:02 +01:00
Geert Janssens
71574b7dde Minor tweaks to Bayesian feature flag
- use shorter definition
- set correctly understood as of 2.6.12 instead of 2.7.0
2016-03-10 15:30:56 +01:00