Commit Graph

20153 Commits

Author SHA1 Message Date
Christopher Lam
41b0e4eb45 [invoice] simplify single-use functions 2018-08-07 20:59:35 +08:00
Christopher Lam
62c9b4e02b [invoice] [CSS] remove styles and replace with CSS 2018-08-07 20:59:35 +08:00
Christopher Lam
e0b26628f8 [test-invoice] all variants share same options and html structure
Therefore test-invoice variants now all share the same tests.
2018-08-07 20:59:35 +08:00
Christopher Lam
900cd36667 [invoice] add toggle for invoice title 2018-08-07 20:59:35 +08:00
Christopher Lam
f1ff608e3c [invoice] enable displaying a picture eg company logo in layout 2018-08-07 20:59:35 +08:00
Christopher Lam
a30a58641d [invoice] change do-rows-with-subtotals to named let
This function is only defined once, and use named-let which imho is
neater because it defines the init values explicitly.
2018-08-07 20:59:35 +08:00
Christopher Lam
b75de5de1f [invoice] refinements
1. disable Display/My Company toggle - this is now in Layout
2. streamline internal functions to reduce number of definitions
3. company-details now right-align and add more fields.
   fields can be hidden via CSS. no need for further display options.
2018-08-07 20:59:35 +08:00
Christopher Lam
dae877cacf [invoice] now supports customized layout 2018-08-07 20:59:35 +08:00
Christopher Lam
a0c5be2c81 [business-reports] delete redundant [fancy|easy]-invoice 2018-08-07 20:59:35 +08:00
Christopher Lam
15b62eea6c [invoice+fancy-invoice] add option minimum # entries
This is to enable compatibility with fancy-invoice feature.
2018-08-07 20:59:35 +08:00
Christopher Lam
74ebac461b [invoice+easy-invoice] invoice.scm can generate easy-invoice
invoice.scm can now mimic easy-invoice.scm reports, including a
greater number of options.
2018-08-07 20:59:35 +08:00
Christopher Lam
bfde5a17f7 [invoice] add classes for invoice headers 2018-08-07 20:59:35 +08:00
Christopher Lam
7ef4c00579 [easy-invoice] Display/Charge Type rename back to Display/Action
This report had renamed "Action" to "Charge Type". For consistency,
let's rename it back, and add migration path in options.scm for
saved-options. 2 fewer strings for translation.
2018-08-07 20:59:35 +08:00
Christopher Lam
d6071020e1 [invoice] more refactoring 2018-08-07 20:59:35 +08:00
Christopher Lam
996b94b1ef [invoice] move invoice-details-table to its own function 2018-08-07 20:59:35 +08:00
Christopher Lam
ba000f71bf [invoice] enable CSS class
This commit will enables "class" attribute in the various html-table
objects. The CSS string can be specified, eg.

.entries-table tr, .entries-table td { etc }
.date-table tr { etc }

to provide styling etc.
2018-08-07 20:59:35 +08:00
Christopher Lam
0198a8b831 [invoice] convert string-expand to sanitize html strings.
string-expand was converting #\newline to <br/>. convert it to
generate a gnc:make-html-text object with substrings and
gnc:html-markup-br tags.
2018-08-07 20:59:35 +08:00
Christopher Lam
12253f3c38 [invoice] simplify num-columns-required to use SRFI-1 2018-08-07 20:59:35 +08:00
Christopher Lam
30f14191e6 [invoice] *untabify* 2018-08-07 20:59:35 +08:00
Christopher Lam
0f505d1389 [invoice] entry-values are unused. remove and simplify. 2018-08-07 20:59:35 +08:00
Christopher Lam
1afacb97ba [invoice] refactor gncOrder handling
Previously the function addorder was being passed as an argument to
add gncOrder references to a list, for later displaying in
report. This commit will simplify it - instead of passing a function
to make-entry-table, the report will query invoice orders directly
when needed.
2018-08-07 20:59:35 +08:00
Christopher Lam
cf3ccb9f1e [invoice] more mucho refactoring, no functional change. 2018-08-07 20:59:35 +08:00
Christopher Lam
5467c47598 [invoice] mucho refactoring. no functional change.
Refactor to use SRFI constructs, simplify logic, add comments. No
functional change.
2018-08-07 20:59:35 +08:00
Christopher Lam
874ed6ab0a [invoice] *reindent* 2018-08-07 20:59:35 +08:00
Robert Fewell
97c191cd42 Replace tabs with spaces and fix some indenting in gnc-file.c 2018-08-07 10:33:04 +01:00
Robert Fewell
641925f2d0 Bug 796792 - SaveAs Overwrite dialogue in background and not visible
Firstly the wrong parent was being used for these secondary warning
messages, should be the dialogue and not the main Gnucash application so
these have been changed.

Also some of these secondary warning dialogues still had NULL as the
parent and so the transient parent warning would occur, added parent.
2018-08-07 10:31:13 +01:00
Christopher Lam
3b74574cde [test-stress-options] remove need for test-stress-optionlist.scm
This commit modifies test-stress-options to retrieve the report-list,
and for each report-list, retrieve their options, and for each
multichoice and boolean option, add to optionslist. I now know how to
generate the optionslist dynamically from the unit tests, therefore
there's no need to maintain a test-stress-optionslist.scm anymore. Yay!
2018-08-07 13:26:37 +08:00
Christopher Lam
47ad60c723 [test-balsheet-pnl] add more SELL transactions
this is to thoroughly test average-cost and weighted-average
2018-08-07 13:26:09 +08:00
Christopher Lam
58ae3f2a89 [test-balsheet-pnl] add income-statement tests 2018-08-07 13:26:09 +08:00
Christopher Lam
cabb598c0f [test-balsheet-pnl] rename to allow for pnl tests 2018-08-07 13:26:09 +08:00
Christopher Lam
8273f3eb82 [test-balance-sheet] prepare for pnl tests
This commit prepares for pnl tests - variables are prefixed with
balance-sheet- to accommodate pnl- tests
2018-08-07 13:26:09 +08:00
Christopher Lam
8cbd4d629f [test-balance-sheet] upgrade to better coverage of balance-sheet
This commit upgrades test-balance-sheet to cover most sensitive data.
It specifically generates the following types of transactions, and
tests the balance sheet generated.

- Equity-USD to nested accounts
- Equity-USD to ForeignBank-GBP
- Equity-USD to Broker:FUNDS
- buy/sell from equity to GBP and FUNDS
- Broker and Broker:FUNDS both have splits with amounts

Two main subtotal strategies are tested: multilevel and recursive-bal,
and all amounts are tested.
2018-08-07 13:26:09 +08:00
Christopher Lam
47ba21b8dc [test-extras] export gnc-pricedb-create 2018-08-07 13:26:09 +08:00
John Ralls
78ab26cc2b Fix gncInvoice test failure.
test_suite_gncInvoice sets up the test suite. It's not part of the test
runtime, so stack variables in it have gone out of scope by the time the
tests are actually run. Making invoiceData static makes it permanent so
it exists at runtime.
2018-08-06 14:49:07 -07:00
Geert Janssens
d87fa3a5be Bug 796766 - Credit note creating 'imbalance' with wrong entries
Add fix and regression test.
2018-08-06 13:29:12 +02:00
Yuri Chornoivan
4c8b07c0fa More minor fixes
Signed-off-by: Yuri Chornoivan <yurchor@ukr.net>
2018-08-02 15:40:00 +03:00
Geert Janssens
69fef8277f Revert "Add preference to control toolbar appearance"
This reverts commit 3b09313107.
2018-07-31 17:30:07 +02:00
Geert Janssens
fe371534c2 Revert "Add toolbar preference changes to embedded-window."
This reverts commit a75eb4c8ec.
2018-07-31 17:29:52 +02:00
Geert Janssens
2203118d99 Revert "Add the toolbar preference changes to window-reconcile."
This reverts commit 0199fef584.
2018-07-31 17:29:38 +02:00
Robert Fewell
cd7a55a9cc Fix Transient parent warnings in search dialogue 2018-07-29 12:57:59 +01:00
Robert Fewell
e851f249fc Fix gnc_window_adjust_for_screen using incorrect monitor
This function was always using the primary monitor to get monitor size
so corrected to use the monitor at the specified window coordinates.
2018-07-28 17:53:31 +01:00
Robert Fewell
099b659b4b Add debug message to gnc_save_window_size and some text changes 2018-07-28 17:52:44 +01:00
Robert Fewell
8c1adaa28f Fix Transient parent warning for dialog-book-close 2018-07-28 17:51:30 +01:00
Robert Fewell
68874495e1 Change files for changed gnc_restore_window_size format, part2 of 2
Add the parent window to the calling function gnc_restore_window_size
after the change to that function. This required adding the retrieval of
 the parent window for the calling dialogues.
2018-07-28 17:50:31 +01:00
Robert Fewell
ec0d081d5e Change files for changed gnc_restore_window_size format, part1 of 2
Add the parent window to the calling function gnc_restore_window_size
after the change to that function. These files already had access to
the parent window.
2018-07-28 17:45:49 +01:00
Robert Fewell
dd59ba67f6 Add the parent window to gnc_restore_window_size function
When a dialogue is open for the first time, there is no saved geometry
so to locate this dialogue try and use the parent window location by
doing the following...

If the dialogue has a size, align it centrally on the parent window.
If the dialogue has no size, let gtk align it.

This commit breaks the build, the following commits changes all
occurrences of gnc_restore_window_size to include parent window.
2018-07-28 17:17:19 +01:00
Robert Fewell
0a0d4755c4 Fix restore window geometry
The monitor was not being correctly identified so when Gnucash was
running on the second monitor, a dialogue could be started on the first
which could be confusing. Also when a dialogue is restored a check is
made to try and make sure it fits on the monitor.
2018-07-28 17:05:59 +01:00
Robert Fewell
2c6fbfba6e Update to recently changed GtkDialog to GtkWindow dialogues
Add the ability to close the window when the Escape key is pressed and
make sure window geometry is saved when by the buttons are used.
2018-07-28 17:03:10 +01:00
John Ralls
accd154eb0 Don't run test-stress-options.scm if no textual-ports.
ice-9 textual ports, required by test-stress-options, was introduced
in guile 2.2. We still support using guile-2.0.
2018-07-27 15:58:46 -07:00
Yuri Chornoivan
f9700ba98d Fix minor typos 2018-07-27 14:23:15 +03:00