As the assistant code combines multiple memory management models care should be taken
not to mix them up. The notes should give some insights in how to do this.
Also fix a few minor issues
- delete default copy and move constructor/assignment for the assistant gui class
- nullify a freed pointer
When selecting the File->New with existing register pages open a crash
can happen as the register pages get closed forcing a page-changed
signal to queue the page focus function when there is no page. Add a
call to remove the page focus function in the ..destroy_widget function.
Also with the addition of g_idle_remove before the add when page-changed
is emitted the page focus function only gets run once.
<!-- Local variables: -->
<!-- mode: xml -->
<!-- End: -->
This comments are to help emacs recognize that the files are xml
since they don't have 'xml' as an extension
The text for this account tree view specifies "If you would like an
account to be a placeholder account, click the checkbox for that
account." but they were not enabled and no call back was defined so
enabled the toggle button and provide callback.
Currently running "ninja-build package" produces a file with and incorrect
version number. This patch passes the CMake version variables into CPack to get
the correct filename.
Old "gnucash-0.1.1-Linux.tar.gz" new "gnucash-2.7.5-Linux.tar.gz"
This was producing a date corresponding to 01-01-1970. make-zdate was
being used in aging.scm as a hack to search all splits prior to
end-date. fix the date query logic to set begin-date match to #f.
There is no spacing between the text and the frame in the dialog
"New File" > "New Accounts Hierarchy Setup". In some cases - when
changing the window size - the text appears next to the frame.
It does not look very clean. As a solution, I have defined here a small spacing: 5px.
Really use all splits of any given day. Up to now usually the splits
of the given date were not or not all included, as the time comparison
didn't correctly ignore any given time-of-day of the splits. Instead,
all possible time-of-days should be included.
The subtotal summary-grid will tabulate subtotals - prime-sortkey
vertically, sec-sortkey horizontally. This will be useful, for
example, with prime-sortkey = accounts, sec-sortkey = date,
sec-subtotal = monthly... will produce a monthly time series
spreadsheet.
Introduces grid datastructure.
This is a simple list, each element is a vector
(vector row col data).
In the Transaction Report, row and col are defined
as a pair (cons sortvalue subtotal-heading), whereas:
- sortvalue = string/number used to sort the grid headers,
- subtotal-heading = string used as grid header row/col
- data = the gnc-monetary collector.
Context: https://wiki.gnucash.org/logs/2018/02/24.html#T05:43:50
Summary: I had formerly set some multichoice values to be a list.
However I think options.scm cannot handle list values. They must be
scheme symbols. It wasn't clear to me during TR refactoring and
development.
The root cause is in options.scm multichoice handling, whereby it's
trying to compare the option value with (eq?); in scheme (eq? (list
"A") (list "A")) is always #f.
06ad55cae9/libgnucash/app-utils/options.scm (L911)
is the relevant old code.
Found with -Wimplicit-fallthrough, but older versions of GCC don't support it. So it will take some effort to add it to the build config.
I think it did not result in a reproducible bug.
