Commit Graph

26843 Commits

Author SHA1 Message Date
Robert Fewell
4b226c574b Change some alignment in source file assistant-csv-price-import.c 2023-01-29 11:38:25 +00:00
Robert Fewell
9889712be5 Block CSV price import separator call backs while buttons updated
When the individual CSV separator buttons were being updated, the
associated call could be triggered several times. To stop this, block
the call back for the individual buttons when they are updated and call
it at the end.
2023-01-29 11:37:29 +00:00
Robert Fewell
a94ca11ba7 Configuration not properly saved for CSV price import
The trailing lines value was not being saved properly.
2023-01-29 11:36:42 +00:00
Robert Fewell
7bc4e0370d Add widget names to import dialogs so they can be manipulated with css 2023-01-29 11:35:57 +00:00
Robert Fewell
b85afa790f Only test for linked document glyths once per register
Change the function gnc_split_register_load to run the test for glyths
only on first pass.
2023-01-29 11:32:50 +00:00
Robert Fewell
4741ee355b Change normalize mode in a couple of places
To be consistent, change the normalize mode in gnc-account-sel and
gnc-account-edit to G_NORMALIZE_NFC which is used in other locations.
2023-01-29 11:02:15 +00:00
Geert Janssens
3a6d1ea663 Bug 798737 - Minor grammatical error - 'for' missing in 'You will be asked a conversion rate for each.' 2023-01-29 10:14:38 +01:00
Christopher Lam
e615a5775a Bug 798734 - Aging Reports don't handle mixed currency payments and invoices without Trading Accounts 2023-01-28 20:53:24 +08:00
John Ralls
44f4b55927 Merge Richard Cohen's 'fix-memleaks' into master. 2023-01-26 12:52:21 -08:00
John Ralls
09b0bfe8b9 Merge Richard Cohen's 'reinstate-tests' into master. 2023-01-26 12:48:08 -08:00
John Ralls
f8465dadf4 Fix a pair of missed extern "C" decls. 2023-01-26 12:45:10 -08:00
Richard Cohen
846e75146a Fix some typos so that the correct tests are run
- test_gnc_txn_to_float_txn_cut_semantics
- test_dbi_business_store_and_reload
2023-01-26 15:42:13 +00:00
Richard Cohen
5be5c58b4f Fix memory leak in aqbanking 2023-01-26 14:37:05 +00:00
Richard Cohen
619f62fb0e Fix memory leak in gnc-split-reg.c 2023-01-26 14:36:58 +00:00
Richard Cohen
671f14f68a Fix memory leak in import-main-matcher.c 2023-01-26 14:36:52 +00:00
Richard Cohen
a2ffc7fe75 Fix memory leak in binreloc function _br_find_exe()
Ironically, it seems to be in a code path that
is only followed when using valgrind
2023-01-26 14:36:43 +00:00
luzpaz
67ab9e90d2 Fix some typos 2023-01-26 13:48:58 +01:00
Christopher Lam
17820ec261 Merge branch 'maint' 2023-01-26 18:40:44 +08:00
John Ralls
4739e8ce04 Merge Bob Fewell's 'bug798475' into master. 2023-01-24 13:36:50 -08:00
John Ralls
f4c6d65395 Merge Bob Fewell's 'nofree' into maint. 2023-01-24 13:25:02 -08:00
John Ralls
f6919e60a7 Merge Richard Cohen's 'cleanup' into master. 2023-01-24 12:05:47 -08:00
John Ralls
705ad0f046 Merge Richard Cohen's 'remove-extra-semicolons' into master. 2023-01-24 11:49:37 -08:00
John Ralls
46f9fb01c9 Simplify gnc_commodity equality and compare functions.
gnc_commodity_compare is used for sorting and so needs to have a less-than
return value. The only place it's used presents nothing to the UI; a GncGUID
ordering is fast and stable.

GnuCash allows only one commodity per book for any namespace/mnemonic pair, so
the exhaustive string comparisons are superflous. While the current engine
design allows only one instance of any object, meaning that a pointer comparison
is sufficient to determine equality, that may not be true in the future, but the
GncGUID is guaranteed to sufficiently identify a single commodity. Note that
gnc_commodity_equiv is used to enforce that single-commodity rule and so cannot
use GncGUID comparison.
2023-01-24 10:46:01 -08:00
Richard Cohen
6927535a0a Remove unused test function get_object_is_initialized in qofobject.cpp 2023-01-24 13:36:37 +00:00
Richard Cohen
925fcbc3fd Remove unused gnc-jalali.{c,h} 2023-01-24 13:36:23 +00:00
Richard Cohen
e83c91050c Remove unneeded dummy.cpp 2023-01-24 13:36:02 +00:00
Richard Cohen
47491eeaa5 Update old-style function definition for my_strtok() 2023-01-24 13:35:46 +00:00
Richard Cohen
d6ac56ce5f Re-enable -Waddress - gncInvoiceLookup etc. are now inline functions, not macros
- Remove outdated comments
2023-01-24 13:35:22 +00:00
Richard Cohen
3360a6d13b Remove extra semicolons
Courtesy of gcc -pedantic
2023-01-24 13:22:18 +00:00
Ralf Habacker
7c605043c3 Bug 798732: Type of balance carry forward accounts for german skr49 account template fixed
The accounts listed are of the EQUITY type and not ASSET.
2023-01-24 11:08:25 +01:00
John Ralls
a81b72f04c Merge Ralf Habacker's 'activate-opening-balance-accounts' into maint. 2023-01-23 14:43:49 -08:00
John Ralls
046e4a156e Silence Clang deprecation warnings about sprintf. 2023-01-23 12:54:25 -08:00
John Ralls
dd2497416c Merge Richard Cohen's 'internal-extern-c' into master. 2023-01-23 11:27:05 -08:00
John Ralls
60c06debce [c++options] Don't crash when find_option returns nullopt. 2023-01-23 11:22:35 -08:00
Richard Cohen
1cec0cb3f3 Use internal extern "C" { ... } for C++
- removes warnings compiling swig engine
...
[ 10%] Generating swig-engine.cpp
.../libgnucash/engine/engine-helpers.h:31: Warning 313: Unrecognized extern type "C++".
.../libgnucash/engine/gnc-date.h:83: Warning 313: Unrecognized extern type "C++".
.../libgnucash/engine/qofquery.h:90: Warning 302: Identifier 'QofQuery' redefined (ignored),
.../libgnucash/engine/gnc-option.hpp:55: Warning 302: previous definition of 'QofQuery'.
.../libgnucash/engine/gnc-commodity.h:56: Warning 313: Unrecognized extern type "C++".
.../libgnucash/engine/gncBusiness.h:40: Warning 313: Unrecognized extern type "C++".
.../libgnucash/engine/gncEntry.h:37: Warning 313: Unrecognized extern type "C++".
2023-01-23 18:40:01 +00:00
Richard Cohen
19bbde7000 Fix some typos 2023-01-23 15:01:46 +00:00
Christopher Lam
d1b84fae9f [balsheet-pnl] shorten workload by deduping commodities 2023-01-23 14:59:20 +08:00
Christopher Lam
c16bde1aea [commodity-utilities] shorten workload by deduping commodities 2023-01-23 14:12:26 +08:00
John Ralls
062f3fb19d [c++options]Fix key-press handling on macOS.
gcc apparently can convert the bool value false to the C equivalent
0. Clang apparently not, dialog_window_key_press_cb was blocking
further key press handling meaning the GtkWindow never saw the
event.
2023-01-22 15:35:21 -08:00
John Ralls
432f2d4bb8 Merge Richard Cohen's suppress-boost-warning into master. 2023-01-22 10:50:11 -08:00
John Ralls
9a1a90d8d0 Merge branch 'maint' 2023-01-22 10:49:29 -08:00
John Ralls
ae6efa39ca Merge 2 simple PRs from Richard Cohen into maint. 2023-01-22 10:41:02 -08:00
richardcohen
2a119375c3 Avoid touching the global errno 2023-01-22 10:40:00 -08:00
richardcohen
f3cc223f5f Fix some bad code formatting 2023-01-22 10:39:48 -08:00
richardcohen
8044f79f75
Silence the boost (<1.76) warning message
from .../gnucash-4.8/libgnucash/app-utils/gnc-quotes.cpp:33:
/usr/include/boost/bind.hpp:36:1: note: ‘#pragma message:

    The practice of declaring the Bind placeholders (_1, _2, ...) in the
    global namespace is deprecated.
    Please use <boost/bind/bind.hpp> + using namespace boost::placeholders,
    or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the current behavior.’
    
The issue was fixed in boost 1.76, but, e.g ubuntu 22.04 has boost 1.74
2023-01-22 17:50:34 +00:00
Frank H. Ellenberger
d039e65aca Merge branch 'maint' 2023-01-22 11:25:44 +01:00
John Ralls
09751e20c5 Bug 789730 Bis: Sometimes we get lists of Account*
And sometimes a list of Guid strings. Handle either.
2023-01-21 15:57:39 -08:00
John Ralls
d981679cbe [macOS] Better fix for menu accelerators.
Connect to can-activate-accel and provide a closure for Quit
instead of using quartz handlers for accelerators.
2023-01-21 14:39:16 -08:00
John Ralls
816219c246 Bug 798730 - Open report doesn't remember selected accounts over restart
scm_to_value<GncOptionAccountList> written for std::vector<Account*>
instead of std::vector<GncGUID>.
2023-01-20 13:22:26 -08:00
Vin
2d66631fea
Translation update by Vin <k3kelm4vw@mozmail.com> using Weblate
po/ru.po: 77.9% (4210 of 5401 strings; 816 fuzzy)
326 failing checks (6.0%)
Translation: GnuCash/Program (Russian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ru/

Co-authored-by: Vin <k3kelm4vw@mozmail.com>
2023-01-20 20:01:45 +01:00