Christopher Lam
ff2ceb111d
[gnc-commodity] GValue must be unset
2021-08-20 17:02:58 +08:00
John Ralls
62ab148a3e
Output a pair when writing relative date values to scheme file.
...
So that the can be properly recognized on input.
2021-08-19 09:48:44 -07:00
John Ralls
b3f96701a0
GncOptionAccountListValue: Make setter param cv match template.
2021-08-18 16:14:21 -07:00
John Ralls
b361582cf2
Ensure option UI is sorted: Tabs by names, items by keys.
2021-08-18 15:42:29 -07:00
John Ralls
10381d42e0
Fix color option handling.
...
Read and write color options the way legacy code does. Pass only values
with no alpha to gdk_rgba_parse because it fails if a hex-string has
alpha.
2021-08-18 13:38:06 -07:00
John Ralls
97a317b50c
Ensure that alpha values in colors aren't passed to html.
...
html color tags don't like them.
2021-08-17 15:47:11 -07:00
John Ralls
3d1812aacd
Explicitly cast a value to the decltype of get_value().
...
Can't always rely on implicit conversion working.
2021-08-17 15:41:26 -07:00
Christopher Lam
028bf9826b
[Split] xaccSplitGetOtherSplit don't test book trading-accts
...
don't test trading-acct property when finding other split.
2021-08-17 13:04:34 +08:00
John Ralls
474bc360f4
Improve converting vectors to SCM lists.
2021-08-15 14:25:52 -07:00
Christopher Lam
6bf5a618de
qof_instance_get gchar* must be freed
...
A call to qof_instance_get expecting a gchar* receives a newly
allocated string which must be freed.
2021-08-15 09:49:06 +08:00
John Ralls
1cd2cf211c
Specialize QofInstance* options set_value, catch validation exceptions.
...
GncOptionValue<const QofInstance*>.get_value() returns a QofInstance* but
reports store them as strings, either commodity mnemonics or GUIDs.
Specialize set_value/set_default_value from scheme to handle those
possibilities.
GncOptionValidatedValue throws an invalid_argument exception if it's
fed an invalid argument. Catch that so that it doesn't crash the program.
2021-08-13 14:06:47 -07:00
John Ralls
852b2ffc2e
Handle bare currency mnemonics, catch invalid GUID string exceptions.
2021-08-13 14:06:47 -07:00
John Ralls
e43ff93279
Fix some overly-long lines.
2021-08-13 14:06:47 -07:00
John Ralls
1af97ebb9a
Implement registering/unregistering/calling change callbacks.
...
Drives reloading the report when the Apply or OK button is pressed.
2021-08-13 14:06:47 -07:00
Christopher Lam
e4d808e674
[qofbook] qof_book_use_split_action_for_num_field: free a char*
...
qof_instance_get allocates a new char* which must be freed.
2021-08-13 08:58:07 +08:00
John Ralls
86da12d844
Use RGB instead of RGBA for color set for color
2021-08-12 14:28:44 -07:00
Christopher Lam
eafc290034
Merge branch 'maint'
2021-08-12 22:28:58 +08:00
Christopher Lam
40d886fa9d
gnc_account_list_name_violations elements must be freed
2021-08-12 09:39:08 +08:00
Christopher Lam
4c37f6d4ef
[account.cpp] gnc_g_list_stringjoin instead of repeated allocations
2021-08-12 09:19:34 +08:00
Christopher Lam
e84549926b
[gnc-glib-utils] gnc_g_list_stringjoin to join a GList of strings
...
It traverses the GList twice (once to calculate the length) but
allocates only once.
Includes snippet from
https://www.joelonsoftware.com/2001/12/11/back-to-basics/
2021-08-12 09:19:34 +08:00
John Ralls
86d7637160
Handle GncOptionMultichoiceValue::set_value parameters
...
that don't match the get_value return type.
2021-08-08 15:22:53 -07:00
Christopher Lam
bedc85afa3
Merge branch 'maint-leaks' into maint #1101
2021-08-06 19:30:01 +08:00
Christopher Lam
0420ae6a66
[account.cpp] refactor gnc_account_list_name_violations
2021-08-06 17:31:36 +08:00
Christopher Lam
67bd513514
[account.cpp] rewrite gnc_account_foreach_descendant_until in C++
2021-08-06 17:31:36 +08:00
Christopher Lam
17953441cb
[account.cpp] refactor gnc_account_foreach_descendant
2021-08-06 17:31:36 +08:00
Christopher Lam
5698b67bf5
[account.cpp] refactor gnc_account_lookup_by_code
2021-08-06 17:31:36 +08:00
Christopher Lam
09e2e7613c
[account.cpp] refactor gnc_account_lookup_by_name
2021-08-06 17:31:36 +08:00
Christopher Lam
bebc366e88
[account.cpp] refactor gnc_account_n_descendants
2021-08-06 17:31:35 +08:00
John Ralls
b6622a386b
Pick up option aliases recently added in maint.
2021-08-05 15:52:13 -07:00
John Ralls
a97b3e0c6d
Don't let C code destroy the ODB, it's owned by Guile.
2021-08-05 15:52:13 -07:00
John Ralls
a2e1a3e1b8
Extract the GncOptionDB* from the Scheme dispatch function closure.
...
Scheme code keeps the GncOptionDB in a closure. Extract it for C/C++
use. Ownership remains with the closure, don't free the GncOptionDB*.
2021-08-05 15:46:56 -07:00
John Ralls
f0926d66c1
Merge Simon Arlott's 'qof-instance-dispose' into maint.
2021-08-05 11:45:14 -07:00
Christopher Lam
e6c33a39bc
[account.cpp] refactor gnc_account_get_descendants{_sorted}
2021-08-06 00:23:12 +08:00
Christopher Lam
d2db43019c
[account.cpp] internal function account_foreach_descendant
...
fast and efficient
2021-08-06 00:23:12 +08:00
Christopher Lam
de1ad9367a
g_free gnc_ctime which returns a new gchar*
2021-08-05 21:42:31 +08:00
Simon Arlott
7a0ea190ca
qof_instance_dispose should always complete dispose processes
...
If QofInstancePrivate has no collection then qof_instance_dispose() returns
without completing the rest of its dispose processes, skipping removal of
its type string from the string cache resulting in a reference count leak.
Change the check for a collection so that it only affects the call to
qof_collection_remove_entity().
2021-08-05 08:56:51 +01:00
Christopher Lam
c9db551693
g_free qof_print_date which returns a new char*
2021-08-05 09:23:28 +08:00
John Ralls
d099d39afd
Merge Simon Arlott's 'commit-root-on-load' into maint.
2021-08-04 15:52:51 -07:00
John Ralls
fd56512cf7
Merge Simon Arlott's 'load-test-xml' into maint.
2021-08-04 15:48:42 -07:00
John Ralls
9062be3d47
Merge Simon Arlott's 'string-cache-fixes' into maint.
2021-08-04 14:26:27 -07:00
John Ralls
f6766d42ec
Merge Simon Arlott's 'string-cache-no-refcount-empty' into maint.
2021-08-04 14:19:21 -07:00
John Ralls
99eaa81a28
Fix parse of commodity namespace from scheme istream.
...
Just ignore 2 instead of ignoring 1 twice. No ifdef required.
2021-08-04 10:04:47 -07:00
Christopher Lam
a5edacf0fc
[options.scm] Rename option name to "Levels of Subaccounts"
...
Original name "Show Accounts until level". Add backward compatibility
missed in 08f490ee98
2021-08-04 19:02:30 +08:00
Christopher Lam
23bd716451
g_free gnc-path's gchar* intermediate strings
2021-08-03 12:14:12 +08:00
John Ralls
0bd9033bb3
Move includes of glib and gtk out or extern C in new cpp files.
2021-08-01 11:11:20 -07:00
John Ralls
0f02236ebe
Fix gcc warnings.
2021-08-01 10:27:50 -07:00
John Ralls
18997db720
Separate GncOptionAccountValue into GncOptionAccountListValue and GncOptionAccountSelValue.
...
They have different get_value() return types so can't cohabit comfortably.
2021-07-31 18:22:46 -07:00
John Ralls
dd8e8b4efa
Evaluate the getter for making invoice options.
2021-07-31 18:22:45 -07:00
John Ralls
05ac056449
Make separate option type for GncOwner.
...
GncOwner is not a QofInstance subclass.
2021-07-31 18:22:45 -07:00
John Ralls
9d150b1ae7
Always set budget option to default budget.
2021-07-31 18:18:05 -07:00