Commit Graph

22723 Commits

Author SHA1 Message Date
John Ralls
1510f34926 Use std::unique_ptr instead of std::shared_ptr.
No need to share ownership.
2020-05-12 14:06:45 -07:00
John Ralls
bd6840e035 Fix incorrecly logging all possible messages regardless of log level. 2020-05-12 14:06:45 -07:00
Christopher Lam
57fe051565 Merge branch 'maint-trep-case-insensitive' PR #719 2020-05-12 21:47:36 +08:00
Geert Janssens
ebd9db8921 Merge branch 'maint' 2020-05-12 14:50:20 +02:00
Geert Janssens
0c633866fd Bug 797717 - Summary bar changes height when opening a menu or scrolling over an option
Apparently something changed in gtk which now calculates
layout differently for a status bar for an empty string message.
Setting a single space message doesn't trigger this different
behaviour so we use that as workaround
2020-05-12 14:49:49 +02:00
Robert Fewell
9f039a7d08 Bug 797745 - Unable to change default report currency
This option in the preference dialog was missing its group partner so
both options were selected. Added missing group and also realigned some
other entries.
2020-05-12 10:51:35 +01:00
John Ralls
94fdc42f16 Fix wrong Boost library variable names. 2020-05-11 12:35:42 -07:00
John Ralls
b9b51efa8d Don't use g_return_value_if_fail in qof_log_check.
It causes GnuCash to crash if g_log is called without having set
G_LOG_DOMAIN.

Also extract a singleton getter function to ensure that the static
root module has been created before use.
2020-05-11 12:31:49 -07:00
Christopher Lam
b4d7386d44 [trep-engine] "Transaction Filter is case insensitive"
add Filter option to make Transaction Filter case insensitive.
2020-05-11 23:15:29 +08:00
John Ralls
3d6a06d503 Fix clang error about type mismatch GtkWidget* != void* aka gpointer
in the second argument and an extra ptr level in the first.
(The declaration is
g_atomic_pointer_compare_and_exchange(void* atomic, gpointer old,
                                      gpointer new)
but that's wrong as it tests *atomic == old so atomic needs to be
void**. But we were passing &gpointer* i.e. void***.)
2020-05-10 14:49:20 -07:00
John Ralls
d58f260aa9 Reports dependency fixes. 2020-05-10 12:00:13 -07:00
John Ralls
fc637aadc7 Two more test directories needing G_LOG_DOMAIN defined.
Should fix CI failures.
2020-05-10 10:18:36 -07:00
Christopher Lam
8d64c011c5 Merge branch 'maint' 2020-05-10 17:04:39 +08:00
Frank H. Ellenberger
0b0e4c7630 HIG, I18N: Improve Budget menu entries 2020-05-10 04:02:08 +02:00
Christopher Lam
f9dfdb3e6c [c-interface] compact code, use (ice-9 match) 2020-05-10 09:52:40 +08:00
John Ralls
f23e3b2660 Fix undeclared std::find_if. 2020-05-09 18:28:20 -07:00
John Ralls
e92cd20d78 Merge Jean Laroches '797737_match_previously_matched_trans' into maint. 2020-05-09 15:41:06 -07:00
Frank H. Ellenberger
f7a85161cd I18N: fix translator comments in window-reconcile.c 2020-05-10 00:10:42 +02:00
Frank H. Ellenberger
e84e680603 I18N: Fix several issuse with 'Help not found' strings
Unify and modularize the strings
Add an unmarked string
2020-05-09 23:51:44 +02:00
John Ralls
5da3bf7943 [QofLog] Replace hashtable with tree of vectors.
16x speedup.
2020-05-09 14:39:08 -07:00
John Ralls
3e442a0ef9 Make qof_log_set_file static.
Used only internally.
2020-05-09 14:39:08 -07:00
John Ralls
0403e4906c Move QofLogModule typedef to qoflog.h where it belongs. 2020-05-09 14:39:08 -07:00
Christopher Lam
f1ff789657 [balsheet-eg] don't use safe-cadr and safe-cdr
they are safety hacks which indicate inability to deal with lists. use
lists properly.
2020-05-09 22:33:24 +08:00
Christopher Lam
8ffe7771f1 [balsheet-eg] reindent process-acc-list-r 2020-05-09 22:33:24 +08:00
Christopher Lam
0c1b6c5a4f [eguile-utilities] deprecate single-use function
only used by balsheet-eg.scm
2020-05-09 22:33:24 +08:00
Christopher Lam
9667a47da0 [balsheet-eg] use "foreign" css class correctly
5093a8fb1 had mistakenly disabled "foreign" class and used html
formatting elements instead.

also remove dead code
2020-05-09 22:33:24 +08:00
Christopher Lam
010a0f1586 [eguile-gnc] don't catch errors in eguile-gnc
With commit 9832fa397 the default report runner will now catch errors
and show the backtrace in the report window. the eguile renderer
doesn't need to catch errors anymore.
2020-05-09 22:33:24 +08:00
John Ralls
4e6c497cd1 Don't ask to save a non-existant book.
To accomplish that we separate creating a book and creating a session;
gnc_get_session no longer automatically creates a book if one isn't
connected.

We also add an initially_insensitive GtkAction array to
gnc-plugin-basic-commands with a call to make its contents insensitive
at plugin load so that the save button on the toolbar isn't lighted when
there's nothing to save.
2020-05-08 15:59:41 -07:00
John Ralls
320db3270b Remove duplicate decl. 2020-05-08 15:59:41 -07:00
John Ralls
8ff5af4c19 Decouple QofBook creation from QofSession.
So that we don't create two books when loading a session.
Step 1 to not having a dirty book when we think we should have no
book at all.
2020-05-08 15:59:41 -07:00
Mike Alexander
0a4347bd5e Initially select the last account chosen in the account picker dialogs.
Separately keeps track of last investment account, security account,
and income account.  One issue is that gnc_import_select_account
doesn't tell the caller if it put up a dialog or found the online ID
on an existing account.  This means the last account may be one the
user didn't manually select.  This may or may not be the right thing
to do.
2020-05-08 17:07:50 -04:00
Mike Alexander
a4e35f3cea Remove some globals by moving them into the struct passed to callbacks.
No functional changes.
2020-05-08 17:07:21 -04:00
Mike Alexander
478112d8c0 Define log_module in gnc-sx-instance-model.c. 2020-05-08 16:43:45 -04:00
Mike Alexander
870c02b092 Add a newline to the GNC_DBD_DIR line in the environment file. 2020-05-08 16:41:58 -04:00
jean
a143d59b7c Bug 797737 - Import matching can match an imported transaction to an existing, previously matched transaction
A simple fix that skips transactions that have an online_id in the matching process.
This fixes the issue, and also speeds up the import.
2020-05-08 08:46:35 -07:00
Robert Fewell
32e1917017 Transaction matcher dialogue was not closing when changing book. 2020-05-08 14:19:47 +01:00
Robert Fewell
6013cb6b14 Correct parent widget for import new account dialog. 2020-05-08 14:19:47 +01:00
Robert Fewell
d74225f6c0 Change layout of source file dialog-billterms.c
Remove tabs and spaces in source file.
2020-05-08 14:19:47 +01:00
Robert Fewell
49eee35a89 No Selection on load for Bill Terms
Change the selection process so it selects the first entry if present
on load and also selects a newly created entry when completed.
2020-05-08 14:19:47 +01:00
Robert Fewell
c4e41384f2 Bug 797689 - Change the Bill Terms Table dialogue to be based on a
GtkWindow

When using Gnucash on Microsoft Windows and a dialog opens a further
dialog when you switch away from the application and back the last
dialog that has the focus is behind the parent and it appears like the
application has froze. To fix this try to use only one level of dialogue
so change the Bill Terms Table to use a Window with no transient parent.
2020-05-08 14:19:39 +01:00
Robert Fewell
881f89addf Change layout of source file dialog-tax-tables.c
Remove tabs and spaces in source file.
2020-05-08 14:05:02 +01:00
Robert Fewell
8500f36c44 Change the Tax Table dialogue to be based on a GtkWindow
When using Gnucash on Microsoft Windows and a dialog opens a further
dialog when you switch away from the application and back the last
dialog that has the focus is behind the parent and it appears like the
application has froze. To fix this try to use only one level of dialogue
 so change the Tax Table to use a GtkWindow with no transient parent.
2020-05-08 14:03:53 +01:00
Robert Fewell
ccc1247e25 Align the import matcher help button
Move the import matcher help button to the left in the CSV transaction
importer.
2020-05-08 14:02:46 +01:00
Christopher Lam
79286d92d5 Bug 797659 - Liabilities in budget report no longer calculate correctly
Restores budget-3.7 behaviour for current budgets.
Fixes future budget behaviour.
Restore budget-3.7 headings "Income/Expense/Transfer"
Renamed budget-3.7 heading Total to "Remaining"
2020-05-08 19:19:57 +08:00
John Ralls
20d53cc765 Merge branch 'maint' 2020-05-07 13:05:50 -07:00
John Ralls
601aec8ca0 Fix LIBDBI_DRIVERS_DIR generation.
Reusing the variable in a get_filename_component call caused the
function to recurse to /, not very useful.

Also re-do GNC_DBD_DIR with no default but to take its value from the
command line or environment.
2020-05-07 13:02:54 -07:00
John Ralls
6141592d40 Don't mutate the cached global account list store.
That defeats the purpose of caching it and causes problems when using it
from two registers at once. Instead use the PopBox tmp_store for listing
the type-ahead match results if any.

Since a no-match causes an empty ItemList and an empty ItemList with
grab loses key events because there's no cell to handle them--very
confusing to the user--prevent that by checking that there are entries
before grabbing.
2020-05-07 12:05:45 -07:00
John Ralls
534bcd6c1b Clean up some leftover noise from the ime-fix branch. 2020-05-07 11:45:46 -07:00
jean
4f8652c2e5 Refactor, breaking large function.
- gnc_plugin_page_account_tree_cmd_delete_account() is still too long but would be messy to break
- rename the _int function and break it further
- remove passing of account name
- simplify some of the code by reversing if(...) to if(!...)
2020-05-06 20:54:28 -07:00
Frank H. Ellenberger
dc8f1057ce Use more precise strings in gnc-split-reg.c
You can edit the account very well, but not its transactions.
2020-05-06 17:48:25 +02:00