Commit Graph

28988 Commits

Author SHA1 Message Date
John Ralls
1ad2e66aac Merge Daniel Harding's Bug799324 into stable. 2024-06-02 14:40:21 -07:00
Daniel Harding
c4d44ea024 Bug 799324 - Invalid free in gvalue_from_kvp_value()
As of ddc3f28899, gvalue_from_kvp_value()
takes a GValue pointer from the caller, which in some cases points to
memory on the stack.  If that is the case and the code also hits the
default case in the switch statement, the unconditional g_slice_free()
call will attempt to free stack memory, causing the program to abort.

Fix by requiring the caller to always pass in a valid GValue pointer,
making the caller responsible for freeing it if necessary.  This also
means that it is no longer necessary for gvalue_from_kvp_value() to
return a value, so make it a void function.
2024-06-02 14:39:11 -07:00
John Ralls
8106ffb84b [Reports] Improve error message when html generation fails.
Per Chris Lam's comment 7 on https://bugs.gnucash.org/show_bug.cgi?id=799148.
2024-06-02 14:30:31 -07:00
Robert Fewell
5c716cc95c Bug 799290 - Invoice register context menu issue
When you right click on the register styled item lines, the context
menu does not show.

Fixed by adding missing call back.
2024-06-01 12:13:37 +01:00
Christopher Lam
6c7abb487d [SX-ttinfo.hpp] convert to c++ header 2024-06-01 12:03:34 +08:00
Christopher Lam
7dc2e2e6f9 [SchedXaction.cpp] use c++ algo 2024-06-01 11:45:41 +08:00
Christopher Lam
55592efe25 [SchedXAction.cpp] convert to c++ 2024-06-01 11:45:41 +08:00
Kaligula
1cc1e498ec
Translation update by Kaligula <kaligula.dev@gmail.com> using Weblate
po/pl.po: 72.8% (4056 of 5571 strings; 1007 fuzzy)
273 failing checks (4.9%)
Translation: GnuCash/Program (Polish)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/pl/

Co-authored-by: Kaligula <kaligula.dev@gmail.com>
2024-06-01 00:09:14 +00:00
Christopher Lam
b0d1de6f3e [dialog-sx-from-trans.cpp] convert to c++ 2024-05-31 23:14:38 +08:00
Christopher Lam
109497d471 [SX-ttinfo.cpp] convert to c++ 2024-05-31 22:24:48 +08:00
Christopher Lam
5b1bb1186f [SX-book.cpp] convert to c++ 2024-05-31 22:06:55 +08:00
John Ralls
35a0e7774e Bug 799320 - GNUCash Immediately Exits on Startup
Some excellent and insightful debugging by the reporter found that the cause was specifying
a locale as en_US.utf8 instead of en_US.utf-8. GnuLib's locale functions and so Guile's are
apparently quite picky on Win32.

To address this move reading the environment file to before we set the mac and Windows
locales and ensure that UTF/UCS and ISO-8859 character sets are specified with minus
separators on Windows. I tested on macOS and didn't experience the crash.
2024-05-30 15:34:11 -07:00
Szia Tomi
99a92659ec
Translation update by Szia Tomi <sziatomi01@gmail.com> using Weblate
po/hu.po: 77.4% (4314 of 5571 strings; 394 fuzzy)
1 failing checks (0.1%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by Szia Tomi <sziatomi01@gmail.com> using Weblate

po/hu.po: 77.4% (4313 of 5571 strings; 394 fuzzy)
1 failing checks (0.1%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Co-authored-by: Szia Tomi <sziatomi01@gmail.com>
2024-05-30 03:16:29 +02:00
தமிழ்நேரம்
fda7a970db
Translation update by தமிழ்நேரம் <anishprabu.t@gmail.com> using Weblate
po/glossary/ta.po: 100.0% (212 of 212 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Glossary (Tamil)
Translate-URL: https://hosted.weblate.org/projects/gnucash/glossary/ta/

Translation update  by தமிழ்நேரம் <anishprabu.t@gmail.com> using Weblate

po/ta.po: 65.1% (3629 of 5571 strings; 1278 fuzzy)
503 failing checks (9.0%)
Translation: GnuCash/Program (Tamil)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ta/

Co-authored-by: தமிழ்நேரம் <anishprabu.t@gmail.com>
2024-05-30 03:16:29 +02:00
John Ralls
ad94999bef Merge branch 'fix-tests' into stable 2024-05-28 15:08:38 -07:00
John Ralls
5f18971afb SRFI-64 Handle run-test returning the runner instead of pass status.
Guile 3.0.5 fixed what they thought was a bug whering run-test returned
the rv of test-runner-on-final instead of the current test runner. Ctest
considered the returned object to be a successful test and always reported
the test passing.
2024-05-28 15:07:41 -07:00
Christopher Lam
e80249ce2b [Account.cpp] gnc_account_remove_split shortcuts removing last split
this speeds up book shutdown which empties the account splits in
reverse chrono order.
2024-05-27 07:03:42 +08:00
Szia Tomi
25a5e4417b
Translation update by Szia Tomi <sziatomi01@gmail.com> using Weblate
po/hu.po: 77.3% (4311 of 5571 strings; 394 fuzzy)
1 failing checks (0.1%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Co-authored-by: Szia Tomi <sziatomi01@gmail.com>
2024-05-26 11:09:25 +02:00
YOSHINO Yoshihito
a7231a8baa
Translation update by YOSHINO Yoshihito <yy.y.ja.jp@gmail.com> using Weblate
po/ja.po: 89.0% (4961 of 5571 strings; 262 fuzzy)
428 failing checks (7.6%)
Translation: GnuCash/Program (Japanese)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ja/

Translation update  by YOSHINO Yoshihito <yy.y.ja.jp@gmail.com> using Weblate

po/ja.po: 89.0% (4960 of 5571 strings; 263 fuzzy)
429 failing checks (7.7%)
Translation: GnuCash/Program (Japanese)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ja/

Translation update  by YOSHINO Yoshihito <yy.y.ja.jp@gmail.com> using Weblate

po/ja.po: 88.2% (4918 of 5571 strings; 305 fuzzy)
430 failing checks (7.7%)
Translation: GnuCash/Program (Japanese)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ja/

Translation update  by YOSHINO Yoshihito <yy.y.ja.jp@gmail.com> using Weblate

po/ja.po: 88.2% (4915 of 5571 strings; 308 fuzzy)
430 failing checks (7.7%)
Translation: GnuCash/Program (Japanese)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ja/

Co-authored-by: YOSHINO Yoshihito <yy.y.ja.jp@gmail.com>
2024-05-26 11:09:24 +02:00
Geert Janssens
ee98dcaa09 Doxygen - include the main page
With the move to toplevel this file was not part of any
include directory any more, so it has to be specified
explicitly
2024-05-25 14:14:21 +02:00
Robert Fewell
b34a8b0add Bug 798822 - Move to blank transaction
If the move to blank action is used when a register is displayed in
REG_STYLE_JOURNAL, the resulting highlighted cell is the split 'action'
cell. In all other register styles it is the 'date' cell so test for
the register style and decrement the vcell_loc.virt_row by one to move
to the 'date' cell.
2024-05-24 09:06:13 +01:00
Robert Fewell
bc5cac4aa2 Bug 799298 - Shortcut Ctrl-G does not work in the General Journal register for the default date value
The split list in the General Journal register contains the blank
splits of other open registers which the GUI hides in
split-register-load.c. As they are not entered, the entered date value
is 0 and they will be listed before any split with the default date
value. If such a split is used, nothing will happen.

To fix this use the same test to ignore these blank splits.
2024-05-24 09:06:13 +01:00
Geert Janssens
48185684ea Drop xcode bit from the Hacking file
It's obsolete. The project file it refers to no longer
exists in the source tree. cmake can generate an
xcodeproject if anyone wants to play with it.
2024-05-23 18:58:04 +02:00
Geert Janssens
6f128d2947 Move valgrind and callgrind information to our wiki 2024-05-23 15:43:38 +02:00
Geert Janssens
e8e179fd8f Drop remainder of files in libgnucash/doc
Relevant diagrams have been added in the wiki as png files.
The html files with financial calculations are copyrighted
by someone outside of the gnucash project. I'd rather not
add that info to the wiki. Similar information should be
easy to find on the internet.
2024-05-23 15:10:05 +02:00
Geert Janssens
387b4988e5 Move doxygen target and related files to toplevel.
Note: this also means the target directory changes from
      libgnucash/docs/html
      to
      [toplevel]/doxygen/html
2024-05-23 15:10:05 +02:00
Geert Janssens
c816d2b34f Doxygen - minor cleanup of gnc-lot.h 2024-05-23 15:10:05 +02:00
Geert Janssens
e8d72ad53f Doxygen - merge separate txt files into respective header files 2024-05-23 15:10:05 +02:00
Geert Janssens
6cd8e4e458 Doxygen - drop obvious cases of deprecated code 2024-05-23 15:10:05 +02:00
Geert Janssens
d8ac86afd7 Integrate callgrind documentation into Hacking 2024-05-23 15:10:05 +02:00
Geert Janssens
cf7ff07624 Move libgnucash/doc/xml to libgnucash/backend/xml/DTD 2024-05-23 15:10:05 +02:00
Geert Janssens
da12a212c3 Drop old migration script to split qof from engine 2024-05-23 15:10:05 +02:00
Geert Janssens
891b921c81 Update doxygen.cnf file to more recent release 2024-05-23 15:10:05 +02:00
Geert Janssens
005112954c Some cleanup of the doxygen main page 2024-05-23 15:10:05 +02:00
Geert Janssens
39aa5f9c09 Remove texi design document in engine
It's extremely out of date and we no longer use it to keep track
of our design decisions and suggestions.

Only a section on KVP policy has been move into kvp_doc.txt
as it may make sense there.
2024-05-23 15:10:05 +02:00
Geert Janssens
48b9fa80ce Doxygen - strip obsolete info from loans.txt 2024-05-23 15:10:05 +02:00
Geert Janssens
58b4ee35f0 Doxygen - drop several txt files that were included in
docygen_mainpage.c

None of them had useful information describing actual
implementation concepts or details.
2024-05-23 15:10:05 +02:00
Geert Janssens
3c860737f1 Doxygen - fold business.txt file in the respective source files
The file mostly had short descriptions that were very similar
to the descriptions of business objects it referred to. The
exception was an explanation of how the billing terms and
tax tables handled their immutable copies. That bit has been
moved to its own group under the Business group and is referenced
from the BillTerm and TaxTables group.

This commit also fixes rendering of the Address doxygen info
and expands the BillTerm info to explain how proximo due dates
work.
2024-05-23 15:10:05 +02:00
Christopher Lam
038405b370 Revert "[account.cpp] gnc_account_remove_split searches from the end"
This reverts commit 5aff4fb57d. Was not
tested properly...
2024-05-21 22:58:00 +08:00
Christopher Lam
5aff4fb57d [account.cpp] gnc_account_remove_split searches from the end
because removing the latest split is far more common (e.g. from ui or
during book shutdown) than removing an early split.
2024-05-21 20:31:16 +08:00
Christopher Lam
2d030c5af1 Merge branch 'statusbar-ofx-download' into stable #1940 2024-05-20 22:23:42 +08:00
Christopher Lam
0df1372f2e [gnc-ofx-import.cpp] show message while deduplicating download 2024-05-20 12:44:47 +08:00
Szia Tomi
10de30a5ab
Translation update by Szia Tomi <sziatomi01@gmail.com> using Weblate
po/hu.po: 77.3% (4309 of 5571 strings; 394 fuzzy)
1 failing checks (0.1%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Translation update  by Szia Tomi <sziatomi01@gmail.com> using Weblate

po/hu.po: 77.3% (4309 of 5571 strings; 394 fuzzy)
1 failing checks (0.1%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/

Co-authored-by: Szia Tomi <sziatomi01@gmail.com>
2024-05-20 03:02:01 +00:00
Christopher Lam
448e9ac255 Merge branch 'speed-up-book-close' into stable #1941 2024-05-20 08:05:29 +08:00
Christopher Lam
370a06fb61 [qofid.cpp] remove unnecessary struct 2024-05-20 08:05:01 +08:00
Christopher Lam
fe2cdf42c7 [transaction.cpp] speed up book close 2024-05-19 20:19:29 +08:00
Christopher Lam
d21d6f9344 [qofid.cpp] qof_collection_foreach_sorted 2024-05-19 20:19:29 +08:00
Christopher Lam
d0851d1c6f [gnc-ofx-import.cpp] use stl containers and string 2024-05-18 19:18:31 +08:00
Christopher Lam
a207392a6b [gnc-ofx-import.cpp] reindent for easier read 2024-05-18 11:41:57 +08:00
Geert Janssens
03622b03d0 CsvImp - refactor of GncTxImport::set_column_type and helper functions
...to improve readability.
2024-05-16 19:47:07 +02:00