Commit Graph

20583 Commits

Author SHA1 Message Date
Frank H. Ellenberger
5d7ca8b556 fix make pot warning
gnucash/gnome/gnc-split-reg2.c:921: warning: Empty msgid.  It is
reserved by GNU gettext:
2018-12-29 03:08:48 +01:00
Frank H. Ellenberger
3466ce78b1 Rewordening of terms in income-gst-statement.scm
https://lists.gnucash.org/logs/2018/12/27.html#T12:31:58
and https://lists.gnucash.org/logs/2018/12/28.html
2018-12-29 02:18:50 +01:00
John Ralls
9bfaada356 Bug 796961 - Can't overwrite existing MYSQL database, V3.3.
Because m_exists was left true after dropping it, so the new
database wasn't created.
2018-12-28 13:22:40 -08:00
John Ralls
1116ce909b Bug 796967 - gnclock table not removed when using PostgreSQL.
Because of https://sourceforge.net/p/libdbi-drivers/bugs/24.
This issue causes trouble in save_may_clobber_data() as well, so
work around it by using a SQL query instead of dbi_conn_get_table_list.
2018-12-28 13:22:40 -08:00
Geert Janssens
267852ba76 Add a note on cvt and imbuing locales in a boost::filesystem::path object 2018-12-28 18:47:06 +01:00
Geert Janssens
272ca421b7 Set up filepath utils to determine the GNC_CONFIG_HOME in the same way as GNC_DATA_HOME
Until now GNC_CONFIG_HOME was more or less hard-coded.
Now it can be set via environment variable GNC_CONFIG_HOME.
In addition it will automatically be created to avoid potential
user confusion.
2018-12-28 18:36:52 +01:00
Geert Janssens
ac2e0946ea Rewrite path scrubbing in a c++ way 2018-12-28 16:15:00 +01:00
Robert Fewell
2634f23f87 Bug 767772 - Associated file with transaction is lost
when moving entry between accounts

When using the cut transaction option the 'associated file' value was
not being pasted to the new transaction. Added scheme code to get this
value and save it to new transaction when using 'cut/copy' and then
'paste' operations. When using the duplicate option, a dialogue allows
you to keep the copied association or not. It does not get copied for
autocomplete.
2018-12-28 09:45:50 +01:00
Geert Janssens
692e22668b Silence deprecation warnings in the gui
We only want warnings for our own deprecated functions in libgnucash.
2018-12-27 22:55:54 +01:00
Geert Janssens
d22e1db340 gnc-uri - refer to 'scheme' instead of 'protocol' as that's the more formal term used in uris
This involves renaming 3 functions:
gnc_uri_get_protocol -> gnc_uri_get_scheme
gnc_uri_is_known_protocol -> gnc_uri_is_known_scheme
gnc_uri_is_file_protocol -> gnc_uri_is_file_scheme

The *_protocol variants are marked as deprecated.
Additionally a number of local variables have been renamed from
protocol to scheme to support this change.
2018-12-27 22:33:17 +01:00
Geert Janssens
74ed802eae Show warnings for deprecated declarations
We're about to announce our own set of deprecated functions in libgnucash.
That would be pretty pointless if we also would silence all deprecation warnings
at the same time...
2018-12-27 22:25:18 +01:00
Geert Janssens
aaa71f2250 Fix memory leaks in dialog-file-acces.c:geturl 2018-12-27 20:53:33 +01:00
Geert Janssens
4b398325ea Redesign gnc-uri-utils
- gnc_uri_get_components will now return NULL as protocol if the input is a normal
  file system path instead of a uri (it used to return 'file')
- gnc_uri_get_protocol will now return NULL if the input is a normal
  file system path instead of a uri (it used to return 'file')
- gnc_uri_is_file_protocol now returns FALSE if protocol is NULL (it used to return TRUE)
- gnc_uri_is_file_uri now returns FALSE if input is a normal file
  system path instead of a uri (it used to return TRUE)
- a new function gnc_uri_targets_local_fs will return TRUE only if its input
  is either a file uri or a normal file system path. This function is now mostly
  used instead of gnc_uri_is_file_uri in the current code base
- a new function gnc_uri_is_uri is added to check whether its input
  is a valid uri (has protocol, path and hostname for non-file uris)
2018-12-27 20:53:33 +01:00
Geert Janssens
06da9e9712 Enable gnc-uri test suite
It was there but never run :(
2018-12-27 20:53:33 +01:00
Balló György
e61d5c472a Appdata: remove old property
Use the non-legacy metainfo directory for the appdata file.
2018-12-26 23:42:00 +00:00
John Ralls
d8be4e36e5 Merge Chris Lam's 'scheme-progress' into maint. 2018-12-25 14:17:47 -08:00
Christopher Lam
bcf5f7d751 [income-gst-statement] bugfix must not translate option names
This bug would cause report crash for localized builds because the
option names were localized and could never be retrieved from the
options tree.
2018-12-25 14:17:26 -08:00
Christopher Lam
a5057e8116 [income-gst-statement] allow i10n and fix comments 2018-12-25 14:17:26 -08:00
Christopher Lam
5ce280d5ef [net-charts] use srfi-1 map
This function was created manually and could be simplified by using
srfi-1 map, similar to category-barchart.scm. Much more readable.
2018-12-25 14:17:26 -08:00
Christopher Lam
6e8ac58d93 [report-utilities] introduce gnc:monetaries-add and gnc:monetary+
utility functions to add any number of monetaries

1. gnc:monetaries-add
   input: monetaries...
   output: commodity-collector

2. gnc:monetary+
   input: monetaries...
   output: monetary, assuming 1 commodity only
2018-12-25 14:17:26 -08:00
Christopher Lam
f697eb2f01 [transaction] convert nested if/then/else -> cond
This nested if/then/else snippet is more suited to (cond) syntax.
2018-12-25 14:17:26 -08:00
Christopher Lam
0850e004e2 [welcome-to-gnucash] update (format), use #f for destination
Old format calls without destination would trigger a guile-deprecated
warning. Simple amendment.
2018-12-25 14:17:25 -08:00
Christopher Lam
01a0bc2bb2 Invoice: Remove H1 title and superflous option.
Release Note: Printing the title twice is silly, so remove the option
and the H1 display of the title. Note that the remaining title is in
a div named "invoice-title" so it can be styled with CSS as the user
pleases from the Report Options Layout tab.
2018-12-25 14:12:12 -08:00
John Ralls
53680e6100 Merge Bob Fewell's 'fixes03' into maint. 2018-12-25 11:11:27 -08:00
John Ralls
0621abf3b1 Merge Pedro Albuquerque's Portuguese (Portugal) account templates update into maint
xplain why this merge is necessary,
2018-12-24 14:20:20 -08:00
Pedro Albuquerque
cd2698feda Portuguese (Portugal) account templates update 2018-12-24 14:16:00 -08:00
John Ralls
b8574a004a Merge Christoff Holterman's 'PR-Python-GetBalTaxValues' into maint. 2018-12-24 13:53:22 -08:00
John Ralls
d97508d0ac Merge Frank Oltmans's 'py_get_all_customers' into maint. 2018-12-24 13:45:10 -08:00
Frank Oltmanns
5675dad2f3 Update query for get_all_customers
Use same time of query in get_all_customers as in get_all_invoices
2018-12-24 13:42:22 -08:00
Robert Fewell
db663a298e If you use the autocomplete and cancel other registers are not refreshed
When the autocomplete is used the blank transaction gets the copy of
the originating transaction and if you decide to cancel this any other
open register that had a split in the new transaction is left with
blank rows where the transaction was. Add a test for the pending and
blank transaction being equal and refresh all registers if so.
2018-12-24 13:00:14 +00:00
Robert Fewell
3363736f9c Bug 796978 - Deleting a split of same account as register cancels the transaction without warning
When autocomplete is used, one of the splits takes on the reference to
the blank_split and if you delete this split the whole transaction is
removed. This change compares the split that is about to be deleted to
the blank_split and if the same moves the reference to another split.
2018-12-24 13:00:14 +00:00
Robert Fewell
9e3f50f9e7 The preference, use formal accounting labels does not update the header
With a register open and you change preference 'use formal accounting
labels' it does not update the register header so add a call back for
the preference.
2018-12-24 13:00:14 +00:00
Robert Fewell
ca57ff5043 Make the grid lines of totals Budget tree view track the preferences
Make the grid lines of the totals tree view track the preferences to
match the account tree view above it.
2018-12-24 13:00:14 +00:00
Robert Fewell
0ac2aa8021 Enable the GncTreeView to track the grid line preferences
With these changes when the preferences for showing horizontal or
vertical grid lines are changed it will update the GncTreeView
immediately.
2018-12-24 13:00:14 +00:00
Robert Fewell
c47e6aefe3 Add a couple of defines for the tree view grid lines 2018-12-24 13:00:14 +00:00
Robert Fewell
82d0fa187b Add some space to the budget options
Add some space to the budget options on the left so they are not right
next to the border. Also add a note to specify where the visibility of
accounts is found.
2018-12-24 13:00:14 +00:00
Robert Fewell
bd0e532415 Remove some white space and tabs in dialog-search.c 2018-12-24 13:00:14 +00:00
Robert Fewell
952761afa6 Bug 796945 - Search Search Criteria window does not scroll when added criteria exceed a certain amount
Add the criteria grid to a viewport and scroll window as suggested in
bug report. Also needed to add the hiding of the new scroll window as
required.
2018-12-24 13:00:14 +00:00
Robert Fewell
a8d0270e5a Disallow tabs in GtkTextView in glade files
Disallow the use of tabs in all glade GtkTextView's. This is mainly
used for notes fields and showing log entries. Some views were not
editable but for consistency the setting was also added to them.
2018-12-24 13:00:14 +00:00
Robert Fewell
5c524c31b2 Add routine to fix Account Color being set to "Not Set"
Previously the account color slot has been populated with "Not Set"
when any field for the account has been edited and saved. This routine
should run once and remove all such entries.
2018-12-24 13:00:07 +00:00
Christopher D. Carson
aaeb639d07 Performance fix in dom_chars_handler: use g_strndup instead of g_strdup
Because the origin string can be extraordinarly long, you get more
benefit from this than you would imagine
2018-12-24 13:46:48 +01:00
John Ralls
1a5c2dd254 Merge hauptsignal's 'ekr17' into maint. 2018-12-23 13:48:24 -08:00
hauptsignal
4c4f77ef50 Added template file to CMakeLists 2018-12-23 20:23:47 +01:00
John Ralls
4585f60dd9 Bug 796981 - Gnucash crashes with critical error when selecting another file
The problem is that if the currently open file has a report tab with
another tab to its right and selected then when the selected tab is
closed by the shutdown code Gtk sends a "realize" signal to the report
page. That sets an idle event to gnc_plugin_page_report_load_uri, but the
shutdown code proceeds to destroy the page and GnuCash has loaded the new
session before the idle event fires. By that time there's no page so
GNC_PLUGIN_PAGE_REPORT_GET_PRIVATE naturally returns NULL and the first
dereference crashes.

I couldn't find an easy way to avoid queuing the idle so I opted to protect
the function from the NULL priv.
2018-12-22 11:49:16 -08:00
Robert Fewell
43beeca079 Change the way colours are imported by the CSV account tree importer
When importing the account tree CSV file, change the importing of
colours so that only valid colours for accounts are updated, invalid
colours will result in the account color key slot being removed.
2018-12-22 18:16:17 +00:00
Robert Fewell
7a1f981b0c Change the sensitivity of the Cascade colour menu option
Enable the cascade colour menu setting only when the account being
cascaded from has sub-accounts.
2018-12-22 18:16:17 +00:00
Robert Fewell
fad17da72b Bug 796887 - Remove account slot key color if there is no valid color
If an existing account colour was specified and subsequently removed
the color key would be "Not Set". Change this to remove the key when
the colour is changed to default, i.e. removed.
2018-12-22 18:16:08 +00:00
Frank H. Ellenberger
294c932e3b de.po: Berichtige ein bisher nicht übersetztes Datum-Format
Follow up of commit 7f1a711
2018-12-22 01:20:45 +01:00
YOSHINO Yoshihito
7f1a711567 Bug 796989 - some date/time does not honor user locale
because now it looks for the user locale each time when it formats
datetime, I added Fixme comments.
2018-12-22 01:09:08 +01:00
Frank H. Ellenberger
b2e4148d6e Replace misleading comment for config.h 2018-12-21 07:21:04 +01:00