Commit Graph

21263 Commits

Author SHA1 Message Date
John Ralls
c140563e10 Typedef GNCSearchOwnerPrivate only once. 2019-06-03 10:12:42 -07:00
Geert Janssens
727348eff3 Restructure shell detection code
It will now first check for an environment variable GNC_SHELL and use
that if it exists. Then hardcode a shell if cmake detects the old
mingw environment (not mingw64), and finally fall back to cmake's
built-in method of finding bash.
This requires a fix in gnucash-on-osx for the build on that platform
to continue to work: on that platform, we should set GNC_SHELL
before starting the build. A patch has been submitted to do that
automatically for the user.
2019-06-03 11:14:17 +02:00
John Ralls
170651602c Restore WEBKIT1 function call, removed by mistake. 2019-06-01 12:55:50 -07:00
John Ralls
3a91eedb45 Fix new gcc-8 warning about strncat.
gcc-8 wants us to use strcat for string constants.
2019-06-01 12:55:17 -07:00
Adrian Panella
69ea174cd1 Bug 689753- Budget Report: Neg Num Not Colored Red
Use consistent formating in budget/actual/difference
showing negative budgets in red (same as actual/dif)
2019-05-31 19:30:33 -05:00
Adrian Panella
f6d607d787 Bug 624176 - budget report - rollup-budget ignored
The report's logic needs to allways rollup budget ammounts
so remove the option from the UI so as not to confuse the
user (it wasn't used anyway)
2019-05-31 19:30:22 -05:00
Christopher Lam
885689b42d [options] bugfix don't override inbuilt list keyword
fixing a 17 year old bug.

previous version had defined (save-acc list count) and (save-item list
count) thereby overwriting the inbuilt 'list' keyword, and tried to use
the it later on with (list key)... best rewrite with neater code.
2019-05-31 23:31:54 +08:00
Christopher Lam
6bca71f03b [view-column] various modernisation fixes 2019-05-31 23:23:07 +08:00
Christopher Lam
528d4b52b8 [view-column] compact loops, eradicate set!
simple modernising loops
2019-05-31 23:22:44 +08:00
Geert Janssens
dfc3d27490 Bug 797104 - Translations not showing in receipt options
Mark thank you string as translatable as well.
2019-05-30 14:58:41 +02:00
Geert Janssens
51ffcae9b8 Merge branch 'Bug-787018' of https://github.com/EvansMike/gnucash into maint 2019-05-28 17:48:18 +02:00
Geert Janssens
4ffc4d046f GncEntry - Fix inverted comparison 2019-05-28 17:19:29 +02:00
Christopher Lam
5873980c0c replace guile strftime with gnc-print-time64
addendum to ed42f8ac

guile's strftime is/was buggy; cannot handle non-UTF8 locales. Use
gnc_print_time64 instead. see the following

http://lists.gnu.org/archive/html/bug-guile/2019-05/msg00003.html
2019-05-28 18:42:32 +08:00
John Ralls
957df9a32b Add a +0000 offset to ISO8601 timestamps in the XML backend.
Apparently GnuCash for Android hard-coded the offset spec into their
parser, so it can't import XML files without it.
2019-05-27 14:51:06 -07:00
John Ralls
f76226f912 Fix broken CSV Import tests. 2019-05-27 14:51:06 -07:00
Geert Janssens
e557b021d3 CsvImport - Fix mishandling of quoted empty fields 2019-05-27 22:42:10 +02:00
Christopher Lam
ed42f8acb6 Bug 797197 - Transaction report: Error message when sorting on month
guile's strftime is/was buggy; cannot handle non-UTF8 locales. Use
gnc_print_time64 instead. see the following

http://lists.gnu.org/archive/html/bug-guile/2019-05/msg00003.html
2019-05-27 21:20:29 +08:00
Geert Janssens
8447f42674 Bug 797126 - It is annoying to run cmake to get an updated mo file
Add missing dependency in order to make the po-gmo and po-gmo-build targets acually work.
2019-05-27 14:50:36 +02:00
Geert Janssens
712714cf94 Bug 797207 - Chart reports show blank when run from the build directory
jqplot files were not copied to the build environment
2019-05-27 14:50:36 +02:00
Christopher Lam
49334906ae [test-report-utilities] reactivate 'debugging tools' section
This commit reactivates test section, which was disabled to hide a
date-related test failure. See Bug 797139 for more details.
2019-05-27 20:46:06 +08:00
Adrian Panella
6888bb30a2 [budget report] Fix multiple currency budget rollup 2019-05-25 10:50:52 -05:00
Geert Janssens
be1484841c One more minor cmake cleanup 2019-05-25 12:11:53 +02:00
Geert Janssens
b7479e8fb0 Bump minimum cmake version to 3.5
This version is available for all supported platforms and distros
(CentOS can have a version via EPEL, which is required anyway)

Advantages:
- one cmake version for all platforms
- we can drop all conditions based on cmake version
2019-05-25 12:04:51 +02:00
Christopher Lam
ae76a29453 [aging] bugfix avoid report-crash when no APAR account exists
need additional sanity checks.

in a book with no suitable AP/AR account, from 'Customers Overview'
spreadsheet, clicking 'Customer Listing' may call aging.scm renderer
with account = #f leading to report crash.
2019-05-25 15:30:54 +08:00
Christopher Lam
efe88f13a8 [balsheet-pnl] link pnl->transaction-report inherits common-currency 2019-05-25 15:30:54 +08:00
John Ralls
2d4f771bed Merge Adrién Panella's 'budget' into maint. 2019-05-23 09:50:20 -07:00
Christopher Lam
311f7d26e6 [dialog-tax-table] implement renaming of Tax Table name
Adds a new button 'Rename' in dialog-tax-table.
2019-05-20 15:43:23 +08:00
Adrian Panella
f6df367f50 [budget] Remove unused code
Remove some priv attributes and code that were never used
2019-05-18 14:35:28 -05:00
Adrian Panella
51dda77057 Bug 577968 - Values are not stored by pressing <TAB> in budget page
Also fix duplicates: 760194
2019-05-18 14:35:28 -05:00
Adrian Panella
91aceaa71b Bug 781345 - Equity disregarded by budget totals 2019-05-18 14:35:28 -05:00
Adrian Panella
d16a236ece [Budget] Fix negative Numbers Not Colored Red 2019-05-18 14:35:11 -05:00
Adrian Panella
0319144ba6 Bug 788157 - Open Budget Menu Item Doesn't Select Default Budget 2019-05-17 23:12:19 -05:00
Adrian Panella
5bb54d073c [budget] Fix error in qof_book property path
The "Default budget" property had an erroneus path
and was not returning any value.
2019-05-17 23:12:19 -05:00
Adrian Panella
df1cc5902b Bug 676810 - Wrong accounting in multi-currency budget report
Adds multicurrency support in budget page
Convert currencies before summing up to parent and totals.
2019-05-17 23:12:11 -05:00
Adrian Panella
52895eabd1 Bug 679800 - Shortcut to allow population of all budgeting periods
Add functionality to change at once the budget for all
periods of selected accounts.
It can :
replace with a new value
unset the budget
add a value to current budget
multiply current budget with value

Solvese issue #679800 and a duplicates (#639404, #760634)
2019-05-17 23:11:48 -05:00
Christopher Lam
b26276cba4 Bug 797241 - Some reports skip transactions of the last day of the selected period
portfolio.scm and advanced-portfolio.scm were not taking into account
transactions dated on the report-date. expand query so that end-date
is 23:59:59 rather than somewhere mid-day.
2019-05-17 23:07:19 +08:00
Robert Fewell
416b79d304 Reformat source files gnc-accounting-period.*
Change tabs to white space and some other white space changes.
2019-05-17 11:01:24 +01:00
Robert Fewell
037f5ed5be Bug 797089 - Wrong time for accounting period end date
In the Preferences/Accounting Period, there is an option to specify
absolute dates but the end date was being set to start of day instead
of end of day, changed this.
2019-05-17 11:01:24 +01:00
Robert Fewell
5ad3cd0d60 Deleting TaxTable entries can crash application
Change the switch statement to include GNC_AMT_TYPE_VALUE to return a
value for row_text[1] and change default to set it to NULL
2019-05-17 11:01:24 +01:00
Robert Fewell
fade13f813 Setup some default sorting for the TaxTable entries 2019-05-17 11:01:24 +01:00
Robert Fewell
36574f08fb After editing the TaxTables the selection has moved 2019-05-17 11:01:24 +01:00
Christopher Lam
e3fb593edc Bug 797240 - Multicolumn report not showing each report name
reportname was not correctly applied as the chart-title
2019-05-17 11:11:30 +08:00
Geert Janssens
539be984e5 Fix mnemonic behavior on business preferences page 2019-05-16 19:01:31 +02:00
Frank H. Ellenberger
aeb7e690b5 Use standard buttons and add more mnenoics to Aqbanking dialogs
Part of Bug 797232
2019-05-16 17:37:28 +02:00
Christopher Lam
f779b81719 [balsheet-pnl] unrealized-gain calculator bugfix
The unrealized-gain calculator was flawed.

The fixed function is copied from balance-sheet.scm and adapted to
balsheet-pnl.scm vars.

This fixed function matches unrealized-gains amounts from
balance-sheet.scm
2019-05-16 19:08:07 +08:00
Christopher Lam
0ecfc911ca [balsheet-pnl] chart: set report-currency to most used currency
This is a usability upgrade.

This balsheet-pnl report does *not* enforce a report currency; it can
print, process and multilevel-total monetary amounts in their original
currency.

But a linked chart needs one. By default it uses global
report_currency which may not match the book's most used currencies.

This commit will scan the accountlist, retrieve the most common
currency used, and set it as the report-currency for the linked
chart.

The book-main-currency function *may* be upgraded to
report-utilities.scm in the future.

Case example:
* set gnc_default_report_currency to USD
* load book.gnucash with majority accounts in EUR, some in GBP
* run balsheet-pnl.scm - shows EUR and GBP amounts and mixed totals.
* click link to barchart - would not succeed because all amounts
  converted to USD0.00. this commit will ensure barchart's target
  currency is set to EUR thereby showing useful chart.
2019-05-16 19:05:53 +08:00
Adrian Panella
93bf1a0f23 Bug 646361 - Estimate budget option to have same amount in each budget period
If set, all periods get the same budget, from the average
of the reference period.
2019-05-15 21:53:35 -05:00
Mike Evans
75a919b283 Bug 751290 - Rethinking the invoice ledger view
Fix indent and add a note for translators.
2019-05-15 07:12:50 +01:00
Frank H. Ellenberger
a63adac4c5 Rise minimum required CMake version for Linux to 3.2
This will allow us to use modules like FindIntl.
https://lists.gnucash.org/logs/2019/05/14.html#T17:32:19
2019-05-15 00:18:25 +02:00
Frank H. Ellenberger
29f605bd1b Move I18N modules in one section of CMakelists.txt 2019-05-14 23:44:18 +02:00