Commit Graph

21715 Commits

Author SHA1 Message Date
Christopher Lam
545454e347 [income-statement] remove dead code
indent and tabbing are constant, refactor them out
2019-09-30 16:07:27 +08:00
Christopher Lam
18c79a8a6a [trial-balance] remove dead code 2019-09-30 16:07:27 +08:00
Christopher Lam
b481e2ea7b [budget-balance-sheet] remove dead code
indent and tabbing are constant, refactor them out
2019-09-30 16:07:27 +08:00
Christopher Lam
e579f6af56 [balance-sheet] remove dead code 2019-09-30 16:07:27 +08:00
Christopher Lam
c21d173c06 [equity-statement] remove dead code
* 'balance' in add-report-line was defined but never used
* capital/drawing accounts are not defined. remove.
2019-09-30 16:07:27 +08:00
Christopher Lam
99b5d79a44 [equity-statement] compact and rename to add-report-line 2019-09-30 16:07:27 +08:00
Christopher Lam
fd6b102f8e [equity-statement] compact functions 2019-09-30 16:07:27 +08:00
Christopher Lam
1da86a5fe4 [equity-statement] define vars in formals instead of set! 2019-09-30 16:07:27 +08:00
Christopher Lam
187d383385 [test-equity-statement] initial commit 2019-09-30 16:07:27 +08:00
Christian Stimming
82e9b14dc5 [aqbanking] Bug 797430: Avoid double init of gui
Patch by Mike Pieper. Thanks!

Explanation for why this is necessary: The previous (old) behaviour
changed in 62f7aa66. Before this commit (or when AQBANKING6 is not
set) it calls AB_JobSepaTransfer_new. For AQBANKING6 it calls
AB_Transaction_new. AB_Transaction_new is not using gui. Therefore
gui->state stays on INIT, while before it made several status changes
(=> RUNNING, FINISHED, HIDDEN). On second call to gnc_GWEN_Gui_get it
checks the state and finds it still in INIT which seems to be wrong.

So the right fix is to either use gui in AB_Transaction_new or to
remove first allocation, which is done here.
2019-09-29 21:58:42 +02:00
Christian Stimming
bb4aa19a3d [i18n] German translation update
Total: 5330 translated, 5 fuzzy, 23 untranslated.
2019-09-29 21:45:18 +02:00
Christopher Lam
307ca4e27d [equity-statement] compact functions and use collector arithmetic 2019-09-29 18:36:25 +08:00
Christopher Lam
5aa59e0ce1 [reports] eradicate gtkhtml hacks
string of   was used to widen cell to a minimum of 60px. use
min-width style attribute instead.
2019-09-29 18:28:59 +08:00
Christopher Lam
607fd6ff9b [equity-statement] compact unrealized gain calculator 2019-09-29 18:28:59 +08:00
Christopher Lam
1acbc0c1ec [balance-sheet] further compact, untabify 2019-09-29 17:51:21 +08:00
Christopher Lam
90d83e076c [balance-sheet] compact functions 2019-09-29 17:15:36 +08:00
Christopher Lam
dad5961b51 [balance-sheet] define vars in formals rather than set! 2019-09-29 17:15:36 +08:00
Christopher Lam
80296a3c8a [balance-sheet] use collector arithmetic 2019-09-29 16:41:07 +08:00
Christopher Lam
aae1143e34 [budget-income-statement] compact functions 2019-09-29 14:15:10 +08:00
Christopher Lam
08b1ee3711 [budget-balance-sheet] remove dead code, use collector arithmetic 2019-09-29 14:11:01 +08:00
Robert Fewell
1be9bfbf01 Bug 797397 - Import Map Editor, Ctrl-A with filter
If you use a filter and then use Ctrl-A to select all rows for deletion
all entries are deleted. This is due to the use of a tree store and the
Ctrl-A selecting the parent rows also.

To fix this a tree view 'select' function is used that does not allow
the parent rows to be selected with a filter.
2019-09-27 11:26:11 +01:00
Frank H. Ellenberger
ca01ce1700 Add a translator comment in csv price import 2019-09-26 21:25:36 +02:00
Frank H. Ellenberger
8fbf4cd0ec merge recent gnucash.pot into hr.po
5354 translated messages, 3 fuzzy translations.
2019-09-26 18:40:56 +02:00
milotype
d28ed1f7e3
Update hr.po file with 3.7 pot-file
update and some corrections
2019-09-24 22:19:22 +02:00
Christopher Lam
22cdd237f1 [test-portfolios] initial commit
1.1.1980 seed $10,000
1.2.1980 buy 1 AAPL @ $100
1.3.1980 buy 1 AAPL @ $200
1.5.1980 sell 1 AAPL @ $400, FIFO capgain = $300, less $10 fee
1.10.1980 1:10 stock split 1 to 10 AAPL, price now $40
1.11.1980 1:10 stock split 10 to 100 AAPL, price now $4
1.12.1980 3:1 stock split 100 to 33 AAPL, price now $12;
          cash-in-lieu for 1/3 AAPL = $4

tests both portfolio.scm and advanced-portfolio.csm
tests report output using average/fifo/lifo

pending: DRP etc
2019-09-24 23:07:47 +08:00
Christopher Lam
298724dd93 [portfolio] there's no report-currency. use currency. 2019-09-24 23:03:27 +08:00
Robert Fewell
ee260d8e3a Bug 797416 - Enter key does not move to blank tx or next line
Caused by a previous commit that did not allow for just pressing the
enter key without changes to move to the next transaction. This was
part of a change to stop being asked to create a new account many times
when the transfer cell had been changed and declining it. To fix this
when gnc_split_reg_record returns false, test for the current cursor
changed flag being not set to proceed to do the move.
2019-09-23 13:30:34 +01:00
Christopher Lam
9832fa397a [window-report] show backtrace when report crashes
* exposes a SCM string last-captured-error containing last backtrace
* when rendering report-crash window, include it
2019-09-23 17:55:25 +08:00
Christopher Lam
a259ba4a3e [utilities] move gnc:html-string-sanitize to utilities.scm 2019-09-22 22:48:07 +08:00
Christopher Lam
1a6314e108 [account-summary] tag col headers properly to fix formatting
With this commit the col headers are now properly formatted. Change
tests because the tag is now th instead of td therefore sxml (looking
for td) can't find them anymore.
2019-09-21 20:47:27 +08:00
Christopher Lam
3a24468155 [account-summary] cleanup
* shorten identifier names
* compact functions
* use eq? as appropriate instead of equal? when comparing symbols
* omit splitting up and recombining accounts
* minimise use of set! and define vars in let* formals
* instead of (if pred? (begin ...)) use (when pred? ...)
* use efficient gnc:accounts-and-all-descendants
2019-09-21 20:13:18 +08:00
Christopher Lam
67fa04adbd [account-summary] *reindent/untabify/delete-trailing-whitespace* 2019-09-21 20:12:22 +08:00
Christopher Lam
594822f043 [account-summary] merge in sx-summary.scm
* remove sx-summary.scm and merge into account-summary.scm
* modify test-account.scm
2019-09-21 20:12:00 +08:00
Christopher Lam
cda11dbd6f [test-account-summary] initial commit 2019-09-21 19:33:21 +08:00
Christopher Lam
24393b6f5c [utilities] fix comment use official gnu mail archive 2019-09-21 19:33:21 +08:00
Christopher Lam
496ca94a98 [reports] use new API gnc:collector+ and gnc:collector- 2019-09-21 13:50:38 +08:00
Christopher Lam
f72df3e1bc [report-utilities] gnc:account-get-balances-at-dates: use quicksort
stable-sort! is slower than quicksort.
2019-09-21 13:50:38 +08:00
Christopher Lam
7587c3b4e3 [API] gnc:collector+ and gnc:collector- for collector arithmetic
(gnc:collector+ ...) equivalent to (+ ...)
(gnc:collector- ...) equivalent to (- ...) and will also handle
single-argument sign negation.
2019-09-21 13:46:15 +08:00
Christopher Lam
0511ce723e [API] gnc:list-flatten flattens lists recursively
and is a schemey algorithm rather than a report algorithm, so, belongs
centrally.
2019-09-21 11:18:26 +08:00
Christopher Lam
7a662272b3 [invoice] render tax/tax number into 'our-details' section 2019-09-20 14:57:57 +08:00
Christopher Lam
2da5944596 [taxtxf-de_DE] fix invalid code
(unless book ...) is equivalent to (if (not book) ...) therefore this
snippet was incorrect.

previous commit ensures book always returns a non-#f object therefore
there's no need to handle #f anymore.
2019-09-20 14:57:57 +08:00
Christopher Lam
3208879e64 [app-utils] upgrade Tax/Tax Number option to all locales
Previously de_DE locale will add a *global* 'Tax/Tax Number'
option. This is immediately translated.

This change will upgrade it to be present in all locales, and can be
queried by any report.
2019-09-20 14:57:57 +08:00
Christopher Lam
49372e76be Ensure book returns current-book
fixes https://lists.gnucash.org/pipermail/gnucash-user/2019-September/086967.html

because occasionally account will be null or #f, causing error when
passed to gnc-account-get-book.
2019-09-20 14:57:53 +08:00
Christopher Lam
0ab0d23b00 Bug 797418 - In budget report, column with Actual Totals for Liabilities and Income are reversed
budget.scm had some cleanup whereby totals were accumulated but are
now re-retrieved. Forgot to reverse actuals for some account signs
reversals.
2019-09-20 11:12:37 +08:00
Christopher Lam
656d2718d8 [trial-balance] compact (collect-unrealized-gains)
use functional style
2019-09-19 21:53:09 +08:00
Christopher Lam
6b573de128 [trial-balance] use coll-plus and coll-minus for functional style 2019-09-19 21:53:09 +08:00
Christopher Lam
acf359a797 [trial-balance] upgrade coll-plus and coll-minus to report-wide fns 2019-09-19 21:53:09 +08:00
Christopher Lam
f88c54bb50 [trial-balance] use gnc:commodity-collector-get-negated 2019-09-19 21:49:13 +08:00
Christopher Lam
0c9c9c2594 [test-trial-balance] augment to test unrealized gains
these were already tested -- see previous tests *do* include
'unrealized losses'. augment by adding another couple foreign transfer
to change the unrealized gain/loss amount.
2019-09-19 21:45:07 +08:00
Christopher Lam
16da1acf1d Merge branch 'typos1' of git://github.com/luzpaz/gnucash into luzpaz-typos1 2019-09-18 21:36:29 +08:00