Robert Fewell
853791cbf7
Fix lockup on Windows in completioncell
...
Missed updating an 'if' clause which resulted in a negative offset for
previous character.
2023-06-13 15:48:59 +01:00
Richard Cohen
c87f9db9ef
Refactor: remove unnecessary GncTreeModel*Private
2023-06-13 14:02:21 +01:00
Richard Cohen
1084071be6
Refactor: hide implementation of GncTreeModel* (move from .h -> .c)
2023-06-13 14:02:21 +01:00
Richard Cohen
ae352e9efe
Refactor: Remove unused GncTreeModelSelection
2023-06-13 14:02:21 +01:00
Richard Cohen
91863dfb4b
Refactor: DECLARE_FINAL GncTreeModelPrice < GncTreeModel
2023-06-13 14:02:21 +01:00
Richard Cohen
1c40aa8a77
Refactor: DECLARE_FINAL GncTreeModelOwner < GncTreeModel
2023-06-13 14:02:21 +01:00
Richard Cohen
45c3f2831a
Refactor: DECLARE_FINAL GncTreeModelCommodity < GncTreeModel
2023-06-13 14:02:21 +01:00
Richard Cohen
241afec3a8
Refactor: DECLARE_FINAL GncTreeModelAccount < GncTreeModel
2023-06-13 14:02:16 +01:00
Richard Cohen
97a5bf0a3d
Refactor: DECLARE_FINAL GncTreeModelAccountTypes < GObject
2023-06-13 14:01:35 +01:00
Richard Cohen
80fdffb07b
Refactor: DECLARE_DERIVABLE GncTreeModel < GObject
2023-06-13 14:01:29 +01:00
Richard Cohen
a8943dc315
Refactor: remove unnecessary GNCSearch*Private
...
- rename parent to parent_instance
- remove unused member dummy
2023-06-13 11:39:10 +01:00
Richard Cohen
4eb20b2456
Refactor: hide implementation of GNCSearch* (move from .h to .c)
2023-06-13 11:38:56 +01:00
Richard Cohen
5d3eaa51c7
Refactor: DECLARE_FINAL GNCSearchOwner < GNCSearchCoreType
2023-06-13 11:37:59 +01:00
Richard Cohen
8cb697b8a9
Refactor: DECLARE_FINAL GNCSearchString < GNCSearchCoreType
2023-06-13 11:37:59 +01:00
Richard Cohen
b1d1f6b8d1
Refactor: DECLARE_FINAL GNCSearchReconciled < GNCSearchCoreType
2023-06-13 11:37:59 +01:00
Richard Cohen
bd6083278d
Refactor: DECLARE_FINAL GNCSearchNumeric < GNCSearchCoreType
2023-06-13 11:37:59 +01:00
Richard Cohen
f1a77ca782
Refactor: DECLARE_FINAL GNCSearchInt64 < GNCSearchCoreType
2023-06-13 11:37:59 +01:00
Richard Cohen
0b215793b6
Refactor: DECLARE_FINAL GNCSearchDouble < GNCSearchCoreType
2023-06-13 11:37:59 +01:00
Richard Cohen
f935d7868b
Refactor: DECLARE_FINAL GNCSearchDate < GNCSearchCoreType
2023-06-13 11:37:59 +01:00
Richard Cohen
74517c44a5
Refactor: DECLARE_FINAL GNCSearchBoolean < GNCSearchCoreType
2023-06-13 11:37:59 +01:00
Richard Cohen
a6dcdb6a68
Refactor: DECLARE_FINAL GNCSearchAccount < GNCSearchCoreType
2023-06-13 11:37:59 +01:00
Richard Cohen
53ab52fa4e
Refactor: DECLARE_DERIVABLE GNCSearchCoreType < GObject
...
- remove unused GNCSearchParam *param
2023-06-13 11:36:57 +01:00
John Ralls
38118a2ad6
Bug 798948 - XML file corrupted by saving twice in extremely short period
...
Prevent reentrance with gnc_file_save_in_progress().
2023-06-12 17:00:45 -07:00
John Ralls
75fb523c36
Merge Simon Arlott's 'bug-798695' into stable.
2023-06-12 15:48:50 -07:00
John Ralls
57b8006a66
Merge Simon Arlott's 'bug-777472' into stable.
2023-06-12 15:45:41 -07:00
John Ralls
2e20b37d04
Merge Paolo Maero's 'money-out' into stable.
2023-06-12 14:45:19 -07:00
John Ralls
0d1ba1ebe7
Merge Richard Cohen's 'y2038-fixes' into stable.
2023-06-12 14:44:11 -07:00
John Ralls
fb7c0328bc
Merge Richard Cohen's 'remove-unused-osx_accel_map' into stable.
2023-06-12 14:43:09 -07:00
John Ralls
770b5a4be9
Add new completioncell-gnome.c to POTFILES.in
2023-06-12 11:19:29 -07:00
John Ralls
0c64c98a93
[stock-txn-asst] Remove conflict markers.
2023-06-12 11:18:11 -07:00
Christopher Lam
8ec6a4cb12
[Scrub.c] 8628ca8715
rewritten to avoid QofQuery
...
because QofQuery will include the blank transaction which must not be
scrubbed.
2023-06-12 23:59:37 +08:00
John Ralls
6d60c11252
Merge Bob Fewell's 'revised-reg-desc' into stable.
2023-06-11 13:11:41 -07:00
John Ralls
96e349ba8d
Merge Christopher Lam's 'stock-txns-mvc' into stable.
2023-06-11 13:08:51 -07:00
John Ralls
c4e0ddb819
[stock-txn-asst] Don't use the initial value in amount edit widgets.
...
Unless they're valid. Otherwise the invalid value will log an error
that will prevent later valid input from working.
2023-06-11 12:22:24 -07:00
John Ralls
186963109d
[stock-txn-asst] Remove some superflous declarations.
2023-06-11 12:22:02 -07:00
John Ralls
43b161c28b
[stock-txn-asst] Add comments explaining workings.
2023-06-10 18:24:07 -07:00
John Ralls
f4ac1f40fe
[stock-txn-asst] Extract page classes for StockAssistantView.
2023-06-10 18:24:07 -07:00
John Ralls
fdfa8353dd
[stock-txn-asst] Extract StockTransactionEntry classes.
2023-06-10 18:24:07 -07:00
John Ralls
b3b071e011
[stock-txn-asst] StockAssistantModel variable names
...
Rename member variables with m_ prefix, remove this-> from
in-class references to those variables.
2023-06-10 18:24:07 -07:00
John Ralls
cebc7198f2
[stock-txn-asst] Reformat StockAssistantModel
...
Moving the ctor and dtor to immediately after the variables and
moving the longer function defs out of the class decl.
2023-06-10 18:24:07 -07:00
John Ralls
925999e070
[stock-txn-asst] Refactor check_page into a constructor.
...
Because it is one.
2023-06-10 18:24:07 -07:00
John Ralls
4ebc028740
[stock-txn-asst] Refactor gtest-assistant-stock-transaction.cpp
...
For better readability. Removes gratuitous parameterized test
suite because the StockAssistantModel is stateful and can't
use easyTestCases when it and the book are re-created for
each instance, as is the case when the easyTestCases is passed
as a parameter set to a test suite.
Also replaced the shared_ptr<QofBook> with a unique_ptr.
2023-06-10 18:24:07 -07:00
John Ralls
74f707bfa7
[asst-stock-trans] StockAssistantModel instance variable names
...
Should start with m_. Also designating them with this-> isn't
idiomatic or necessary, and long functions shouldn't be defined
in the class/struct body.
2023-06-10 18:24:07 -07:00
John Ralls
6d36d1d7ee
[asst-stock-trans] Rename primary callbacks to clarify their purpose.
2023-06-10 18:24:07 -07:00
Christopher Lam
0d9dd3b789
[assistant-stock-transaction] support additional txn_types
2023-06-10 18:24:07 -07:00
Christopher Lam
55046f22d2
reduce number of bools in txn_type info: fees_capitalize
2023-06-10 18:24:07 -07:00
Christopher Lam
d67f0b3c99
reduce number of bools in txn_type info: input_new_balance
...
input_new_balance merged into stock_amount FieldMask
2023-06-10 18:24:07 -07:00
Christopher Lam
d92d5b4bd2
test suite for assistant-stock-transaction.cpp
2023-06-10 18:24:03 -07:00
Christopher Lam
f36e5d56ed
[assistant-stock-transaction] refactor using MVC
2023-06-10 18:21:00 -07:00
Richard Cohen
7d26b8c05f
Fail the test if still using 32bit time_t in 2038
...
gtest-gnc-option.cpp and gtest-gnc-optiondb.cpp need to call
time() for g_date_set_time_t()
2023-06-08 14:30:32 +01:00