Commit Graph

21980 Commits

Author SHA1 Message Date
Robert Fewell
ce0d52e1ef Reports were not being loaded
The reports page uses a g_idle_add against the plugin_page to load the
report once the container for the report is realized. With the changes
to the page focus functions, the use of g_idle_remove_by_data removed
this idle function so no report. Change the page focus functions to
record the id used and then use this id to remove the page focus idle
function.
2020-02-16 14:37:43 +00:00
Christopher Lam
c60555e9c5 [stylesheet-css] reflect recent changes to default CSS
default css contains changes:
* td.highlight
* dark color schemes
2020-02-16 22:28:55 +08:00
Christopher Lam
555a467aba [new-owner-report] revert highlight trigger to onclick
and use Windows libwebkit1-compatible javascript
2020-02-15 22:25:21 +08:00
Christopher Lam
3ac60ed2e4 compact, use (ice-9 match) 2020-02-15 18:28:21 +08:00
Robert Fewell
b23d2445fc New budgets save state information with no changes
If you create a new budget and do not change any thing when closing the
budget or quitting with new budget open the state information for that
budget is saved but the budget is not. To fix this make a change to the
new budget description to force the save of the new budget.
2020-02-13 16:34:25 +00:00
Robert Fewell
7577afe0a9 Bug 796911 - Minimum window width to large.
This is down to the amount of information that is displayed on the
register status bar which can also be influenced by the type of
register being displayed. To fix this the text labels used have been
enabled to ellipsize at the end and also the displayed information has
been added to a tooltip. So for example the minimum app size was
957x736 and after the changes it can be 610x475.
2020-02-13 15:00:54 +00:00
Robert Fewell
f66b7ed275 Follow up to previous commit 94cb965
This commit moves the setting up of the page changed signal callback to
when the plugin page is inserted and also records the id used. This is
used to disconnect this callback when the page is moved to a different
window and also when the page is destroyed.
2020-02-13 10:34:56 +00:00
Christian Gruber
322f2d99de Rework key prefix matching
Use C string comparison instead of C++ function std::mismatch to increase
performance.
2020-02-10 22:31:29 +01:00
Christopher Lam
58ddb47f56 [new-owner-report] change highlight trigger: onclick to onmousedown
and also disable event propagation; this disables text selection
2020-02-09 11:29:28 +08:00
Christopher Lam
3be42bebb8 [test-new-owner-report] refine test to target exact table row 2020-02-09 10:35:03 +08:00
Christopher Lam
18acb42344 [new-owner-report] clarify payment-txn processor
use unique varnames
2020-02-09 10:34:58 +08:00
Christopher Lam
09d3e95379 [new-owner-report] if Payment amount is negative, label "Refund"
and add logic to properly handle AP/AR negation rules
2020-02-09 10:10:38 +08:00
Christopher Lam
6e64a37839 [new-owner-report] fix comment for non-document accumulator 2020-02-09 10:10:34 +08:00
Christopher Lam
19db1daed6 Bug 797419 - equity-statement unrealized-gain calculator uses weighted-average
for consistency. all other unrealized-gain calculators use average-cost.
2020-02-08 23:46:29 +08:00
Christopher Lam
7cbe367caf [new-owner-report] LHS invoice->payment LINK/PAYMENT merge
* invoice->payment LINK or PAYMENT txns are handled identically. Merge.
* reorder definitions in document handler.
* rename variable 'invoice' to 'document'; invoice was clashing with
  outer variable. This fixes a credit-note negation bug.
2020-02-08 23:46:17 +08:00
Christopher Lam
70d8acc7ac [test-new-owner-report] add tests for "$120 to partially repay" 2020-02-08 22:47:32 +08:00
Geert Janssens
1ccea05b6e CMake - drop LC_ALL=C for generation of appdata and desktop files
It doesn't seem to have any noticable effect.
2020-02-08 13:54:28 +01:00
Geert Janssens
cce69e37d2 Rework appdata and desktop file generation
- attempt to merge in translations before merging in version data
- add the intermediate file (with translations) to the dist tarball
- dist builds no longer have to run the translation merge, but can instead
  use the included intermediate file. This accomodates distros with
  older gettext versions.
2020-02-08 13:43:02 +01:00
Geert Janssens
8243496ed0 Rework our gettext tests
- only abort configuration if gettext is older than 0.18.1 (required for string extraction from scheme files)
- otherwise always continue but disable a few other build steps depending on the gettext version
- use feature variables to more clearly convey what is enabled or disabled
2020-02-08 13:19:23 +01:00
Geert Janssens
f27cbd4a11 Fix dist after renaming account directory hu_HU to hu 2020-02-08 13:19:23 +01:00
Christopher Lam
e90e9cbd8c [test-new-owner-report] initial commit
Tests some basic business transactions

* 1 invoice for $6.75

* 1 invoice for $11.50
  2 partial payments $1.50 and $2.00

* 1 credit-note for $3.00

* 1 invoice for $28
  1 credit note for $27
  1 payment linking both including $1 bank transfer
2020-02-08 09:02:12 +08:00
Christopher Lam
9a90e97009 [new-owner-report] negate RHS inv amounts if credit-note. 2020-02-08 09:02:07 +08:00
Geert Janssens
90e95ba8ef CMake - remove parameter repetition in else() and endif() statements - part 2
This follows Professional CMake's recommended practises
I missed plenty of these in my first commit. This one should fix
these remaining occurrences.
2020-02-06 16:16:36 +01:00
Christopher Lam
7f794bb26b Merge branch 'maint-fix-budget-totals' into maint 2020-02-06 20:37:43 +08:00
Christopher Lam
e523d52802 [eguile-gnc] show error after stacktrace
... which makes the error more visible
and reuse gnc:html-string-sanitize
2020-02-05 23:30:13 +08:00
Geert Janssens
a0fb7d3bd6 Merge branch 'patch-1' of https://github.com/pau4o/gnucash into maint 2020-02-05 16:25:19 +01:00
Geert Janssens
4f624087e1 Budget Treeview - reshuffle totals logic
The rearranged switch statements case on row_type rather than
account type. This gives better isolation of the account types
vs row_types in the conditions inside each case.
2020-02-05 16:02:49 +01:00
Geert Janssens
e79e82edcf CMake - remove parameter repetition in else() and endif() statements
This follows Professional CMake's recommended practises
2020-02-05 11:38:14 +01:00
Christopher Lam
8365283f18 Bug 797609 - Backtraces for eguile report errors strips wrong part of stack
Previous code used invalid algorithm to capture the desired error
stack. Use simpler capture code, which does not require capturing the
good stack.
2020-02-05 16:50:41 +08:00
Christopher Lam
bb986e474c [eguile-utilities] compact code, use (ice-9 match) 2020-02-05 16:50:41 +08:00
Christopher Lam
c94b433187 [commodity-utilities] compact code, use (ice-9 match) 2020-02-05 16:50:41 +08:00
Christopher Lam
ad094f4345 [report-utilities] compact code, use (ice-9 match) 2020-02-05 16:50:41 +08:00
Christopher Lam
dafff68914 [lot-viewer] show lot guid in headers
* also compact code, use partition
* also don't need to localise option string for debugging tool
2020-02-05 15:25:02 +08:00
Christopher Lam
b0b6f2c6eb fix budget totals for unreversed budgets books 2020-02-05 06:42:57 +08:00
Kamen Naydenov
a456c8a33c
Fix white text on white background
When dark theme is active in Gnome Shell it sets text colour to white, combined with background colour set in default style to white lead to unreadable reports.
2020-02-03 18:26:59 +02:00
Alex Aycinena
f1667e7ba8 Update US Income Tax information for more 2019 changes 2020-02-02 13:58:00 -08:00
gnucash-dev
a44bd34dcf Correct double-counting of accounts in some cases in US Income Tax Report. 2020-02-02 13:13:50 -08:00
Christian Gruber
a13184978a Fix calculation of token info to find exactly matching tokens only
In get_first_pass_probabilities() function
qof_instance_foreach_slot_prefix() is called with a prefix path
including closing slash after token now. This avoids, that also entries
with token as a substring are included in token info, where key only
starts with token.

Finally function build_token_info() checks, if the key suffix after the
token consists only of the GUID. This avoids, that also entries with the
same prefix and slashes are included in token info.
2020-02-02 18:00:27 +01:00
Christian Gruber
da60560ac4 Change behaviour of KvpFrame::for_each_slot_prefix()
Provided function func is now called with key suffix only instead of
full key (prefix is omitted). This is neccessary for fixing function
build_token_info() in the next commit.
2020-02-02 18:00:27 +01:00
Christian Gruber
9b3085a429 Add test cases to check for exact token matching 2020-02-02 18:00:27 +01:00
Christopher Lam
1e0983d0d8 Merge branch 'maint-202001-budget-editor-summaries' into maint 2020-02-02 14:40:05 +08:00
Christopher Lam
0c5bded6fc [report-utilities] streamline (match) use
reduces the indent level
2020-02-02 14:40:01 +08:00
Christopher Lam
97eb3c7e98 [new-owner-report] handle LINK txns as normal payments
With this commit, lot-splits which are part of LINK transactions are
handled similarly to PAYMENT splits -- the non-APAR var is renamed to
non-document to reflect their new role: collating all splits without
an attached invoice lot.
2020-02-02 14:40:01 +08:00
Christopher Lam
77c2bc2b9a [new-owner-report] simplify build-column-used 2020-02-02 14:40:01 +08:00
Christopher Lam
f59e3ca751 Bug 797551 - Budget totals line missing in 3.8
Reinstate Income/Expense/Transfer/Total, but rename to:

* Inflow from Income
* Outflow to Expense
* Outflow to Asset/Equity/Liability
* Remaining to Budget
2020-02-02 14:38:28 +08:00
Frank H. Ellenberger
3460918492 Merge PR #639 2020-02-01 18:52:45 +01:00
Frank H. Ellenberger
ec7e6c37d1 Add a warning for gettext < 0.20
They do not recognize <developer_name>GnuCash Project</developer_name>
in gnucash.appdata (https://savannah.gnu.org/bugs/?50408)
2020-01-31 01:52:52 +01:00
Rob Laan
321a74c81b Bug 797570 Import Customers/Vendors, Bills/Invoices: dialog with not imported rows does not expand with window size
In the import of Customer/Vendors en Bills/Invoice, the dialog that lists rows that were not imported shows a scrollable view of only four rows.
The view does not use the available space of the window, and does not expand with resizing the window. This change fixes this issue.
In the same functionalities, the dialog for a user defined regular expression has a similar issue. This changes also fixes that issue.
2020-01-30 17:51:12 +01:00
Christopher Lam
2adaf692b8 [lot-viewer.scm] initial commit
Simple report to visualise lots (business and non-business) in a
spreadsheet. Each column is a unique lot, and each row is a unique
transaction. The lot balance, and the associated lot invoice are also
included.

Each transaction is analysed to render the split in the lot column,
and non-lot splits are rendered in a last column.

An account must be chosen in options, and all splits in the specified
date range will be scanned to find unique lots which are all reported
in order of first appearance.

A heavy APAR account will lead to an impractical number of columns
signifying multiple lots, therefore date-range filtering and
description filtering are both encouraged to narrow down the list of
transactions.
2020-01-29 18:55:35 +08:00
Christopher Lam
67fbb2322c [new-owner-report] remove unused code 2020-01-29 18:55:35 +08:00