John Ralls
9062be3d47
Merge Simon Arlott's 'string-cache-fixes' into maint.
2021-08-04 14:26:27 -07:00
John Ralls
f6766d42ec
Merge Simon Arlott's 'string-cache-no-refcount-empty' into maint.
2021-08-04 14:19:21 -07:00
Christopher Lam
a5edacf0fc
[options.scm] Rename option name to "Levels of Subaccounts"
...
Original name "Show Accounts until level". Add backward compatibility
missed in 08f490ee98
2021-08-04 19:02:30 +08:00
Christopher Lam
23bd716451
g_free gnc-path's gchar* intermediate strings
2021-08-03 12:14:12 +08:00
Christopher Lam
f1e35daab3
Rename option name from "Extra notes" to "Extra Notes"
2021-07-23 06:25:01 +08:00
Christopher Lam
251db8c37b
Rename option name from "Report title" to "Report Title"
2021-07-23 06:25:01 +08:00
Christopher Lam
2606ddf905
Rename option name from "Invoice number" to "Invoice Number"
...
This ensures it matches all other invoice reports.
2021-07-23 06:24:55 +08:00
Simon Arlott
4a5b5f3bf2
Don't cache the empty string
...
Avoid unnecessary reference counting for uses of the empty string.
2021-07-11 18:54:49 +01:00
Simon Arlott
320df7e409
Use const return values for string cache
...
This is a prerequisite for being able to return "" (which is const) and
none of the returned values should ever be modified.
2021-07-11 18:54:49 +01:00
Simon Arlott
4132939612
Avoid leaking string cache entries for "" in Transaction and Split
...
When g_object_new() is used, the strings that default to "" are added to
the string cache. These are then not correctly removed when updating them
with new values when cloning a Transaction/Split.
Use CACHE_REPLACE instead of CACHE_INSERT.
2021-07-11 18:52:09 +01:00
John Ralls
e1c153a516
Bug 798224 - Scheduled transactions are created with date-entered...
...
copied from the template transaction.
2021-07-10 16:35:20 -07:00
Robert Fewell
0f026f6a10
Bug 798221 - Transfer funds between accounts with different currencies crashes Gnucash on macOS
...
In the scrub function find_account_matching_name_in_list there was a
test for account names being the same for currency but condition was
backwards so was matching on account names being different. There was
also a g_list_free resulting in a double free which was removed.
2021-07-08 09:33:10 +01:00
John Ralls
ebf84fbf8d
Bug 798229 - GncDate::c_formats is being created and destroyed twice...
...
resulting in a double free crash on every exit.
Exclude by name the obsolete pre-GnuCash 4 modules from being inspected
so that they don't try to construct and destroy their static variables
twice.
2021-07-06 12:03:41 -07:00
John Ralls
06fc58c39d
Merge Simon Arlott's 'load-pricedb-faster' into maint.
2021-07-05 14:48:48 -07:00
Simon Arlott
08b56e9669
[gnc-pricedb] Don't lookup old prices when doing bulk updates
2021-07-05 21:57:34 +01:00
Geert Janssens
60f50e34c7
Tax - fully express source file dependencies in build scripts
2021-06-30 15:19:34 +02:00
luz paz
95f8884892
Fix misc. typos in comments
2021-06-29 08:46:34 +02:00
Christopher Lam
e653c30193
[gnc-xml-backend] g_free char*
2021-06-22 18:57:55 +08:00
John Ralls
b1b368746f
Merge Hong Xu's 'explain-as-of-date' into maint.
2021-06-19 13:19:31 -07:00
John Ralls
b33d7eb98d
Doxygenize some function description comments in gnc-ui-util.
2021-06-18 11:54:14 -07:00
John Ralls
7f62c5395a
Bug 743999 - Deleting a digit from an existing number greater than...
...
four digits in length generates an error message.
Because the grouping is off. Checking grouping on input is pointless so
just ignore the grouping separator when parsing number input.
2021-06-18 11:40:06 -07:00
Hong Xu
0fd0aca531
Explain out what AsOfDate means in the doc
...
As discussed at
https://lists.gnucash.org/pipermail/gnucash-user/2021-June/096893.html
2021-06-16 12:07:23 -07:00
John Ralls
601eb51361
Improve transaction sorting on effective num field.
...
Inspired by PR #983 . Transaction sorting on num broke down if the
user had a non-numeric string or a number larger than an int in
the effective num field (might be split-action if the option is set).
The comparison first tries to use strtoull on the two strings and
compares the results. If they're both nonzero and different then the
numeric order is returned. If they're both nonzero but the same the
unconverted parts of each are passed to g_utf8_collate; if either is 0
then the whole strings are passed to g_utf8_collate. strtoull will
return 0 for a negative number.
2021-06-15 14:02:25 -07:00
John Ralls
985a6420fc
Bug 798196 - not building with Boost 1.76
2021-06-12 16:47:35 -07:00
John Ralls
6aa35ea7fb
Better fix for bug 798204, doesn't break trading account selection.
2021-06-12 16:42:10 -07:00
John Ralls
9eeff5dd7e
Bug 798204 - Creation of Imbalance Accounts
...
Search recursively when getting account by name.
2021-06-12 15:21:50 -07:00
John Ralls
68ec80e68d
Bug 798203 - g_assert fault while reversing transaction
...
* Re-commit the original transaction to ensure that there aren't
any stray trading splits.
* If the original and cloned transactions have a different number of
splits don't leak the cloned transaction.
* Check that the cloned transaction isn't NULL before trying to invert
it.
2021-06-12 13:37:25 -07:00
John Ralls
80d6749989
Bug 787813 - Price change from editing a transaction not reflected...
...
in pricedb.
Allow PRICE_SOURCE_SPLIT_REG to overwrite PRICE_SOURCE_XFER_DLG_VAL.
2021-06-10 11:29:34 -07:00
Christopher Lam
321b5efabc
Merge branch 'maint-leaks' into maint #1019
2021-06-09 06:47:23 +08:00
John Ralls
42213c597c
Bug 798199 - Pasting invalid value in date column crashes GnuCash
...
Catch boost::gregorian::bad_year in LDT_from_struct_tm and rethrow
std::invalid_argument for C wrappers to catch and handle.
2021-06-08 13:14:30 -07:00
John Ralls
66685f042e
Merge Bob Fewell's 'bug796761' into maint.
2021-06-08 11:58:27 -07:00
Christopher Lam
b095d1e7da
Revert "[qofquery] q->terms g_list members must be freed"
...
This reverts commit a3e3823ee7 .
Already freed earlier in the same function.
2021-06-08 07:36:47 +08:00
Christopher Lam
c8a7b9edb3
[Account] g_value_unset
2021-06-07 07:54:36 +08:00
Christopher Lam
bfdec74a48
[qof-backend] gchar * gnc_path_get_pkglibdir must be g_freed
2021-06-06 11:03:04 +08:00
Christopher Lam
f6a9be45ba
[Split] g_value_unset
2021-06-05 00:21:52 +08:00
Christopher Lam
36901c5751
[gncJob] g_value_unset
2021-06-05 00:21:52 +08:00
Christopher Lam
1824a30bd0
[gncinvoice] g_value_unset
2021-06-05 00:21:52 +08:00
Christopher Lam
badd976e11
[gnc-lot] g_value_unset
2021-06-05 00:21:52 +08:00
Christopher Lam
c9565abe8b
[gnc-commodity] g_value_unset
2021-06-05 00:21:52 +08:00
Christopher Lam
302020fcb7
[gnc-budget] g_value_unset
2021-06-05 00:21:50 +08:00
Christopher Lam
ceeb1dff7a
[scrub.c] g_value_unset
2021-06-05 00:21:21 +08:00
Christopher Lam
92cd437562
[Transaction.c] g_value_unset to release GValue string
2021-06-05 00:21:20 +08:00
Christopher Lam
3353d3950b
[gnc-budget] g_value_unset GValue
2021-06-05 00:20:23 +08:00
Christopher Lam
a3e3823ee7
[qofquery] q->terms g_list members must be freed
2021-06-03 17:16:09 +08:00
Christopher Lam
8a6413342d
[SchedXaction] free GList*
2021-06-02 22:04:54 +08:00
Christopher Lam
c5585ebe2c
[gncInvoice] free GList*
2021-06-02 22:04:52 +08:00
Christopher Lam
d611538ae7
[gncTaxtable] free GSList*
2021-06-02 22:04:33 +08:00
Christopher Lam
b3101c9385
[gnc-pricedb.c] plug GList leak
2021-06-02 20:09:45 +08:00
Christopher Lam
8a56a00313
Modify documentation for gncEntryComputeValue
...
Modify documentation for be19b489e
2021-06-01 08:14:25 +08:00
Robert Fewell
7ee9dac2e9
Add filter for currency symbol for GNCAmountEdit widget
...
When pasting an amount that includes the currency symbol the validation
will silently fail which may lead to unusual behaviour.
2021-05-31 11:11:01 +01:00