Remove the "minus 1" to amount-depth for some accounts with children
and display-amount is 'immediate-bal. This means amounts are now
strictly(*) indented according to account depth instead of a weird
formula if account-has-children and immediate-bal.
(*) when subtotal-mode isn't "canonically tabbed"
This reverts commit 35ed4cf2, restoring indenting for account
summary. The next commit will fix the indented amounts to land under
the 'Balance' header.
This fixes: Bug 797332 - Account Summary Report balance lacks
indentation
This required some tweaks in the core csv import code
- first don't unset other deposit/withdrawal columns when selecting a second one
- amounts have to be summed for all deposit/withdrawal colums
I have added a new member function 'add' in addition to 'set' and 'reset'
That function will only work for deposit or withdrawal columns
Before we used a colon separated prefix, but thas was error prone.
The downside: Our translators have to review serveral messages.
Tip: Use a tool like KDiff3 for merging.
Q_('ctxt|msg') expands to g_dpgettext(NULL, 'ctxt|msg',0) and should be
interpreted as a message with message context. According to
https://www.gnu.org/software/gettext/manual/gettext.html#Language-specific-options
this glib extension is supported using the 'g' suffix to the keyword spec.
This was missing in our xgettext invocation.
tbl-width is not necessarily an even number; tbl-width being odd would
result in a half-fraction when calculating number of
empty-cells. convert to the appropriate integer.
this is the proper fix for the bug fixed by d865b149.
assoc-ref (or better, assq-ref because we're comparing symbols) is
used to lookup from the 'car's of a list of pairs, and return the
found pair's 'cdr'. the previous use of 2-element lists demonstrate a
lack of understanding how to encode the list of pairs. rewrite using
proper pairs rather than 2-element lists, which means the assq-ref
does not need a subsequent 'car' to retrieve the desired symbol.
This simplifies function gnc_gtest_configure(), since GoogleTest and
GoogleMock are combined in one source directory.
Additionally variable GMOCK_ROOT is not necessary anymore and is
removed.
* this function has a typo in name
* all uses of accounts-get-all-subaccounts were followed by appending
the result to the original accounts list. we have already rewritten to
use the better function in previous commit. this is now obsolete.
* inline its last use, omit sorting. list is sorted anyway afterwards.
All uses of gnc:acccounts-get-all-subaccounts were immediately
followed by appending the result to the original accounts list. Use
gnc:accounts-and-all-descendants instead which is more efficient.
1. If GTEST_ROOT and/or GMOCK_ROOT are defined, sources are expected
somewhere inside these directories. Otherwise a CMake error is
generated. Different source directory layouts are considered.
2. If GTEST_ROOT and GMOCK_ROOT are both not defined, sources are
searched in /usr/src. Different source directory layouts are considered.
3. If sources are not found in one of the first two cases, preinstalled
libraries are searched.
Additionally using HINTS in function find_path() has been replaced by
PATHS and PATH_SUFFIXES. According to CMake documentation in case of
hard-coded guesses PATHS should be used. Remark: This reverts commit
5f53e29, but instead NO_CMAKE_SYSTEM_PATH is used now to prevent CMake
from searching in system paths.
Hint: There was a special handling implemented regarding search for
gmock-all.cc. This file was additionally searched in /usr/src/gmock
directly instead of /usr/src/gmock/src (see commit 1241b71). This
special handling has been kept in case of searching sources in
/usr/src/gmock, but not in case of searching sources in GMOCK_ROOT or
GTEST_ROOT.
if GTEST/GMOCK sources are already found, only check if gtest/gtest.h
and gmock/gmock.h exist at GTEST_SRC_DIR/include and
GMOCK_SRC_DIR/include and set GTEST_INCLUDE_DIR and GMOCK_INCLUDE_DIR
accordingly.
This simplifies usage of GoogleTest, since independent handling of
GTEST_LIB and GTEST_INCLUDE_DIR is not necessary anymore.
Additionally CMake creates a dependency now between target gtest and all
test applications using it. This improves build process when building
GoogleTest from source code. When any test application is built,
GoogleTest library is automatically rebuilt if necessary now for
instance.
