Otherwise, the scheduled transaction won't be created.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17916 57a11ea4-9604-0410-9ed3-97b8803252fd
gnc_import_TransInfo_delete() was defined but never called!
This led to a memory leak, and erroneous behaviour.
Bug 552275 - Cancelling OFX Import Still Adds Entries
Bug 434944 - Refused transactions from import appear in register
Patch by Alan Jenkins <alan-jenkins@tuffmail.co.uk>
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17891 57a11ea4-9604-0410-9ed3-97b8803252fd
Affects all users of the generic import: OFX, HBCI and AqBanking.
Suggested by <http://bugzilla.gnome.org/show_bug.cgi?id=139310>.
"
Assume you have a transaction that transfers money from account 1 to account 2.
Import an OFX statement from account 1 that matches the transaction. Then
import an OFX statement from account 2 that matches the same transaction.
Because each transaction can only store one online_id, when you import from
account 1 again it doesn't remember that it's already been imported.
If online_id was stored in a split slot instead of a transaction slot, it would
allow tracking the online_id of both accounts without being overwritten.
"
For backwards compatibility, we still check for online_id in transactions.
This is more of a convenience than a critical feature, however.
The compatibility code could be removed in future versions if desired.
Patch by Alan Jenkins <alan-jenkins@tuffmail.co.uk>
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17889 57a11ea4-9604-0410-9ed3-97b8803252fd
Fix typos and use of apostrophes.
Also make the status of the document clearer.
Patch by Alan Jenkins.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17888 57a11ea4-9604-0410-9ed3-97b8803252fd
Scheme is not common lisp, so rather use 'else', t might be unbound.
Found by Forest Bond.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17885 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by Alan Jenkins.
Signed-off-by: Christian Stimming <stimming@tuhh.de>
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17880 57a11ea4-9604-0410-9ed3-97b8803252fd
This fixes the default currency and description in the new account dialog.
Patch by Alan Jenkins.
Signed-off-by: Christian Stimming <stimming@tuhh.de>
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17879 57a11ea4-9604-0410-9ed3-97b8803252fd
Most of the source tree is UTF8, but there are some latin-1 hangovers.
Apply "iconv --from-code ISO_8859-1" to these files.
This affects bullet point characters in src/optional/xsl/README, and
Benoit Grégoire's name in source files (and hence the Doxygen output).
E.g. it should fix <http://svn.gnucash.org/docs/HEAD/reference.html>
which claims to be UTF8, but encodes Benoit's name in latin-1.
Patch by Alan Jenkins.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17877 57a11ea4-9604-0410-9ed3-97b8803252fd
Whenever an XML file is opened, Gnucash creates a new template root account and
makes the old one a child of it. My main accounts file had them nested over
540 deep before I got annoyed enough to fix this. The problem is that
sxtg_book_begin creates a root account when the book is opened. Then
add_template_transaction_local tries to replace this new root account with the
one read from the file. However the code that does this is rather badly broken
and the result is that the one read from the file becomes a child of the one
created in sxtg_book_begin.
This patch avoids creating any more nested root accounts, but it doesn't get
rid of the ones that are already there. This is slightly more tricky than just
deleting them since, although most of them have no children (other than the
next root account), some do. Accounts created for template transactions will
be children of whatever root account happens to be at the top of the tree then.
As the file is saved and reopened, this will get pushed down into the tree of
accounts. In my case about 5 of the 540 or so root accounts had other
children.
Patch by Mike Alexander.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17868 57a11ea4-9604-0410-9ed3-97b8803252fd
The template root account created as part of the scheduled transaction
infrastructure should have a name. Various parts of the Gnucash engine get
upset if an account doesn't have a name.
Perhaps this name should be localized, but the name of the main root account is
not localized.
Patch by Mike Alexander.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17867 57a11ea4-9604-0410-9ed3-97b8803252fd
This patch doesn't write the commodity, the commodity SCU, or the non-standard
SCU setting for an account that has no commodity.
Patch by Mike Alexander.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17866 57a11ea4-9604-0410-9ed3-97b8803252fd
Whenever I saved my Gnucash file I would get a number of errors like
CRIT <gnc.backend.xml> text_to_dom_tree: assertion `str' failed
I tracked this down to the fact that the weekend adjust field in recurrences
read from the file was not initialized properly if a recurrence didn't have a
weekend adjustment.
Patch by Mike Alexander.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17865 57a11ea4-9604-0410-9ed3-97b8803252fd
It allows transactions that go from one selected account
to another to be ignored.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17855 57a11ea4-9604-0410-9ed3-97b8803252fd
I finally got around to looking into this some more. I think the problem is a
result of an interaction between gnc_split_register_redraw and
gnc_split_register_find_split when called from gnc_split_register_move_cursor
in split-register-control.c. As the comment says, "redrawing the register can
muck everything up". In particular calling gnc_split_register_redraw may
change the "transaction split" for some or all of the transactions if the
register is a "ledger" style register such as the one for find results. This
causes the subsequent call to gnc_split_register_find_split to find the wrong
register row if the cursor class being found is CURSOR_CLASS_TRANS. Whether
this causes a crash seems to depend on circumstances I haven't quite figured
out, but I have one test file that crashes 100% of the time in r17804.
This patch changes the way gnc_split_register_find_split works when asked to
find the transaction split for a transaction. It assumes that any transaction
can only have one such split and returns as soon as it finds a row containing
it. If you think this is wrong, let me know and I'll try something else.
Patch by Mike Alexander.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17853 57a11ea4-9604-0410-9ed3-97b8803252fd
Fixes crashes and also improves error message when no budgets exists (for all
budget reports).
Patch by Forest Bond.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17851 57a11ea4-9604-0410-9ed3-97b8803252fd
If the price DB contains the reciprocal of the exchange rate which
gnc_pricedb_convert_balance_nearest_price,
gnc_pricedb_convert_balance_latest_price, and
gnc_pricedb_convert_balance_latest_before need to do their conversion they
don't find it and return zero.
Patch by Mike Alexander.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17850 57a11ea4-9604-0410-9ed3-97b8803252fd
In Hungary the smallest Forint (HUF) coin is 5 forints, but formally we had 1,2
forint coins, and dividing FILLER coins (like cents for US, EUR, ...). They are
simply not circulated in cash usage, but the banking system still using it.
Such as the smallest transferable amount is 0.01 FORINTs (1 FILLER), and with
business it is normal to use it (as result of foreign exchange, incoming
interest rate, or many other reason).
Patch by Frank H. Ellenberger.
BP
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17849 57a11ea4-9604-0410-9ed3-97b8803252fd
The contributer, Chad V, writes:
My reason being that if you like to keep track of different
"virtual" accounts within one bank account, it is nice to see the cleared
balance for the whole bank account.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17848 57a11ea4-9604-0410-9ed3-97b8803252fd
Not for back-port because it would break existing translations and the fix
isn't really important.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17831 57a11ea4-9604-0410-9ed3-97b8803252fd
* Moves budget-related reports to a "Budget" sub-menu.
* Implements a Budget Balance Sheet report. This is a projected future balance
sheet using budget data.
* Adds Budget Income Statement and Budget Profit & Loss reports. These are
projected future IS/PNL reports using budget data.
Patch by Forest Bond.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17829 57a11ea4-9604-0410-9ed3-97b8803252fd
