Creates a new safe_sync function in struct provider and a new
gnc_db_do_safe_sync_all function with the guts of gnc_dbi_do_safe_sync_all.
The last calls the provider’s safe_sync function, which for SQLite3 and
PGSql wraps the call to gnc_dbi_do_safe_sync_all in a SQL transaction.
Unfortunately MySQL commits the transaction on the first schema-altering
query (CREATE_TABLE in this case) without decrementing sql_savepoint, so
raising an error when we try to release the (non-existent) save point at
the end of writing the tables.
Add a gnc_dbi_check_and_rollback_failed_save() to restore the database
after a failed safe_save; this is performed at the next connection.
All c++ unit tests will be written with it, and testing
should be possible out of the box.
We could make it optional, but then lots of tests will
be skipped. This creates an illusion of all tests passing
while many are simply not run. This confusion should be
avoided.
This change depends on a second commit for the windows build
in the gnucash-on-windows repository. This commit will be
pushed at the same time.
This has the unwanted side-effect of misaligning the chart
legends (due to some internal bug in webkit). Resizing the window
properly redraws the chart afterwards, but leaving the page and
returning reloads the page again, hitting the bug again. This
prevents multiple report tabs open at once to show a correct chart.
Each resize of the window to correct one chart will trigger a
misaligned legend on all other charts the next time you look at them.
The disadvantage of removing this code is that reports loaded
automatically when gnucash opens are not sized properly. (All but
the one in the very last tab of the book being opened, that is).
However these pages can be corrected by manually reloading them
once. That's annoying but at least allows for correctly displayed reports.
A proper solution must be found for this of course.
This reverts commit 12994ca6e7.
Webkit takes care of this properly for newly opened reports. It
somehow fails for reports that are automatically loaded when
reopening gnucash. This needs additional investigation, but
reloading the report when exposing the page has undesired
side-effects which should be avoided.
This reverts commit 74091fbcfa.
Webkit takes care of this properly for newly opened reports. It
somehow fails for reports that are automatically loaded when
reopening gnucash. This needs additional investigation, but
reloading the report when exposing the page has undesired
side-effects which should be avoided.
In the travis environment (guile 1.8 in combination with other unidentified,
particular package versions) the scm based tests are looking for
backend modules (xml and dbi) in the installation prefix instead of
in the build directory. Explicitly setting the environment variables
GNC_BUILDDIR and GNC_UNINSTALLED fix this. I haven't figured out why this
is not needed on all platforms/tool version combinations. But the fix
works in all (autotools based) cases. CMake builds may need a similar
fix, but I don't know that environment sufficiently to implement it.
While a proper solution is only possible with a more recent
version of webkit, this commit will allow users to work around
the issue by manually setting a default zoom level for reports.
This setting can be found under
Edit->Preferences->Reports
The last change did not check for the left screen edge. This update
checks for the calendar pop up going over the left, right, and
bottom edges of the screen. The top should not be an issue.
Only auto-post if:
The posted_to account name is valid.
There's no currency conversion.
The invoice customer's currency matches the A/R account currency.
Tell the user what happened with a dialog.
