Christopher Lam
7257675218
REFACTOR:bisect subtotal-get-info into primary/secondary
2017-12-24 00:13:39 +08:00
Christopher Lam
e2912d1b9c
REFACTOR: start refactor subtotal
2017-12-24 00:13:39 +08:00
Christopher Lam
00b2e76d35
BUGFIX: Reverse sign on display only
2017-12-24 00:13:39 +08:00
Christopher Lam
0854caba95
BUGFIX: Fix incorrect N_ and _ handling
2017-12-24 00:13:39 +08:00
Christopher Lam
c26af85e82
ENH: Upgrade Sign Reversal to use global preference by default
2017-12-24 00:13:39 +08:00
Christopher Lam
e8dc5c545d
REFACTOR: move calculated-cells to allow access from add-subtotal-row
...
This will negate the need to zip calculated cells to call add-subtotal-row.
Note git-diff seems to think lots of functions were moved - it's calculated-cells
that's been moved by a few lines so that it is accessible to add-subtotal-row.
Also rename a few keywords to better describe their use.
2017-12-24 00:13:39 +08:00
Christopher Lam
6f87138bce
ENH: 'original currency amt' now shows dual columns
2017-12-24 00:13:39 +08:00
Christopher Lam
2e06c8fc33
REFACTOR+ENH:Add common-currency mnemonic to header if enabled
...
This requires refactoring calculated cells to centralize
the headers and enable their modification.
2017-12-24 00:13:39 +08:00
Christopher Lam
aaa23dc51e
REFACTOR: move column-uses? location
...
This commit moves column-uses? helper to allow access
to used-columns instead of needing to pass this parameter
around with every call.
2017-12-24 00:13:39 +08:00
Christopher Lam
43cbe65282
REFACTOR:Move Void-status filter to filter tab
...
Also upgrade lookup-value Void Transactions now in Filter tab
2017-12-24 00:13:39 +08:00
Christopher Lam
20feefe681
REFACTOR:Centralise sign-reverse-list
...
This allows us to centralise its account type list.
2017-12-24 00:13:39 +08:00
Christopher Lam
3b3c0322cf
ENH: add infobox to summarise options used
2017-12-24 00:13:39 +08:00
Christopher Lam
ea416e16d5
REFACTOR: Centralize options
2017-12-24 00:13:39 +08:00
Christopher Lam
d9d4ffaff2
ENH: disable filter accounts selector if filter-mode=none
2017-12-24 00:13:39 +08:00
Christopher Lam
8399ee65bd
ENH: dual columns subtotals now in correct column
...
This commit changes dual column subtotal strategy to limit
to debit/credit columns handling only. Values are summed
and the subtotal is displayed in the appropriate debit or
credit column.
2017-12-24 00:13:39 +08:00
Christopher Lam
521c16241d
REFACTOR: Use time64 instead of timepair
2017-12-24 00:13:39 +08:00
Christopher Lam
1be88ad175
COSMETIC: Move Display>Sign reversal option
2017-12-24 00:13:39 +08:00
Christopher Lam
fa0bcf104a
ENH: Enable sign reversal for amount 'single only
2017-12-24 00:13:39 +08:00
Christopher Lam
db019ec51e
ENH: "Shares" column gets number-cell styling
...
This commit enables styling for shares column which allows
right-alignment of numeric amount.
2017-12-24 00:13:39 +08:00
Christopher Lam
1a886fac7d
ENH: "Price" column gets number-cell styling.
2017-12-24 00:13:39 +08:00
Christopher Lam
ef65f544aa
ENH: show original currency, and enable multicolumns.
...
This commit optionally displays the original currency
if 'common currency' is ticked. This will require
refactoring to enable multicolumn data display and
multiple collectors for subtotals.
2017-12-24 00:13:39 +08:00
Christopher Lam
b549dd68fb
ENH: add custom sorter which can handle periodic dates
2017-12-24 00:13:39 +08:00
Christopher Lam
4bfd01e706
REFACTOR: simplify do-rows-with-subtotals to use fewer args
2017-12-24 00:13:39 +08:00
Christopher Lam
c7f9fb1a3a
REFACTOR: use scheme idioms
2017-12-24 00:13:39 +08:00
Christopher Lam
68aa61a37c
REFACTOR: Simplify Trans Number handling
...
Previously there was a check for the presence of "Trans Number".
But if 'use-split-action' the options will always contain
the toggle 'Trans Number'. Therefore remove unnecessary check.
2017-12-24 00:13:39 +08:00
Christopher Lam
8044f2b04e
COSMETIC:Rename subtitles -> subheadings in sorting/account display
2017-12-24 00:13:39 +08:00
Christopher Lam
b6c6906bb1
REFACTOR: initialize accounts/filter by to null list
2017-12-24 00:13:39 +08:00
Christopher Lam
8e4d72b544
REFACTOR: rewrite renderers to lookup 'renderer-key from sortlists
2017-12-24 00:13:39 +08:00
Christopher Lam
afc6ca078c
ENH: Show account description in subheadings
2017-12-24 00:13:39 +08:00
Christopher Lam
c4089ebcc3
REFACTOR: move add-split-row into make-split-table
2017-12-24 00:13:39 +08:00
Christopher Lam
dd22216845
REFACTOR: move *-choice-list into options-generator
2017-12-24 00:13:39 +08:00
Christopher Lam
d88d503b38
REFACTOR: simplify functions, reduce arguments
2017-12-24 00:13:39 +08:00
Christopher Lam
a5306d0454
REFACTOR: improve heading-list to handle dual headings
2017-12-24 00:13:39 +08:00
Christopher Lam
e1ba5f3248
REFACTOR: centralize BOOK-SPLIT-ACTION
...
Centralize BOOK-SPLIT-ACTION
2017-12-24 00:13:39 +08:00
Christopher Lam
070c99c1c2
REFACTOR: centralize DATE-SORTING-TYPES and SUBTOTAL-ENABLED
...
Also minor whitespace changes
2017-12-24 00:13:39 +08:00
Christopher Lam
d0c435e73d
REFACTOR: centralize key-choice-list
2017-12-24 00:13:39 +08:00
Christopher Lam
a2008c492d
REFACTOR: centralize date-subtotal-list
2017-12-24 00:13:39 +08:00
Christopher Lam
b9390cead1
REFACTOR: centralize sortkey-list
2017-12-24 00:13:39 +08:00
Christopher Lam
ff0d7cc2c4
REFACTOR: centralize numerous used-* into column-uses? helper function
2017-12-24 00:13:39 +08:00
Christopher Lam
02905fe38f
REFACTOR: combine 2 key-choice-list into 1
...
Previously key-choice-list was selected from 2 lists depending
on use-split-action setting. This commit combines to 1 list
with suitable (if) clause in the middle.
2017-12-24 00:13:39 +08:00
Christopher Lam
ee01038ee5
REFACTOR: move some funcs to refactor later
2017-12-24 00:13:39 +08:00
Christopher Lam
7127df58da
REFACTOR: always run qof-query-destroyer
...
Formerly the qof-query-destroyer is only called upon completion
of a successful report. This commit moves this destroyer to be
nearer the query call, thereby the destroyer is always called.
2017-12-24 00:13:39 +08:00
Christopher Lam
fe757dbe6a
ENH: Optimise Transaction Matcher filter
...
This commit will trigger the transaction matcher only if the search string is not empty. Will speed up filtering.
2017-12-24 00:13:39 +08:00
Christopher Lam
e5a7660ac0
ENH: add reconciled status filtering
2017-12-24 00:13:39 +08:00
Christopher Lam
8990553e2e
ENH: Move Account matcher to Filter tab
...
This commit moves the Account matcher into the Filtering tab in preparation for further options
2017-12-24 00:13:39 +08:00
Christopher Lam
4187cc1cd2
REFACTOR: Delete unused functions
...
These functions were probably deprecated from prior work
2017-12-24 00:13:39 +08:00
Christopher Lam
3f03cce164
REFACTOR: rename funcs, centralize strings
2017-12-24 00:13:39 +08:00
Christopher Lam
082811b909
***reindent and remove trailing whitespace***
2017-12-24 00:13:39 +08:00
Christopher Lam
809d277097
ENH: Move Transaction Matcher to new Filter tab
2017-12-24 00:13:39 +08:00
Christopher Lam
7e8ac532bf
BUGFIX: change date-sorting-types
...
This commit changes date sorting types.
'date is posted-date and belongs to this list.
'reconciled-date is also date and may benefit from periodic subtotals.
'register-order is register default and may not be date.
2017-12-24 00:13:39 +08:00
