Placeholder accounts do not allow transactions so when the account
picker dialog is presented, add an error dialog for placeholder
selection and a column to display that the account is a placeholder.
This bug has two elements, the first is that when you have a large
number of tradable commodities you get an assistant page for each one
and if too many you loose site of the assistant buttons. To fix this a
notebook was added to the tradable commodities assistant page with the
individual commodities being added to notebook pages.
The second part was that when editing these an intrusive dialogue was
being raised that displayed the same information as the tooltip which
blocked input. These were removed and the assistant next button enabled
when all entries are valid.
retained-earnings-fn will return a list of monetary (for different
currencies) or a monetary (all currencies converted). either must be
negated. handle separate paths separately.
The text on the first page was squashed as the width could not be
negotiated properly as all the text was set to wrap automaticity and on
subsequent pages there was no wide widgets. Moved the first text row to
a separate widget and not wrap-able so a decent width can be negotiated.
The eac79bd506 commit was slightly overzealous - if pair was #f,
originally this make-exchange-function would create a function that
returns (gnc:make-gnc-monetary domestic 0); I thought it was
acceptable to return #f instead but this would lead to report
crash. Revert previous behaviour.
Remove assigning exchangelist to exchange-alist.
Removes need to test foreign-amount against 0 - multiplication will
result in 0 anyway. The only functional change is the condition
whereby foreign's commodity is not present in exchangelist; previously
it would return (gnc:make-gnc-monetary domestic 0); now it returns #f.
This function *is* allowed to return #f for invalid or missing prices;
see the (and foreign ...) conditional.
The Preferences 'Register/Tab order includes Transfer on Memorised
Transaction' was not displaying its tooltip even though it was in the
glade file. Recreated the Register notebook page and the business page
as it also had a missing tooltip.
If the parent row for prices in a price tree view is used for a new
price the security value can be wrong so get the commodity of this row
and use it for a temporary price which is cloned for editing.
