Commit Graph

24882 Commits

Author SHA1 Message Date
John Ralls
ff26b71a91 Bug 798256 - Crash in recnFinishCB
Make the action_group not sensitive in the recn_destroy_cb so that
the action callbacks won't be called after the recnData is freed.
2021-09-09 18:03:18 -07:00
John Ralls
8ab8642e76 Fix leak of trading_splits list in xaccTransClearTradingSplits 2021-09-09 16:32:43 -07:00
John Ralls
1387d5f960 Fix unchecked ptr dereference.
First crash in Bug 798225.
2021-09-09 16:32:43 -07:00
John Ralls
d4bd600596 Fix free-of-unallocated-address crash due to uninitialized ptr. 2021-09-09 16:32:43 -07:00
jean
248a8504b7 Add code to handle ofx files that include transfers between accounts 2021-09-09 11:00:55 -07:00
Christopher Lam
140922a37e QofQuery args must be destroyed after qof_query_merge
qof_query_merge returns a new QofQuery; the two merged QofQueries are
not explicitly destroyed.
2021-09-09 19:19:44 +08:00
cjh
d398a359ca
Translation update by cjh <cjh@cjh0613.com> using Weblate
po/zh_CN.po: 99.9% (5361 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Co-authored-by: cjh <cjh@cjh0613.com>
2021-09-07 21:21:57 +02:00
John Ralls
e657366468 Merge Yi TianXing's 'remove_FindCustomerDialog_Parameter_ShippingContact' into maint. 2021-09-07 12:20:47 -07:00
John Ralls
ab24c34660 Merge Simon Arlott's 'free-template-root' into maint. 2021-09-07 12:14:41 -07:00
Simon Arlott
4a8acf3fb2 Free template root accounts on book end
The template root should be unset so that it's destroyed when the book is
ending. This is required to free all the template accounts and referenced
strings.

The scheduled transactions themselves need to be freed first so reverse
the order that SXRegister and gnc_sxtt_register are called in
cashobjects_register: The list resulting from that function is traversed
from the bottom up.
2021-09-07 12:11:05 -07:00
Geert Janssens
ae559089d3 Prep early splash screen messages for translation 2021-09-07 12:02:46 +02:00
Robert Fewell
4488568b45 Change text for SX preference option
Change the text of 'Review created transactions' to better align with
existing SX text so use "since last run".
2021-09-07 10:34:10 +01:00
goodvibes2
fa31855640 Rename 2 non public functions to remove leading gnc_
gnc_start_recn_update_cb is now amount_edit_focus_out_cb and
gnc_start_recn_date_changed is now recn_date_changed_cb.
Also add Doxygen comments for amount_edit_focus_out_cb and convert
recn_date_changed_cb comments to Doxygen format.
2021-09-07 10:15:36 +10:00
John Ralls
901fea158f Merge Simon Arlott's 'xml-locking-fixes' into maint. 2021-09-06 15:22:49 -07:00
John Ralls
38cd06e54a Remove the lock-file-link-count test from the XML backend.
This was an effort of somewhat dubious value to detect if a process
on another ocmputer had a hsrd-link to a lockfile on an NFS share.
NFS is rarely used now and SMB doesn't support hard links so this check
adds complexity with no real value.
2021-09-06 15:18:34 -07:00
John Ralls
079a900300 Bug 798298 - Re-imported transactions no longer ignored
Merges Jean Laroche's '798298_reimport_ofx' into maint.
2021-09-06 13:51:26 -07:00
Mike Alexander
068a5d2fa8 Fix xaccSplitGetOtherSplit which was broken by 028bf9826, don't
count splits that aren't really in the transaction.

The rewrite left out one test.  This was most obvious in the dummy
transaction used to enter a new transaction into an account.
xaccSplitGetOtherSplit never returned an "other split" for this
transaction.  It turns out the old code was broken too, but
it worked for this case by coincidence.
2021-09-06 02:45:37 -04:00
jean
4e9fe0a4d1 Add missing function to mock account 2021-09-05 17:52:34 -07:00
Christian Wehling
4afe5d83cf
Translation update by Christian Wehling <christian.wehling@web.de> using Weblate
po/de.po: 99.8% (5358 of 5364 strings; 6 fuzzy)
250 failing checks (4.6%)
Translation: GnuCash/Program (German)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/de/

Co-authored-by: Christian Wehling <christian.wehling@web.de>
2021-09-05 23:35:18 +02:00
jean
d3a056d1ca During transaction import, ignore splits whose account is not the destination account 2021-09-05 10:35:32 -07:00
jean
429a080699 Revert be6fb1abe2 2021-09-04 11:00:42 -07:00
Christian Wehling
82f70ffe00
Translation update by Christian Wehling <christian.wehling@web.de> using Weblate
po/de.po: 99.8% (5357 of 5364 strings; 7 fuzzy)
250 failing checks (4.6%)
Translation: GnuCash/Program (German)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/de/

Co-authored-by: Christian Wehling <christian.wehling@web.de>
2021-09-02 22:34:01 +02:00
TianXing_Yi
849fdd59bc
Translation update by TianXing_Yi <ytx.cash@gmail.com> using Weblate
po/zh_CN.po: 99.7% (5353 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Co-authored-by: TianXing_Yi <ytx.cash@gmail.com>
2021-09-02 22:34:01 +02:00
Geert Janssens
047673a493 Small refactoring of scm config loading.
- Remove and cleanup duplicate code
- C++-ify
- Run code in gnucash-cli commands related to reports.
  Users may want to load modified report code via
  config-user.scm which they want to access while
  executing cli commands
2021-09-02 16:35:20 +02:00
goodvibes2
d667cf14ad Bug 798235 Reconciliation Ending Balance not recalculated the 2nd and
subsequent times Statement Date is updated.
This was because at end of gnc_start_recn_date_changed(),
gnc_start_recn_update_cb() was called when it should not have been.

This caused the user_set_value flag to be set True (indicating statement
end amount was manually entered - which it wasn't) after the date is
changed. This causes the ending balance to NOT be recalculated when the
end date is subsequently changed.
2021-09-02 11:39:15 +10:00
TianXing_Yi
881d3dcd23
Translation update by TianXing_Yi <ytx.cash@gmail.com> using Weblate
po/zh_CN.po: 99.7% (5353 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Translation update  by TianXing_Yi <ytx.cash@gmail.com> using Weblate

po/zh_CN.po: 99.7% (5353 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Co-authored-by: TianXing_Yi <ytx.cash@gmail.com>
2021-08-31 21:56:45 +02:00
John Ralls
9b30a2327b Merge Chris Good's 'MaintGenTrnImpMatFixCrash' into maint. 2021-08-31 12:54:53 -07:00
Christopher Lam
ac5650a9a2 Merge branch 'maint-g-value-leaks' into maint #1124 2021-08-31 23:30:24 +08:00
Christopher Lam
1eb6709331 [test-lots.cpp] add kvp getter/setter changes 2021-08-31 23:16:43 +08:00
Christopher Lam
323182c9f7 [utest-Account.cpp] add kvp getter/setter changes 2021-08-31 23:16:43 +08:00
Christopher Lam
8a37c4c019 [utest-Invoice.c] add kvp getter/setter tests 2021-08-31 23:16:43 +08:00
Christopher Lam
9ec670f828 [test-commodities.cpp] add kvp setter/getter test 2021-08-31 23:16:42 +08:00
Christopher Lam
d4c8b36f9f [utest-Transaction.cpp] add kvp setter/getter tests
wasn't tested before
2021-08-31 23:16:42 +08:00
Christopher Lam
c3b50f0b58 [gnc-lot.c] fix - cache value properly 2021-08-31 23:16:42 +08:00
Christopher Lam
595e126a34 [account.cpp] modify set_kvp_string_tag to accept strstrip or nullptr
- will remove a second call to g_strstrip (g_strdup (str))
2021-08-31 23:16:42 +08:00
Christopher Lam
c5a6383b43 [account.cpp] fix - incomplete #1117
- init struct members properly to: is_unset and TriState::Unset
- test acct kvp "equity-type" for "opening-balance" instead of "true"
- cached account->color/sort_order/notes/filter gets strstripped
  similarly to previous behavior
2021-08-31 23:16:42 +08:00
goodvibes2
86c438dcf4 Fix unneeded double call to get_action_for_path()
in gnc_gen_trans_onButtonPressed_cb().
2021-08-31 10:06:42 +10:00
goodvibes2
52715face7 Fix 2 crashes in Generic Transaction Matcher
Both dumped core in gnc_import_TransInfo_get_action() because info
is null
1. After double clicking on a potential match line, then right clicking
on the the parent transaction of the potential match
2. After rubber banding a group of transactions which also includes an
expanded potential match. Sometimes also need to right click the
selection to trigger the core dump.
2021-08-31 09:53:38 +10:00
Giuseppe Foti
bda03a1c56
Translation update by Giuseppe Foti <foti.giuseppe@gmail.com> using Weblate
po/it.po: 100.0% (5364 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Italian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/it/

Co-authored-by: Giuseppe Foti <foti.giuseppe@gmail.com>
2021-08-30 18:38:34 +02:00
Avi Markovitz
f97821e072
Translation update by Avi Markovitz <avi.markovitz@gmail.com> using Weblate
po/he.po: 100.0% (5364 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/

Co-authored-by: Avi Markovitz <avi.markovitz@gmail.com>
2021-08-30 18:38:34 +02:00
Yaron Shahrabani
22e64905a1
Translation update by Yaron Shahrabani <sh.yaron@gmail.com> using Weblate
po/he.po: 100.0% (5364 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/

Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
2021-08-30 18:38:34 +02:00
Avi Markovitz
1a049f4ef5
Translation update by Avi Markovitz <avi.markovitz@gmail.com> using Weblate
po/he.po: 100.0% (5364 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/

Translation update  by Avi Markovitz <avi.markovitz@gmail.com> using Weblate

po/he.po: 100.0% (5364 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Hebrew)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/he/

Co-authored-by: Avi Markovitz <avi.markovitz@gmail.com>
2021-08-30 18:38:34 +02:00
TianXing_Yi
1a12489ef9
Translation update by TianXing_Yi <ytx.cash@gmail.com> using Weblate
po/zh_CN.po: 99.7% (5353 of 5364 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Chinese (Simplified))
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/zh_Hans/

Co-authored-by: TianXing_Yi <ytx.cash@gmail.com>
2021-08-30 18:38:34 +02:00
Christopher Lam
5d15f95f9e Merge branch 'maint-leaks' into maint #1116 2021-08-31 00:38:01 +08:00
Christopher Lam
998e14c107 gtk_list_store_new returning a GObject must be g_object_unref
GObjects were not consistently unrefed.
2021-08-31 00:37:27 +08:00
Mike Alexander
0c21ae3522 Handle very large denominators in precies from Finance::Quote
The OpenExchange exchange rate source in Finance::Quote produces
some ridiculously precise prices like #e6.95253159056541e-5 which
produce a denominator greater than INT64_MAX.  Use the rationalize
function to bring them back to reality.
2021-08-30 03:09:23 -04:00
Christopher Lam
e13644dffc free GtkTreePath after calling gtk_tree_view_get_path_at_pos 2021-08-30 08:44:06 +08:00
Christopher Lam
8a48ed9777 Merge branch 'maint-cache-gvalue-string' into maint #1117
Will store a copy of kvp data onto struct so that GValue can be
freed (unset) cleanly.
2021-08-30 08:43:13 +08:00
Christopher Lam
001b34616f [Transaction.c] GValue string must be unset 2021-08-29 15:38:16 +08:00
Christopher Lam
a47bee97d6 [Split.c] GValue string must be unset 2021-08-29 15:38:16 +08:00