Commit Graph

17291 Commits

Author SHA1 Message Date
John Ralls
dbf4eada94 Ensure that PRIi64 is defined in mingw. 2016-04-05 15:49:02 -07:00
Christian Stimming
dc4fce0aae Bug 764268 - MT940 import select account based on transaction info
When importing MT940 files, AqBanking will (sometimes?) put
all transactions under a single AccountInfo, even when there
are multiple accounts in the file. Luckily the correct account
information can be recovered from the transaction information.
This patch will try to use the account information in the
transaction before trying to use the saved account state.

Patch by Jethro Beekman.
2016-04-05 21:53:49 +02:00
Geert Janssens
ee40d5dce7 Fix counter format resetting in a private kvp compatible way 2016-03-30 15:37:49 +02:00
Geert Janssens
826ebf2d2b Fix critical warning introduced in f5a7aeca79
Critical warning happens only on master branch
2016-03-30 15:37:12 +02:00
John Ralls
ec768b160c Modify the changes from 139e3ea5 to accomodate private-KVP. 2016-03-28 00:19:04 -07:00
John Ralls
455508f92a Delete dialog-print-check2.c which somehow managed to survive the last merge. 2016-03-28 00:14:55 -07:00
John Ralls
d7112e9ffb Clean up more !g_strcmp0(foo, bar) == 0, which doesn't work. 2016-03-27 17:41:09 -07:00
John Ralls
fbec25529a Restore some code removed in 8877f86 which left a variable uninitialized. 2016-03-27 17:40:30 -07:00
John Ralls
5485c9de37 Merge branch 'maint' after 2.6.12 release. 2016-03-27 17:06:43 -07:00
John Ralls
df8fa03887 Mac Localization: Prefer the country to the language for fall-back locales.
On the theory that in countries where multiple languages are in use similar
date and number formats will apply regardless of language, and especially
that the default currency will be the same regardless of language.

Also ensure that the specified language is in the list passed to gettext;
the net effect of which is that the user will effectively get the requested
localization behavior.
2016-03-26 11:30:36 -07:00
John Ralls
a41a7e2b50 Extract some functions to make the Mac locale setup a bit more maintainable. 2016-03-26 11:30:36 -07:00
John Ralls
ed11f6d1d5 Release 2.6.12 2016-03-25 19:43:22 -07:00
John Ralls
6cf1700650 Update translations from the Translation Project. 2016-03-25 16:39:26 -07:00
Geert Janssens
f5a7aeca79 Bug 719904 - Decide payment type only based on the account type involved
This commit improves payment type deduction by first checking
whether an AR or AP account is found in the transaction.
If not, fall back to previous heuristic of positive action
means customer payment, negative action means vendor
action. The logic can still go wrong (no means to declare
an employee payment, and credit notes are interpreted as
opposite sign payments). Needs a follow up to fix that.
2016-03-25 18:09:27 +01:00
Geert Janssens
6fd35694e2 Factor out a convenience function to retrieve a (business) owner starting from a transaction 2016-03-25 17:39:20 +01:00
Geert Janssens
656a3a9b57 Provide option to print checks directly from the payment window 2016-03-25 17:12:46 +01:00
Geert Janssens
d5d58dacba Check printing: extract address from invoice/bill for payment transactions
If the transaction is marked as a (business feature) payment,
extract the address of the bill/invoice associated with the
payment, or the owner if there's no bill/invoice yet.
2016-03-25 14:43:15 +01:00
Geert Janssens
531335a8f9 Move some utility functions from gui code to engine
And reduce some of the clutter in these functions and their callers.
2016-03-25 14:40:07 +01:00
Geert Janssens
163c4dd44a Update POTFILES.in after previous commit 2016-03-25 10:39:13 +01:00
Geert Janssens
39bfeba930 Merge reg and reg2 variant of print check dialog back into one file
There was nothing in the duplicate file that was different
from the original one except for the plugin_page parameter
initially passed in. Turns out we don't need anything
from the plugin_page except for the very generic GtkWindow
which is actually a member of the generic GncPluginPage
base object. So pass that window instead and avoid the
need for differentiation.
2016-03-24 22:49:27 +01:00
Geert Janssens
cde9d78465 Bug 693342 - Print (bottom) prints to middle for 3-check pages 2016-03-24 19:22:10 +01:00
Geert Janssens
f168cb2e1f Revert "Bug 118391 - Long currency names untranslated"
This reverts commit 9f984c05eb.

The change causes the windows build to crash. Needs more
investigation.
2016-03-23 21:43:07 +01:00
Geert Janssens
f7b0cb65bc Disable debug message that got enabled by accident last year 2016-03-23 21:28:45 +01:00
Geert Janssens
139e3ea569 Bug 687504 - Not possible to reset an invoice/bill counter format 2016-03-23 18:29:08 +01:00
Geert Janssens
0e91583754 Bug 642292 - General Ledger report - 'Primary Sort Key' value is not persistent 2016-03-23 14:48:21 +01:00
John Ralls
e003cb07db New Xcode, new errors, sigh. 2016-03-22 17:24:41 -07:00
Geert Janssens
aec61497f2 Bug 482186 - Customer and vendor report for partners who get invoiced/paid in foreign currency show total labeled with the symbol of the default currency. 2016-03-22 18:33:49 +01:00
Geert Janssens
0114a7317b Bug 728074 - Posting bill converts currency to itself using 0 rate 2016-03-21 17:11:05 +01:00
Geert Janssens
9f984c05eb Bug 118391 - Long currency names untranslated
Fix for Win32
2016-03-21 11:30:44 +01:00
Geert Janssens
6242524789 Fix typo 2016-03-21 09:49:12 +01:00
John Ralls
2059f06f27 Open correct xea directory if user has worked around bug 725296
Bug 725296 reports that setting LANG=sv_SE fails to set the language.
This turns out to be an error in gettext, but it can be worked around
by setting LANG=Swedish_Sweden. That broke looking up the localized
account directory, so this special-cases "Swedish_Sweden" and
"Swedish_Finland" when looking up the account directory.
2016-03-20 15:52:07 -07:00
John Ralls
9854876c70 OSX: Get the locale for account trees from the OS instead of setlocale().
It's possible for OSX to create locales that while legal aren't
supported by setlocale, and we have account trees for some of these.
Retrieving the locale from NSLocale ignores the fixup done in
gnucash-bin to ensure that a reasonable and supported locale is used.
2016-03-20 15:15:37 -07:00
Geert Janssens
ea7eaffd7e Bug 760107 - Change default date completion to sliding window
Release notes snippet for this change:
The default date completion when entering partial dates has been
changed from "always complete in current calendar year" to
"complete to a sliding window starting 11 months before current month".
For example if you enter "1/23" (January 23rd) while today is
December 10th 2015, the date will be expanded to
January 23rd 2016 rather than 2015.
If you prefer to keep the old behaviour, you can restore to it
via Edit->Preferences->Date/Time->Date Completion.
In addition if you were already using the sliding window
before, but didn't change the previous 6 months before
default, you will now also get the new default 11 months before.
Again if you prefer the old behaviour it can be restored via
the same Preference.
2016-03-19 18:26:49 +01:00
Robert Fewell
d54ccee532 Add Bayesian Conversion to Guid unit test
Added a test case for Bayesian mapping conversion from using the account
full name to using the account guid when storing the mapping entry
2016-03-19 15:52:09 +01:00
Robert Fewell
5f7fcf6ad7 Update Unit tests for import_map
Change import_map tests to reflect change to use the account guid.
2016-03-19 15:52:07 +01:00
Geert Janssens
323f8165df Merge branch 'maint' 2016-03-19 15:34:09 +01:00
Geert Janssens
a0fa6d2fe7 Merge branch 'maint'
Resolved Conflicts:
	src/engine/test/utest-Transaction.cpp
	src/gnome-utils/ui/osx_accel_map
	src/libqof/qof/qofbook.cpp
2016-03-19 15:33:59 +01:00
Geert Janssens
dca13d6248 Fix doxigen comment after changed const behaviour 2016-03-19 15:31:46 +01:00
Geert Janssens
6c2c2d73a3 Bug 620281 - Adding reversing transaction to bill transactions creates undeleteable transactions 2016-03-19 14:32:14 +01:00
Geert Janssens
d1e148ef87 Refuse to void read-only transactions.
Add test case to verify
2016-03-19 14:13:46 +01:00
Geert Janssens
0f66e20005 Bug 754209 - Bills can be posted multiple times from "find bill" search results - follow up
This commit adds code to check & repair that removes the read only status of the bogus transactions so the user can go in the AP/AR account and delete these bad transactions.

Translators: this commit introduces a new translatable string.
2016-03-19 14:13:44 +01:00
John Ralls
d45886f73b Bug 733164 - Command-H Invokes Help->Help Contents
Override the Gtk-supplied accelerator for the help menu.
2016-03-17 16:51:46 -07:00
John Ralls
3109b6f6c3 Set the transaction currency during auto-completion.
When auto-completing a transaction that was originally created in another
account with a different currency the balancing code will try to apply
conversions in the wrong direction if one edits the transaction. Explicitly
setting the transaction currency to the current register's currency
prevents the conversions being applied and allows the transaction to
balance correctly.
2016-03-17 15:42:12 -07:00
John Ralls
d0e103be08 Correctly re-value splits when the transaction currency is changed.
When a transaction with existing splits had its currency changed, the
function would change the values to use the new currency's denominator
without changing the actual value. The balancing code would then apply
the price of the the new "other" split to the amount, changing it as
well. Changing the transaction currency back would convert the value in
the other split correctly so that it would equal the amount that the
balancing code wouldn't change anything. I actually detected this bug
when I wrote the test but didn't recognize it as a bug.

The new code first calculates a new price and then applies it to each
split so that the transaction balances correctly in the new transaction
currency. This also round-trips correctly
2016-03-17 15:42:12 -07:00
Geert Janssens
c2ce204434 Use PRIi64 instead of PRIx64
We obviously want our business counters to use integral numbers instead of hexadecimal...
2016-03-17 23:06:52 +01:00
Geert Janssens
a27abf766a Bug 728722 - Setting number format details appear wrong in Help, section 10.3.4. Counters Book Options Tab
This is a follow-up commit to fix the core of the issue.
With this commit gnucash is more liberal at accepting
counter formats. It will accept either li, lli, I64i and
whatever is defined for G_GINT_64 or PRIx64 on the user's
platform. Internally the code will always convert the
specifier set by the user with PRIx64, which should always
be the correct one on any platform.

Additionally a few extra tests were added to stress the
counter format code a bit more.
2016-03-17 22:37:42 +01:00
Mike Evans
8117a7c17f Bug 754209 - Bills can be posted from "find bill" search results
even if bill is already posted and results in extra $ posted to A/P

This adds a test in gncInvoice to return NULL it already posted.

Adds checks in dialog-invoice to test for already posted invoices. Messages
user and refuses to post entire selection if more than one selected.

Translators: This adds a message string.
2016-03-16 14:36:11 +00:00
Geert Janssens
1121cd0795 Bug 720934 - Barcharts with many data points have overlapping x-axis labels
Depending on the available chart width x-axis labels will be pruned
from the full list to ensure the labels that are printed will
always be readable.
2016-03-15 08:19:35 +01:00
Carsten Rinke
d1ab9e783e Bug728692 - Time bound on the Budget Barchart report 2016-03-13 14:59:44 +01:00
Chris Good
ab35b571c3 Add Tip Of The Day re using multiple windows to do comparisons - Bug 762800
Note: this introduces an untranslated string to the stable series
2016-03-13 14:06:20 +01:00