Christopher Lam
d326cca065
Bug 798998 - Job Report Not Working
...
GncOptions add support fo GncOptionUIType::JOB
2023-07-05 17:13:54 +08:00
John Ralls
b041a76690
[c++options]Dirty and changed are different.
...
Report options need to be saved when they're different from the
defaults, book options need to be saved when their value changes
regardless of whether it's the default value. That's dirty. Implement
it.
2023-06-20 14:50:42 -07:00
John Ralls
00c560d8f5
Move operator==(const GncGUID&, const GncGUID&) to guid.[ch]pp.
2023-03-18 13:53:49 -07:00
Richard Cohen
24f52d9b17
Remove incorrect operator!= for GncItem
...
It's better to use the default std::pair implementation
- spotted by clang-tidy bugprone-suspicious-string-compare
- will always return false, because type is the same
Also,
- remove redundant "using GncItem ..."
2023-03-17 16:50:17 +00:00
John Ralls
a44b3664e2
[c++options] Implement GncOptionGncOwnerValue class.
...
GncOwners aren't QofInstances and have limited lifetimes so an option
must hold its own, wrapped in std::unique_ptr for memory management.
2023-03-14 16:11:39 -07:00
John Ralls
1eecb9f5c0
[c++ options] Fix locale dependency in test-gnc-option-scheme-output.
...
Created by using std::to_string() in GncOptionRangeValue::serialize.
It wraps sprintf that reads the locale. Use ostringstream instead.
2023-03-02 12:22:55 -08:00
Richard Cohen
3d995de2ab
Refactor: use default GncOptionValue copy constructor
2023-02-27 11:46:39 +00:00
Richard Cohen
78ec20515b
Remove some unused variables - and the initialization
...
- checked that any side effects were irrelevant
2023-02-06 14:20:28 +00:00
Richard Cohen
1cec0cb3f3
Use internal extern "C" { ... } for C++
...
- removes warnings compiling swig engine
...
[ 10%] Generating swig-engine.cpp
.../libgnucash/engine/engine-helpers.h:31: Warning 313: Unrecognized extern type "C++".
.../libgnucash/engine/gnc-date.h:83: Warning 313: Unrecognized extern type "C++".
.../libgnucash/engine/qofquery.h:90: Warning 302: Identifier 'QofQuery' redefined (ignored),
.../libgnucash/engine/gnc-option.hpp:55: Warning 302: previous definition of 'QofQuery'.
.../libgnucash/engine/gnc-commodity.h:56: Warning 313: Unrecognized extern type "C++".
.../libgnucash/engine/gncBusiness.h:40: Warning 313: Unrecognized extern type "C++".
.../libgnucash/engine/gncEntry.h:37: Warning 313: Unrecognized extern type "C++".
2023-01-23 18:40:01 +00:00
John Ralls
4ae17d12c7
[options] Move options from app-utils to engine.
...
Options is required for book options that are stored as part of the data
file and so belongs in engine.
2022-08-25 22:09:56 -07:00