gnucash/libgnucash/app-utils/gnc-gsettings.cpp
John Ralls a389e0a32e Bug 799092 - GnuCash 5.4 leaves background process running on exit
Clear the schema_hash at app shutdown via gnc_prefs_remove_registered
and make that function available to the Python bindings so that
python programs can do so too.
2023-10-02 12:31:59 -07:00

783 lines
25 KiB
C++

/********************************************************************\
* gnc-gsettings.c -- utility functions for storing/retrieving *
* data in the GSettings database for GnuCash *
* Copyright (C) 2013 Geert Janssens <geert@kobaltwit.be> *
* *
* This program is free software; you can redistribute it and/or *
* modify it under the terms of the GNU General Public License as *
* published by the Free Software Foundation; either version 2 of *
* the License, or (at your option) any later version. *
* *
* This program is distributed in the hope that it will be useful, *
* but WITHOUT ANY WARRANTY; without even the implied warranty of *
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License*
* along with this program; if not, contact: *
* *
* Free Software Foundation Voice: +1-617-542-5942 *
* 51 Franklin Street, Fifth Floor Fax: +1-617-542-2652 *
* Boston, MA 02110-1301, USA gnu@gnu.org *
* *
\********************************************************************/
#include <config.h>
#include <gio/gio.h>
#include <glib.h>
#include <stdio.h>
#include <string.h>
#include "gnc-gsettings.h"
#include "gnc-path.h"
#include "qof.h"
#include "gnc-prefs-p.h"
#include <boost/property_tree/ptree.hpp>
#include <boost/property_tree/xml_parser.hpp>
#include <fstream>
#include <iostream>
#include <unordered_map>
namespace bpt = boost::property_tree;
#define GSET_SCHEMA_PREFIX "org.gnucash.GnuCash"
#define GSET_SCHEMA_OLD_PREFIX "org.gnucash"
struct GSettingsDeleter
{
void operator()(GSettings* gsp)
{
g_object_unref(gsp);
}
};
static GSettingsDeleter g_settings_deleter;
using GSettingsPtr = std::unique_ptr<GSettings, GSettingsDeleter>;
static std::unordered_map<std::string,GSettingsPtr> schema_hash;
/* This static indicates the debugging module that this .o belongs to. */
static QofLogModule log_module = "gnc.app-utils.gsettings";
/************************************************************/
/* Internal helper functions */
/************************************************************/
static bool gnc_gsettings_is_valid_key(GSettings *settings, const gchar *key)
{
// Check if the key is valid key within settings
if (!G_IS_SETTINGS(settings))
return false;
GSettingsSchema *schema;
g_object_get (settings, "settings-schema", &schema, nullptr);
if (!schema)
return false;
auto keys = g_settings_schema_list_keys (schema);
auto found = (keys && g_strv_contains(keys, key));
g_strfreev (keys);
g_settings_schema_unref (schema);
return found;
}
static std::string
normalize_schema_name (const gchar *name)
{
if (!name)
return GSET_SCHEMA_PREFIX;
if (g_str_has_prefix (name, GSET_SCHEMA_PREFIX) ||
(g_str_has_prefix (name, GSET_SCHEMA_OLD_PREFIX)))
return name;
return std::string{GSET_SCHEMA_PREFIX} + '.' + name;
}
static GSettings * gnc_gsettings_get_settings_obj (const gchar *schema_str)
{
ENTER("");
auto full_name_str = normalize_schema_name (schema_str);
auto full_name = full_name_str.c_str();
auto schema_source {g_settings_schema_source_get_default()};
auto schema {g_settings_schema_source_lookup(schema_source, full_name, true)};
auto gset = g_settings_new_full (schema, nullptr, nullptr);
DEBUG ("Created gsettings object %p for schema %s", gset, full_name);
if (!G_IS_SETTINGS(gset))
PWARN ("Ignoring attempt to access unknown gsettings schema %s", full_name);
LEAVE("");
g_settings_schema_unref (schema);
return gset;
}
static GSettings*
schema_to_gsettings (const char *schema, bool can_retrieve)
{
auto full_name = normalize_schema_name (schema);
auto iter = schema_hash.find (full_name);
if (iter != schema_hash.end())
return iter->second.get();
if (!can_retrieve)
return nullptr;
auto gs_obj = gnc_gsettings_get_settings_obj (schema);
if (!G_IS_SETTINGS (gs_obj))
{
PWARN ("Ignoring attempt to access unknown gsettings schema %s", full_name.c_str());
return nullptr;
}
schema_hash[full_name] = GSettingsPtr (gs_obj, g_settings_deleter);
return gs_obj;
}
/************************************************************/
/* GSettings Utilities */
/************************************************************/
const gchar *
gnc_gsettings_get_prefix (void)
{
return GSET_SCHEMA_PREFIX;
}
/************************************************************/
/* Change notification */
/************************************************************/
gulong
gnc_gsettings_register_cb (const gchar *schema, const gchar *key,
gpointer func,
gpointer user_data)
{
ENTER("");
g_return_val_if_fail (func, 0);
auto gs_obj = schema_to_gsettings (schema, true);
g_return_val_if_fail (G_IS_SETTINGS (gs_obj), 0);
auto signal = static_cast<char *> (nullptr);
if (!(key && *key))
signal = g_strdup ("changed");
else if (gnc_gsettings_is_valid_key(gs_obj, key))
signal = g_strconcat ("changed::", key, nullptr);
auto handlerid = g_signal_connect (gs_obj, signal, G_CALLBACK (func), user_data);
if (handlerid)
{
g_object_ref (gs_obj);
PINFO("schema: %s, key: %s, gs_obj: %p, handler_id: %ld",
schema, key, gs_obj, handlerid);
}
g_free (signal);
LEAVE("");
return handlerid;
}
static void
gnc_gsettings_remove_cb_by_id_internal (GSettings *gs_obj, guint handlerid)
{
ENTER ();
g_return_if_fail (G_IS_SETTINGS (gs_obj));
g_signal_handler_disconnect (gs_obj, handlerid);
g_object_unref (gs_obj);
LEAVE ("Schema: %p, handlerid: %d - removed for handler",
gs_obj, handlerid);
}
void
gnc_gsettings_remove_cb_by_func (const gchar *schema, const gchar *key,
gpointer func, gpointer user_data)
{
ENTER ();
g_return_if_fail (func);
auto gs_obj = schema_to_gsettings (schema, false);
if (!G_IS_SETTINGS (gs_obj))
{
LEAVE ("No valid GSettings object retrieved from hash table");
return;
}
auto match_type = static_cast<GSignalMatchType> (G_SIGNAL_MATCH_DETAIL | G_SIGNAL_MATCH_FUNC | G_SIGNAL_MATCH_DATA);
auto changed_signal = g_signal_lookup ("changed", G_TYPE_SETTINGS); /* signal_id */
auto quark = g_quark_from_string (key); /* signal_detail */
auto matched = 0;
guint handler_id = 0;
do
{
handler_id = g_signal_handler_find (gs_obj, match_type,
changed_signal, quark, nullptr,
func, user_data);
if (handler_id)
{
matched ++;
gnc_gsettings_remove_cb_by_id_internal (gs_obj, handler_id);
// Previous function will invalidate object if there is only one handler
if (!G_IS_SETTINGS (gs_obj))
handler_id = 0;
}
} while (handler_id);
LEAVE ("Schema: %s, key: %s - removed %d handlers for 'changed' signal",
schema, key, matched);
}
void
gnc_gsettings_remove_cb_by_id (const gchar *schema, guint handlerid)
{
ENTER ();
auto gs_obj = schema_to_gsettings (schema, false);
if (!G_IS_SETTINGS (gs_obj))
{
LEAVE ("No valid GSettings object retrieved from hash table");
return;
}
gnc_gsettings_remove_cb_by_id_internal (gs_obj, handlerid);
LEAVE ("Schema: %p, handlerid: %d - removed for handler",
gs_obj, handlerid);
}
guint
gnc_gsettings_register_any_cb (const gchar *schema,
gpointer func,
gpointer user_data)
{
return gnc_gsettings_register_cb (schema, nullptr, func, user_data);
}
void
gnc_gsettings_remove_any_cb_by_func (const gchar *schema,
gpointer func,
gpointer user_data)
{
gnc_gsettings_remove_cb_by_func (schema, nullptr, func, user_data);
}
void gnc_gsettings_bind (const gchar *schema,
/*@ null @*/ const gchar *key,
gpointer object,
const gchar *property)
{
auto gs_obj = gnc_gsettings_get_settings_obj (schema);
g_return_if_fail (G_IS_SETTINGS (gs_obj));
if (gnc_gsettings_is_valid_key (gs_obj, key))
g_settings_bind (gs_obj, key, object, property, G_SETTINGS_BIND_DEFAULT);
else
PERR ("Invalid key %s for schema %s", key, schema);
}
static void
gs_obj_block_handlers ([[maybe_unused]] gpointer key, gpointer gs_obj,
[[maybe_unused]] gpointer pointer)
{
g_signal_handlers_block_matched (gs_obj, G_SIGNAL_MATCH_CLOSURE, 0, 0, nullptr, nullptr, nullptr);
PINFO("Block all handlers for GSettings object %p", gs_obj);
}
static void
gs_obj_unblock_handlers ([[maybe_unused]] gpointer key, gpointer gs_obj,
[[maybe_unused]] gpointer pointer)
{
g_signal_handlers_unblock_matched (gs_obj, G_SIGNAL_MATCH_CLOSURE, 0, 0, nullptr, nullptr, nullptr);
PINFO("Unblock all handlers for GSettings object %p", gs_obj);
}
void gnc_gsettings_block_all (void)
{
ENTER ();
for (const auto& it : schema_hash)
gs_obj_block_handlers (nullptr, it.second.get(), nullptr);
LEAVE();
}
void gnc_gsettings_unblock_all (void)
{
ENTER ();
for (const auto& it : schema_hash)
gs_obj_unblock_handlers (nullptr, it.second.get(), nullptr);
LEAVE();
}
/************************************************************/
/* Getters */
/************************************************************/
template<typename T>
T gnc_gsettings_get(const char *schema, const char *key,
auto getter(GSettings*, const char *)->T, T default_val)
{
auto gs_obj = gnc_gsettings_get_settings_obj (schema);
g_return_val_if_fail (G_IS_SETTINGS (gs_obj), default_val);
T val = default_val;
if (gnc_gsettings_is_valid_key (gs_obj, key))
val = getter (gs_obj, key);
else
PERR ("Invalid key %s for schema %s", key, schema);
g_object_unref (gs_obj);
return val;
}
gboolean
gnc_gsettings_get_bool (const gchar *schema, const gchar *key)
{
return gnc_gsettings_get (schema, key, g_settings_get_boolean,
static_cast<gboolean>(false));
}
gint
gnc_gsettings_get_int (const gchar *schema, const gchar *key)
{
return gnc_gsettings_get (schema, key, g_settings_get_int, 0);
}
gdouble
gnc_gsettings_get_float (const gchar *schema, const gchar *key)
{
return gnc_gsettings_get (schema, key, g_settings_get_double, 0.0);
}
gchar *
gnc_gsettings_get_string (const gchar *schema, const gchar *key)
{
return gnc_gsettings_get (schema, key, g_settings_get_string,
static_cast<gchar *> (nullptr));
}
gint
gnc_gsettings_get_enum (const gchar *schema, const gchar *key)
{
return gnc_gsettings_get (schema, key, g_settings_get_enum, 0);
}
GVariant *
gnc_gsettings_get_value (const gchar *schema, const gchar *key)
{
return gnc_gsettings_get (schema, key, g_settings_get_value,
static_cast<GVariant *> (nullptr));
}
/************************************************************/
/* Setters */
/************************************************************/
template<typename T> gboolean
gnc_gsettings_set (const gchar *schema,
const gchar *key,
T value,
gboolean setter(GSettings*, const char *, T))
{
ENTER("schema: %s, key: %s", schema, key);
auto gs_obj = gnc_gsettings_get_settings_obj (schema);
g_return_val_if_fail (G_IS_SETTINGS (gs_obj), false);
auto result = false;
if (gnc_gsettings_is_valid_key (gs_obj, key))
{
result = setter (gs_obj, key, value);
if (!result)
PERR ("Unable to set value for key %s in schema %s", key, schema);
}
else
PERR ("Invalid key %s for schema %s", key, schema);
g_object_unref (gs_obj);
LEAVE("result %i", result);
return result;
}
gboolean
gnc_gsettings_set_bool (const gchar *schema, const gchar *key, gboolean value)
{
return gnc_gsettings_set (schema, key, value, g_settings_set_boolean);
}
gboolean
gnc_gsettings_set_int (const gchar *schema, const gchar *key, gint value)
{
return gnc_gsettings_set (schema, key, value, g_settings_set_int);
}
gboolean
gnc_gsettings_set_float (const gchar *schema, const gchar *key, gdouble value)
{
return gnc_gsettings_set (schema, key, value, g_settings_set_double);
}
gboolean
gnc_gsettings_set_string (const gchar *schema, const gchar *key, const gchar *value)
{
return gnc_gsettings_set (schema, key, value, g_settings_set_string);
}
gboolean
gnc_gsettings_set_enum (const gchar *schema, const gchar *key, gint value)
{
return gnc_gsettings_set (schema, key, value, g_settings_set_enum);
}
gboolean
gnc_gsettings_set_value (const gchar *schema, const gchar *key, GVariant *value)
{
return gnc_gsettings_set (schema, key, value, g_settings_set_value);
}
void
gnc_gsettings_reset (const gchar *schema,
const gchar *key)
{
auto gs_obj = gnc_gsettings_get_settings_obj (schema);
g_return_if_fail (G_IS_SETTINGS (gs_obj));
if (gnc_gsettings_is_valid_key (gs_obj, key))
g_settings_reset (gs_obj, key);
else
PERR ("Invalid key %s for schema %s", key, schema);
g_object_unref (gs_obj);
}
void
gnc_gsettings_reset_schema (const gchar *schema_str)
{
auto gs_obj = gnc_gsettings_get_settings_obj (schema_str);
if (!gs_obj)
return;
GSettingsSchema *schema;
g_object_get (gs_obj, "settings-schema", &schema, nullptr);
if (!schema)
{
g_object_unref (gs_obj);
return;
}
auto keys = g_settings_schema_list_keys (schema);
if (keys)
{
auto fkeys = keys;
for (auto key = *fkeys; key; key = *++fkeys)
gnc_gsettings_reset (schema_str, key);
}
g_object_unref (gs_obj);
g_settings_schema_unref (schema);
g_strfreev (keys);
}
static void
gnc_settings_dump_schema_paths (void)
{
gchar **non_relocatable;
auto schema_source {g_settings_schema_source_get_default()};
g_settings_schema_source_list_schemas (schema_source, true,
&non_relocatable, nullptr);
for (gint i = 0; non_relocatable[i] != nullptr; i++)
PINFO("Schema entry %d is '%s'", i, non_relocatable[i]);
g_strfreev (non_relocatable);
}
void gnc_gsettings_load_backend (void)
{
ENTER("");
/* The gsettings backend only works in an installed environment.
* When called from the source environment (for testing purposes)
* simply return.
*/
if (g_strcmp0 (g_getenv ("GNC_UNINSTALLED"), "1") == 0)
return;
g_free (prefsbackend);
prefsbackend = g_new0 (PrefsBackend, 1);
prefsbackend->register_cb = gnc_gsettings_register_cb;
prefsbackend->remove_cb_by_func = gnc_gsettings_remove_cb_by_func;
prefsbackend->remove_cb_by_id = gnc_gsettings_remove_cb_by_id;
prefsbackend->register_group_cb = gnc_gsettings_register_any_cb;
prefsbackend->remove_group_cb_by_func = gnc_gsettings_remove_any_cb_by_func;
prefsbackend->bind = gnc_gsettings_bind;
prefsbackend->get_bool = gnc_gsettings_get_bool;
prefsbackend->get_int = gnc_gsettings_get_int;
prefsbackend->get_float = gnc_gsettings_get_float;
prefsbackend->get_string = gnc_gsettings_get_string;
prefsbackend->get_enum = gnc_gsettings_get_enum;
prefsbackend->get_value = gnc_gsettings_get_value;
prefsbackend->set_bool = gnc_gsettings_set_bool;
prefsbackend->set_int = gnc_gsettings_set_int;
prefsbackend->set_float = gnc_gsettings_set_float;
prefsbackend->set_string = gnc_gsettings_set_string;
prefsbackend->set_enum = gnc_gsettings_set_enum;
prefsbackend->set_value = gnc_gsettings_set_value;
prefsbackend->reset = gnc_gsettings_reset;
prefsbackend->reset_group = gnc_gsettings_reset_schema;
prefsbackend->block_all = gnc_gsettings_block_all;
prefsbackend->unblock_all = gnc_gsettings_unblock_all;
if (qof_log_check (log_module, QOF_LOG_DEBUG))
gnc_settings_dump_schema_paths ();
/* Run any data model changes for the backend before it's used
* by anyone */
gnc_gsettings_version_upgrade();
LEAVE("Prefsbackend bind = %p", prefsbackend->bind);
}
void
gnc_gsettings_shutdown (void)
{
schema_hash.clear();
g_free (prefsbackend);
}
static GVariant *
gnc_gsettings_get_user_value (const gchar *schema,
const gchar *key)
{
auto gs_obj = gnc_gsettings_get_settings_obj (schema);
g_return_val_if_fail (G_IS_SETTINGS (gs_obj), nullptr);
auto val = static_cast<GVariant *> (nullptr);
if (gnc_gsettings_is_valid_key (gs_obj, key))
val = g_settings_get_user_value (gs_obj, key);
else
PERR ("Invalid key %s for schema %s", key, schema);
g_object_unref (gs_obj);
return val;
}
using opt_str_vec = boost::optional<std::string>;
static void
deprecate_one_key (const opt_str_vec &oldpath, const opt_str_vec &oldkey)
{
if (!oldpath || !oldkey )
{
DEBUG ("Skipping <deprecate> node - missing attribute (old-path or old-key)");
return;
}
PINFO ("'%s:%s' has been marked deprecated", oldpath->c_str(), oldkey->c_str());
/* This does nothing really, but is a reminder for future maintainers
* to mark this pref as obsolete in the next major release. */
}
static void
migrate_one_key (const opt_str_vec &oldpath, const opt_str_vec &oldkey,
const opt_str_vec &newpath, const opt_str_vec &newkey)
{
if (!oldpath || !oldkey || !newpath || !newkey)
{
DEBUG ("Skipping <migrate> node - missing attribute (old-path, old-key, new-path or new-key)");
return;
}
PINFO ("Migrating '%s:%s' to '%s:%s'", oldpath->c_str(), oldkey->c_str(),
newpath->c_str(), newkey->c_str());
auto user_value = gnc_gsettings_get_user_value (oldpath->c_str(), oldkey->c_str());
if (user_value)
gnc_gsettings_set_value (newpath->c_str(), newkey->c_str(), user_value);
}
static void
obsolete_one_key (const opt_str_vec &oldpath, const opt_str_vec &oldkey)
{
if (!oldpath || !oldkey )
{
DEBUG ("Skipping <obsolete> node - missing attribute (old-path or old-key)");
return;
}
PINFO ("Resetting obsolete '%s:%s'", oldpath->c_str(), oldkey->c_str());
gnc_gsettings_reset (oldpath->c_str(), oldkey->c_str());
}
static void
parse_one_release_node (bpt::ptree &pt)
{
/* loop over top-level property tree */
std::for_each (pt.begin(), pt.end(),
[] (std::pair<bpt::ptree::key_type, bpt::ptree> node)
{
if (node.first == "<xmlattr>")
return;
else if (node.first == "deprecate")
deprecate_one_key (node.second.get_optional<std::string> ("<xmlattr>.old-path"),
node.second.get_optional<std::string> ("<xmlattr>.old-key"));
else if (node.first == "migrate")
migrate_one_key (node.second.get_optional<std::string> ("<xmlattr>.old-path"),
node.second.get_optional<std::string> ("<xmlattr>.old-key"),
node.second.get_optional<std::string> ("<xmlattr>.new-path"),
node.second.get_optional<std::string> ("<xmlattr>.new-key"));
else if (node.first == "obsolete")
obsolete_one_key (node.second.get_optional<std::string> ("<xmlattr>.old-path"),
node.second.get_optional<std::string> ("<xmlattr>.old-key"));
else
{
DEBUG ("Skipping unknown node <%s>", node.first.c_str());
return;
}
});
}
static void
transform_settings (int old_maj_min, int cur_maj_min)
{
bpt::ptree pt;
auto pkg_data_dir = gnc_path_get_pkgdatadir();
auto transform_file = std::string (pkg_data_dir) + "/pref_transformations.xml";
g_free (pkg_data_dir);
std::ifstream transform_stream {transform_file};
if (!transform_stream.is_open())
{
PWARN("Failed to load preferences transformation file '%s'", transform_file.c_str());
return;
}
try
{
bpt::read_xml (transform_stream, pt);
}
catch (bpt::xml_parser_error &e) {
PWARN ("Failed to parse GnuCash preferences transformation file.\n");
PWARN ("Error message:\n");
PWARN ("%s\n", e.what());
return;
}
catch (...) {
PWARN ("Unknown error while parsing GnuCash preferences transformation file.\n");
return;
}
/* loop over top-level property tree */
std::for_each (pt.begin(), pt.end(),
[&old_maj_min, &cur_maj_min] (std::pair<bpt::ptree::key_type, bpt::ptree> node)
{
if (node.first != "release")
{
DEBUG ("Skipping non-<release> node <%s>", node.first.c_str());
return;
}
auto version = node.second.get_optional<int> ("<xmlattr>.version");
if (!version)
{
DEBUG ("Skipping <release> node - no version attribute found");
return;
}
if (*version <= old_maj_min)
{
DEBUG ("Skipping <release> node - version %i is less than current compatibility level %i", *version, old_maj_min);
return;
}
if (*version > cur_maj_min)
{
DEBUG ("Skipping <release> node - version %i is greater than current version level %i", *version, cur_maj_min);
return;
}
DEBUG ("Retrieved version value '%i'", *version);
parse_one_release_node (node.second);
});
}
void gnc_gsettings_version_upgrade (void)
{
/* This routine will conditionally execute conversion rules from
* prefs_transformations.xml to adapt the user's existing preferences to
* the current preferences schema. The rules in this file are versioned and
* only rules still relevant to the user's existing preferences and for
* this version of GnuCash will be executed.
*
* Starting with GnuCash 4.7 the code expects all preferences to be stored
* under prefix org.gnucash.GnuCash instead of org.gnucash, including our
* GNC_PREF_VERSION setting.
* As the logic to determine whether or not settings conversions are needed
* depends on this preference, we have to test for its value in two
* locations:
* - if GNC_PREF_VERSION is not set under old nor new prefix
* => GnuCash has never run before so no conversion run necessary
* - if GNC_PREF_VERSION is set under old prefix and not new prefix
* => user's preferences weren't moved yet from old to new prefix. Use old
* prefix GNC_PREF_VERSION to determine which conversions may be needed
* - if GNC_PREF_VERSION is set under both prefixes
* => ignore old prefix and use new prefix GNC_PREF_VERSION to determine
* which conversions may be needed.
* Sometime in the future (GnuCash 6.0) the old prefix will be fully removed
* and the test will be simplified to only check in the new prefix.
*/
ENTER("Start of settings transform routine.");
auto ogG_maj_min = gnc_gsettings_get_user_value (GNC_PREFS_GROUP_GENERAL, GNC_PREF_VERSION);
auto og_maj_min = gnc_gsettings_get_user_value (GSET_SCHEMA_OLD_PREFIX "." GNC_PREFS_GROUP_GENERAL, GNC_PREF_VERSION);
auto cur_maj_min = PROJECT_VERSION_MAJOR * 1000 + PROJECT_VERSION_MINOR;
if (!ogG_maj_min && !og_maj_min) // new install
{
gnc_gsettings_set_int (GNC_PREFS_GROUP_GENERAL, GNC_PREF_VERSION, cur_maj_min);
LEAVE ("Setting Previous compatibility level to current version: %i", cur_maj_min);
return;
}
auto old_maj_min = 0;
if (!ogG_maj_min) // old preference location
old_maj_min = gnc_gsettings_get_int (GSET_SCHEMA_OLD_PREFIX "." GNC_PREFS_GROUP_GENERAL, GNC_PREF_VERSION);
else // new preference location
{
g_variant_unref (ogG_maj_min);
old_maj_min = gnc_gsettings_get_int (GNC_PREFS_GROUP_GENERAL, GNC_PREF_VERSION);
}
if (og_maj_min)
g_variant_unref (og_maj_min);
PINFO ("Previous setting compatibility level: %i, Current version: %i", old_maj_min, cur_maj_min);
transform_settings (old_maj_min, cur_maj_min);
/* Only write current version if it's more recent than what was set */
if (cur_maj_min > old_maj_min)
gnc_gsettings_set_int (GNC_PREFS_GROUP_GENERAL, GNC_PREF_VERSION, cur_maj_min);
LEAVE("");
}