mirror of
https://github.com/Gnucash/gnucash.git
synced 2025-02-25 18:55:30 -06:00
9386b276e5
With the explicit prototypes not marked as static unit test builds on Debian Buster (using buster-backports) fail with error: testing::internal::ParamGenerator<TestCase*> gtest_InstantiationAutoClearTestAutoClearTest_EvalGenerator_() was declared extern and later static [-fpermissive] According to the comment preceding the declaration the only intent of the explicit prototype (in newer versions of googletest implicitly defined by the GTEST macros) seems to be to silence a warning which would cause a build failure on Ubuntu 18.04 when using -Werror. Builds on Debian unstable seem to build just fine without this explicit declaration, hence I consider it safe to just drop it. However, builds on Ubuntu 18.04 then fail (see above). Making the prototypes as static should make both build environments happy.