mirror of
https://github.com/Gnucash/gnucash.git
synced 2026-11-04 21:26:43 -06:00
Noerr
89448ffd34
PR #2187 made GncPrice.get_value() return a GncNumeric wrapper and clone() a fully wrapped GncPrice. The price example scripts still used the pre-5.15 raw _gnc_numeric idiom and broke -- reported as Bug 799796 (cloned prices silently kept the original value). Example scripts (bindings/python/example_scripts/): * quotes_historic.py -- reworked to the modern idiom; it now actually runs on 5.x (it had further latent breakage beyond the reported one): - Construct each price directly with GncPrice(book) + setters instead of cloning an existing price, so the script no longer needs a pre-existing price in the book. Look the pricing currency (USD) up from the commodity table rather than deriving it from a split. - Build the value with the double->GncNumeric constructor at GnuCash's standard price precision -- the pricing currency's SCU * COMMODITY_DENOM_MULT rounded HALF_UP (gnc-pricedb.h "Price policy") -- dropping the Fraction.from_float().limit_denominator(100000) dance and its import. - Set the source with the PriceSource enum -- set_source(PriceSource.FINANCE_QUOTE) (the enum added in #2317). The original set_source("Finance::Quotes::Historic") passed a string to what has been an enum setter since 2.6, which raises TypeError on modern bindings. - Open with Session(url), which defaults to SESSION_NORMAL_OPEN. The old Session(url, True, False, False) passed the deprecated ignore_lock=True, silently bypassing the book's lock file. * priceDB_test.py, price_database_example.py -- num/denom are methods now, so read v.num() / v.denom(). Prevent silent recurrence (gnucash_core.py): The write path failed *silently*, which is how this slipped through review and CI. num/denom are read-only accessor methods, so assigning to them merely shadows the method and changes nothing. Add a GncNumeric.__setattr__ that raises AttributeError on assignment to num/denom, pointing at the correct idiom GncNumeric(num, denom). Test (bindings/python/tests/test_numeric.py): New test_num_denom_read_only covering the guard. It needs no backend, so it runs in the existing python-bindings CTest on all platforms. The wiki page Stocks/get_prices, which the reporter copied from, is being updated separately.
85 lines
2.7 KiB
Python
85 lines
2.7 KiB
Python
#!/usr/bin/env python3
|
|
|
|
# quotes_historic.py -- Example Script to read historic quote data into gnucash
|
|
#
|
|
|
|
## @file
|
|
# @brief Example Script to read historic stock data into gnucash
|
|
# @author Peter Holtermann
|
|
# @date January 2011
|
|
# @ingroup python_bindings_examples
|
|
#
|
|
# Call the perl-script @code
|
|
# ./get_quotes.pl INTC
|
|
# @endcode first to achieve data into file INTC which can thereafter be imported to GnuCash using this script.
|
|
#
|
|
# For explanation of use have a look at the wiki:
|
|
# https://wiki.gnucash.org/wiki/Stocks/get_prices
|
|
#
|
|
|
|
from gnucash import Session, GncNumeric, GncPrice, PriceSource, GNC_HOW_DENOM_FIXED, GNC_HOW_RND_ROUND_HALF_UP
|
|
from gnucash.gnucash_core_c import COMMODITY_DENOM_MULT
|
|
import datetime
|
|
from gnc_convenience import find_account
|
|
|
|
FILE = "./test.gnucash"
|
|
url = "xml://"+FILE
|
|
|
|
# Read data from file
|
|
f = open('INTC')
|
|
data = []
|
|
while 1:
|
|
tmp = f.readline()
|
|
if(len(tmp)<2):
|
|
break
|
|
|
|
data.append(tmp)
|
|
|
|
f.close()
|
|
|
|
stock_date = []
|
|
stock_price = []
|
|
for i in range(1,len(data)):
|
|
year = int(data[i].rsplit(',')[1].rsplit('/')[0])
|
|
month = int(data[i].rsplit(',')[1].rsplit('/')[1])
|
|
day = int(data[i].rsplit(',')[1].rsplit('/')[2])
|
|
stock_date.append(datetime.datetime(year,month,day))
|
|
stock_price.append(float(data[i].rsplit(',')[5]))
|
|
|
|
# Initialize Gnucash session
|
|
session = Session(url)
|
|
root = session.book.get_root_account()
|
|
book = session.book
|
|
account = book.get_root_account()
|
|
pdb = book.get_price_db()
|
|
comm_table = book.get_table()
|
|
|
|
# This example assumes the Intel holding is priced in USD.
|
|
ac = find_account(account, 'Intel')[0]
|
|
stock = ac.GetCommodity()
|
|
cur = comm_table.lookup("CURRENCY", "USD")
|
|
|
|
# Construct the price at the precision GnuCash uses for a commodity quoted in a
|
|
# currency: the currency's smallest unit (its SCU -- get_fraction() is 100 for
|
|
# USD, i.e. cents) times COMMODITY_DENOM_MULT (10000), the extra precision a
|
|
# price carries beyond an ordinary amount. See "Price policy" in gnc-pricedb.h.
|
|
price_denom = cur.get_fraction() * COMMODITY_DENOM_MULT
|
|
for i in range(0, len(stock_date)):
|
|
print('Adding', i, stock_date[i], stock_price[i])
|
|
# --- Create a fresh price object with all properties set ------------------
|
|
p_new = GncPrice(book)
|
|
p_new.set_commodity(stock)
|
|
p_new.set_currency(cur)
|
|
p_new.set_time64(stock_date[i])
|
|
p_new.set_value(GncNumeric(stock_price[i], price_denom,
|
|
GNC_HOW_DENOM_FIXED | GNC_HOW_RND_ROUND_HALF_UP))
|
|
p_new.set_source(PriceSource.FINANCE_QUOTE)
|
|
p_new.set_typestr("last") # bid / ask / last / nav / unknown
|
|
# --------------------------------------------------------------------------
|
|
pdb.add_price(p_new)
|
|
|
|
# Clean up
|
|
session.save()
|
|
session.end()
|
|
session.destroy()
|