diff --git a/commit_panel.go b/commit_panel.go index 17f54882a..5de77c760 100644 --- a/commit_panel.go +++ b/commit_panel.go @@ -18,7 +18,6 @@ func handleCommitPress(g *gocui.Gui, currentView *gocui.View) error { return nil } maxX, maxY := g.Size() - // var v *gocui.View if v, err := g.SetView("commit", maxX/2-30, maxY/2-1, maxX/2+30, maxY/2+1); err != nil { if err != gocui.ErrUnknownView { return err @@ -51,7 +50,9 @@ func handleCommitSubmit(g *gocui.Gui, v *gocui.View) error { func closeCommitPrompt(g *gocui.Gui, v *gocui.View) error { filesView, _ := g.View("files") - switchFocus(g, v, filesView) + // not passing in the view as oldView to switchFocus because we don't want a + // reference pointing to a deleted view + switchFocus(g, nil, filesView) devLog("test prompt close") if err := g.DeleteView("commit"); err != nil { return err diff --git a/view_helpers.go b/view_helpers.go index 01af1cdeb..fe643c5a7 100644 --- a/view_helpers.go +++ b/view_helpers.go @@ -24,9 +24,8 @@ func returnFocus(g *gocui.Gui, v *gocui.View) error { func switchFocus(g *gocui.Gui, oldView, newView *gocui.View) error { if oldView != nil { oldView.Highlight = false - devLog("setting previous view to ") + devLog("setting previous view to:", oldView.Name()) state.PreviousView = oldView.Name() - devLog(state.PreviousView) } newView.Highlight = true devLog(newView.Name())