From 0500804df52c64bd250a75ed94f4c414a85ca52b Mon Sep 17 00:00:00 2001 From: dundargoc Date: Wed, 17 Jul 2024 15:54:09 +0200 Subject: [PATCH] ci: skip lintcommit workflow on release branches Since lintcommit is a required check, it will always need to be run. However, the lintcommit script is not designed to work on PRs that doesn't target master branch (and it's not clear whether it's even desirable). To circumvent this we create a "dummy" lintcommit check that is run on release branches that always passes, thus fulfilling the condition of the required check. --- .github/workflows/lintcommit.yml | 3 +-- .github/workflows/lintcommit_dummy.yml | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 2 deletions(-) create mode 100644 .github/workflows/lintcommit_dummy.yml diff --git a/.github/workflows/lintcommit.yml b/.github/workflows/lintcommit.yml index aa56de6d6a..49dc7f3e66 100644 --- a/.github/workflows/lintcommit.yml +++ b/.github/workflows/lintcommit.yml @@ -1,10 +1,9 @@ -name: "lintcommit" +name: lintcommit on: pull_request: types: [opened, synchronize, reopened, ready_for_review] branches: - 'master' - - 'release-[0-9]+.[0-9]+' jobs: lint-commits: runs-on: ubuntu-latest diff --git a/.github/workflows/lintcommit_dummy.yml b/.github/workflows/lintcommit_dummy.yml new file mode 100644 index 0000000000..e4a0c4af2d --- /dev/null +++ b/.github/workflows/lintcommit_dummy.yml @@ -0,0 +1,16 @@ +# Dummy workflow of lintcommit.yml. lintcommit is a required check, but it's +# only designed to work on master. Since required checks are always required to +# run, we can essentially "skip" the lintcommit on release branches with this +# dummy check that automatically passes. +name: lintcommit_dummy +on: + pull_request: + types: [opened, synchronize, reopened, ready_for_review] + branches: + - 'release-[0-9]+.[0-9]+' +jobs: + lint-commits: + runs-on: ubuntu-latest + if: github.event.pull_request.draft == false + steps: + - run: echo "success"