From 0fd4ef5da7448fa3449643b23d6aa3af1640efe8 Mon Sep 17 00:00:00 2001 From: Christian Clason Date: Sun, 19 Jan 2025 17:36:35 +0100 Subject: [PATCH] ci(tests): remove build-types jobs Problem: Some CI jobs are redundant: `RelWithDebInfo` is already tested on Linux-Arm64; `MinSizeRel` and Ninja Multi Config are not sufficiently relevant in practice to spend CI cycles on. Solution: Remove `build-types` job. --- .github/workflows/test.yml | 31 ------------------------------- 1 file changed, 31 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index e7032a3dda..a366dea082 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -204,37 +204,6 @@ jobs: windows: uses: ./.github/workflows/test_windows.yml - # This job tests the following things: - # - Check if MinSizeRel and RelWithDebInfo compiles correctly. - # - Test the above build types with the GCC compiler specifically. - # Empirically the difference in warning levels between GCC and other - # compilers is particularly big. - # - Test if the build works with multi-config generators. We mostly use - # single-config generators so it's nice to have a small sanity check for - # multi-config. - build-types: - runs-on: ubuntu-24.04 - timeout-minutes: 10 - env: - CC: gcc - steps: - - uses: actions/checkout@v4 - - uses: ./.github/actions/setup - - - name: Build third-party deps - run: | - cmake -S cmake.deps -B .deps -G "Ninja Multi-Config" - cmake --build .deps - - - name: Configure - run: cmake --preset ci -G "Ninja Multi-Config" - - - name: RelWithDebInfo - run: cmake --build build --config RelWithDebInfo - - - name: MinSizeRel - run: cmake --build build --config MinSizeRel - with-external-deps: runs-on: ubuntu-24.04 timeout-minutes: 10