From 1e47aa677a24231ec771137dadc7c2b65be775b4 Mon Sep 17 00:00:00 2001 From: Famiu Haque Date: Thu, 9 Jan 2025 21:32:27 +0600 Subject: [PATCH] fix(api): deprecated API nvim_get_option does not validate option name #31919 Problem: Deprecated API `nvim_get_option()` doesn't validate the option name, which leads to an assertion failure. Solution: Validate option name in `nvim_get_option()`. Ref: #31894 --- src/nvim/api/deprecated.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/nvim/api/deprecated.c b/src/nvim/api/deprecated.c index 406d5e7b4f..5150aeebec 100644 --- a/src/nvim/api/deprecated.c +++ b/src/nvim/api/deprecated.c @@ -648,6 +648,10 @@ static Object get_option_from(void *from, OptScope scope, String name, Error *er }); OptIndex opt_idx = find_option(name.data); + VALIDATE_S(opt_idx != kOptInvalid, "option name", name.data, { + return (Object)OBJECT_INIT; + }); + OptVal value = NIL_OPTVAL; if (option_has_scope(opt_idx, scope)) {