ci: don't delete core dumps at the start of the run (#22223)

There shouldn't be any core dumps before we have started testing.
This commit is contained in:
dundargoc 2023-02-11 14:51:41 +01:00 committed by GitHub
parent 27177e5819
commit 24ec0aaa7a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -6,10 +6,6 @@ set -o pipefail
print_core() { print_core() {
local app="$1" local app="$1"
local core="$2" local core="$2"
if test "$app" = quiet; then
echo "Found core $core"
return 0
fi
echo "======= Core file $core =======" echo "======= Core file $core ======="
if test "${CI_OS_NAME}" = osx; then if test "${CI_OS_NAME}" = osx; then
lldb -Q -o "bt all" -f "${app}" -c "${core}" lldb -Q -o "bt all" -f "${app}" -c "${core}"
@ -19,11 +15,6 @@ print_core() {
} }
check_core_dumps() { check_core_dumps() {
local del=
if test "$1" = "--delete"; then
del=1
shift
fi
local app="${1:-${BUILD_DIR}/bin/nvim}" local app="${1:-${BUILD_DIR}/bin/nvim}"
local cores local cores
if test "${CI_OS_NAME}" = osx; then if test "${CI_OS_NAME}" = osx; then
@ -39,17 +30,10 @@ check_core_dumps() {
fi fi
local core local core
for core in $cores; do for core in $cores; do
if test "$del" = "1"; then print_core "$app" "$core"
print_core "$app" "$core" >&2
"$_sudo" rm "$core"
else
print_core "$app" "$core"
fi
done done
if test "$app" != quiet; then echo 'Core dumps found'
echo 'Core dumps found' exit 1
exit 1
fi
} }
check_logs() { check_logs() {
@ -161,7 +145,6 @@ installtests() {(
)} )}
prepare_sanitizer() { prepare_sanitizer() {
check_core_dumps --delete quiet
# Invoke nvim to trigger *San early. # Invoke nvim to trigger *San early.
if ! ("${BUILD_DIR}"/bin/nvim --version && "${BUILD_DIR}"/bin/nvim -u NONE -e -cq | cat -vet); then if ! ("${BUILD_DIR}"/bin/nvim --version && "${BUILD_DIR}"/bin/nvim -u NONE -e -cq | cat -vet); then
check_sanitizer "${LOG_DIR}" check_sanitizer "${LOG_DIR}"