IntenseFinance/neovim
3
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-02-25 18:55:25 -06:00
Code Issues Packages Projects Releases Wiki Activity

PVS/V1026: normal.c: signed integer overflow

Browse Source 
> V1026 The 'curwin->w_curswant' variable is incremented in the loop.
> Undefined behavior will occur in case of signed integer overflow.
This commit is contained in:
Justin M. Keyes 2019-01-05 00:52:31 +01:00
parent 3e558468cf
commit 2a325892c2
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/nvim/normal.c
View File

@ -1,11 +1,11 @@
// This is an open source non-commercial project. Dear PVS-Studio, please check // This is an open source non-commercial project. Dear PVS-Studio, please check
// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com // it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com
/* //
* normal.c: Contains the main routine for processing characters in command // normal.c: Contains the main routine for processing characters in command
* mode. Communicates closely with the code in ops.c to handle // mode. Communicates closely with the code in ops.c to handle
* the operators. // the operators.
*/ //
#include <assert.h> #include <assert.h>
#include <inttypes.h> #include <inttypes.h>
@ -3939,9 +3939,11 @@ static bool nv_screengo(oparg_T *oap, int dir, long dist)
(void)hasFolding(curwin->w_cursor.lnum, (void)hasFolding(curwin->w_cursor.lnum,
&curwin->w_cursor.lnum, NULL); &curwin->w_cursor.lnum, NULL);
linelen = linetabsize(get_cursor_line_ptr()); linelen = linetabsize(get_cursor_line_ptr());
if (linelen > width1) if (linelen > width1) {
curwin->w_curswant += (((linelen - width1 - 1) / width2) int w = (((linelen - width1 - 1) / width2) + 1) * width2;
+ 1) * width2; assert(curwin->w_curswant <= INT_MAX - w);
curwin->w_curswant += w;
}
} }
} else { /* dir == FORWARD */ } else { /* dir == FORWARD */
if (linelen > width1) if (linelen > width1)