IntenseFinance/neovim
3
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-02-25 18:55:25 -06:00
Code Issues Packages Projects Releases Wiki Activity

coverity/72768: Negative array index read: FP.

Browse Source 
Problem    : Negative array index read @ 5674.
Diagnostic : False positive.
Rationale  : Problem occurs if for loop does not find any match, which
             implies shl->lnum == 0, and then we enter the
             `if (shl->lnum == lnum)` branch, which implies lnum == 0 as
             well. That's not possible, as function should not be called
             with lnum == 0.
Resolution : Change conditions `shl->lnum == lnum` into `bot != -1`.
This commit is contained in:
Eliseo Martínez 2015-02-13 14:34:27 +01:00
parent 03dd2114a7
commit 33cecbbf16
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/nvim/screen.c
View File

@ -5654,7 +5654,7 @@ next_search_hl_pos(
continue; continue;
} }
if (posmatch->pos[i].lnum == lnum) { if (posmatch->pos[i].lnum == lnum) {
if (shl->lnum == lnum) { if (bot != -1) {
// partially sort positions by column numbers // partially sort positions by column numbers
// on the same line // on the same line
if (posmatch->pos[i].col < posmatch->pos[bot].col) { if (posmatch->pos[i].col < posmatch->pos[bot].col) {
@ -5670,7 +5670,7 @@ next_search_hl_pos(
} }
} }
posmatch->cur = 0; posmatch->cur = 0;
if (shl->lnum == lnum) { if (bot != -1) {
colnr_T start = posmatch->pos[bot].col == 0 colnr_T start = posmatch->pos[bot].col == 0
? 0: posmatch->pos[bot].col - 1; ? 0: posmatch->pos[bot].col - 1;
colnr_T end = posmatch->pos[bot].col == 0 colnr_T end = posmatch->pos[bot].col == 0