From 3683d6b7a85c97d067c18fc283bf1c490087a8a9 Mon Sep 17 00:00:00 2001 From: dundargoc <33953936+dundargoc@users.noreply.github.com> Date: Sat, 4 Mar 2023 17:55:42 +0100 Subject: [PATCH] ci: move configuring cmake to the build part of the CI If the configuration fails then lints shouldn't be run, as most lint steps depends on a successful configuration. --- .github/workflows/test.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index c6b8291458..a702bce71f 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -75,6 +75,10 @@ jobs: cmake -S cmake.deps -B $DEPS_BUILD_DIR -G Ninja cmake --build $DEPS_BUILD_DIR + - if: success() || failure() && steps.abort_job.outputs.status == 'success' + name: configure + run: cmake -B build -G Ninja -D CI_BUILD=OFF + - if: "!cancelled()" name: Determine if run should be aborted id: abort_job @@ -88,10 +92,6 @@ jobs: version: latest args: --check runtime/ - - if: success() || failure() && steps.abort_job.outputs.status == 'success' - name: configure - run: cmake -B build -G Ninja -D CI_BUILD=OFF - - if: success() || failure() && steps.abort_job.outputs.status == 'success' name: luacheck run: cmake --build build --target lintlua-luacheck