From 38145b919d160ea63c2547533595e761b40cfe45 Mon Sep 17 00:00:00 2001 From: Christian Clason Date: Fri, 24 Jul 2020 22:39:12 +0200 Subject: [PATCH] build: remove duplicate empty CONFIGURE_COMMAND (#12676) The cmake file for libvterm had an empty CONFIGURE_COMMAND "", which tells cmake to skip the configure step for this dependency (even though a later patch added another, actual, CONFIGURE_COMMAND two lines below). Evidently the recently released cmake 3.18.0 is pickier about this than previous versions, causing the build to fail. Removing this line makes the build successful again. --- third-party/cmake/BuildLibvterm.cmake | 1 - 1 file changed, 1 deletion(-) diff --git a/third-party/cmake/BuildLibvterm.cmake b/third-party/cmake/BuildLibvterm.cmake index 61c1c90fa6..c3485dac25 100644 --- a/third-party/cmake/BuildLibvterm.cmake +++ b/third-party/cmake/BuildLibvterm.cmake @@ -27,7 +27,6 @@ function(BuildLibvterm) -DUSE_EXISTING_SRC_DIR=${USE_EXISTING_SRC_DIR} -P ${CMAKE_CURRENT_SOURCE_DIR}/cmake/DownloadAndExtractFile.cmake PATCH_COMMAND "${_libvterm_PATCH_COMMAND}" - CONFIGURE_COMMAND "" BUILD_IN_SOURCE 1 CONFIGURE_COMMAND "${_libvterm_CONFIGURE_COMMAND}" BUILD_COMMAND "${_libvterm_BUILD_COMMAND}"