test: luacheck update

We pull luacheck HEAD, so this is a "catch up" commit to fix
newly-discovered errors.

test/.luacheckrc

@@ -12,5 +12,9 @@ self = false
 -- Rerun tests only if their modification time changed.
 cache = true
 
+ignore = {
+  "631",  -- max_line_length
+}
+
 -- Ignore whitespace issues in converted Vim legacy tests.
 files["functional/legacy"] = {ignore = { "611", "612", "613", "621" }}

test/functional/legacy/007_ball_buffer_list_spec.lua

@@ -40,7 +40,7 @@ describe(':ball', function()
     -- Write contents of this file
     execute('%yank A')
     
-    -- Append contents of second window (Xxx1) 
+    -- Append contents of second window (Xxx1)
     feed('')
     execute('%yank A')
 

test/functional/legacy/054_buffer_local_autocommands_spec.lua

@@ -13,7 +13,7 @@ describe('BufLeave <buffer>', function()
     execute('au BufLeave <buffer> update')
     
     -- Here, autocommand for xx shall append a line
-    -- But autocommand shall not apply to buffer named <buffer> 
+    -- But autocommand shall not apply to buffer named <buffer>
     execute('e somefile')
 
     -- Here, autocommand shall be auto-deleted

test/functional/legacy/074_global_var_in_viminfo_spec.lua

@@ -31,8 +31,8 @@ describe('storing global variables in ShaDa files', function()
       'set visualbell',
       'set shada+=!',
       "let MY_GLOBAL_DICT={'foo': 1, 'bar': 0, 'longvarible': 1000}",
-      -- Store a really long list. Initially this was testing line wrapping in 
-      -- viminfo, but shada files has no line wrapping, no matter how long the 
+      -- Store a really long list. Initially this was testing line wrapping in
+      -- viminfo, but shada files has no line wrapping, no matter how long the
       -- list is.
       'let MY_GLOBAL_LIST=range(1,100)'
     )

test/unit/api/helpers.lua

@@ -106,7 +106,8 @@ local lua2obj_type_tab = {
                      api.xmalloc(len * ffi.sizeof('KeyValuePair'))),
     }})
     for i = 1, len do
-      local key, val = table.unpack(kvs[i])
+      local table_unpack = table.unpack or unpack  -- luacheck: compat
+      local key, val = table_unpack(kvs[i])
       dct.data.dictionary.items[i - 1] = ffi.new(
           'KeyValuePair', {key=ffi.gc(lua2obj(key), nil).data.string,
                            value=ffi.gc(lua2obj(val), nil)})