IntenseFinance/neovim
3
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-02-25 18:55:25 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(lsp): skip clients without rename capability (#18449)

Browse Source 
Follow up to https://github.com/neovim/neovim/pull/18441
This way rename should "just work" in most cases without having to
manually filter the client
This commit is contained in:
Mathias Fußenegger 2022-05-06 18:57:08 +02:00 committed by GitHub
parent d9ec57e16a
commit 44a4af0ed0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
runtime/lua/vim/lsp/buf.lua
View File

@ -383,8 +383,14 @@ function M.rename(new_name, options)
)
end
-- Clients must at least support rename, prepareRename is optional
clients = vim.tbl_filter(
function(client) return client.supports_method("textDocument/rename") end,
clients
)
if #clients == 0 then
vim.notify("[LSP] Rename request failed, no matching language servers.")
vim.notify("[LSP] Rename, no matching language servers with rename capability.")
end
local win = vim.api.nvim_get_current_win()
@ -459,7 +465,8 @@ function M.rename(new_name, options)
rename(input)
end)
end, bufnr)
elseif client.supports_method("textDocument/rename") then
else
assert(client.supports_method("textDocument/rename"), 'Client must support textDocument/rename')
if new_name then
rename(new_name)
return
@ -475,8 +482,6 @@ function M.rename(new_name, options)
end
rename(input)
end)
else
vim.notify('Client ' .. client.id .. '/' .. client.name .. ' has no rename capability')
end
end