IntenseFinance/neovim
3
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-02-25 18:55:25 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix warnings: fileio.c: readfile(): Dead assignment: HI.

Browse Source 
Problem    : Dead assignment @ 1754.
Diagnostic : Harmless issue.
Rationale  : It's true `iconv_fd` is not going to be used again (we are
             in the failure handler). But what is being done (assigning
             sentinel value to mark as "empty" after destroying) is in
             fact good practice, which could turn significant if more
             code is added later on. So, we don't want to remove this.
Resolution : Leave it there, but exclude from analysis.
This commit is contained in:
Eliseo Martínez 2014-11-10 00:03:47 +01:00
parent 1002e3fe1d
commit 4e02a1bf46
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/nvim/fileio.c
View File

@ -1751,7 +1751,9 @@ failed:
# ifdef USE_ICONV # ifdef USE_ICONV
if (iconv_fd != (iconv_t)-1) { if (iconv_fd != (iconv_t)-1) {
iconv_close(iconv_fd); iconv_close(iconv_fd);
# ifndef __clang_analyzer__
iconv_fd = (iconv_t)-1; iconv_fd = (iconv_t)-1;
# endif
} }
# endif # endif