IntenseFinance/neovim
3
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-02-25 18:55:25 -06:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:9.1.0439: Cannot filter the history (#28958)

Browse Source 
Problem:  Cannot filter the history
Solution: Implement :filter :history

closes: vim/vim#14835

42a5b5a6d0

Co-authored-by: Christian Brabandt <cb@256bit.org>
This commit is contained in:
zeertzjq 2024-05-24 15:45:07 +08:00 committed by GitHub
parent cd05fbef17
commit 4f431bb632
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 57 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
runtime/doc/various.txt
View File

@ -400,6 +400,7 @@ gx Opens the current filepath or URL (decided by
|:command| - filter by command name
|:files| - filter by file name
|:highlight| - filter by highlight group
|:history| - filter by history commands
|:jumps| - filter by file name
|:let| - filter by variable name
|:list| - filter whole line

3
src/nvim/cmdhist.c
View File

@ -662,7 +662,8 @@ void ex_history(exarg_T *eap)
i = 0;
}
if (hist[i].hisstr != NULL
&& hist[i].hisnum >= j && hist[i].hisnum <= k) {
&& hist[i].hisnum >= j && hist[i].hisnum <= k
&& !message_filtered(hist[i].hisstr)) {
msg_putchar('\n');
snprintf(IObuff, IOSIZE, "%c%6d ", i == idx ? '>' : ' ',
hist[i].hisnum);

54
test/old/testdir/test_history.vim
View File

@ -96,6 +96,60 @@ function Test_History()
call assert_fails('history xyz', 'E488:')
call assert_fails('history ,abc', 'E488:')
call assert_fails('call histdel(":", "\\%(")', 'E53:')
" Test for filtering the history list
let hist_filter = execute(':filter /_\d/ :history all')->split('\n')
call assert_equal(20, len(hist_filter))
let expected = [' # cmd history',
\ ' 2 text_2',
\ ' 3 text_3',
\ '> 4 text_4',
\ ' # search history',
\ ' 2 text_2',
\ ' 3 text_3',
\ '> 4 text_4',
\ ' # expr history',
\ ' 2 text_2',
\ ' 3 text_3',
\ '> 4 text_4',
\ ' # input history',
\ ' 2 text_2',
\ ' 3 text_3',
\ '> 4 text_4',
\ ' # debug history',
\ ' 2 text_2',
\ ' 3 text_3',
\ '> 4 text_4']
call assert_equal(expected, hist_filter)
let cmds = {'c': 'cmd', 's': 'search', 'e': 'expr', 'i': 'input', 'd': 'debug'}
for h in sort(keys(cmds))
" find some items
let hist_filter = execute(':filter /_\d/ :history ' .. h)->split('\n')
call assert_equal(4, len(hist_filter))
let expected = [' # ' .. cmds[h] .. ' history',
\ ' 2 text_2',
\ ' 3 text_3',
\ '> 4 text_4']
call assert_equal(expected, hist_filter)
" Search for an item that is not there
let hist_filter = execute(':filter /XXXX/ :history ' .. h)->split('\n')
call assert_equal(1, len(hist_filter))
let expected = [' # ' .. cmds[h] .. ' history']
call assert_equal(expected, hist_filter)
" Invert the filter condition, find non-matches
let hist_filter = execute(':filter! /_3$/ :history ' .. h)->split('\n')
call assert_equal(3, len(hist_filter))
let expected = [' # ' .. cmds[h] .. ' history',
\ ' 2 text_2',
\ '> 4 text_4']
call assert_equal(expected, hist_filter)
endfor
endfunction
function Test_history_truncates_long_entry()