From 739124c1b82bb7723f099a7c945e32fe1be9cf87 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Eliseo=20Marti=CC=81nez?= Date: Sat, 8 Nov 2014 09:23:55 +0100 Subject: [PATCH] Fix warnings: ex_cmds2.c: do_source(): Np dereference: FP. Problem : Dereference of null pointer @ 2462. Diagnostic : False positive. Rationale : Error occurred if neither loop neither following if were entered (this implied `script_items.ga_len < 0`, which should not be possible). Resolution : Assert not negative length (loop or if entered). --- src/nvim/ex_cmds2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/nvim/ex_cmds2.c b/src/nvim/ex_cmds2.c index 6e31142137..28483f9fdf 100644 --- a/src/nvim/ex_cmds2.c +++ b/src/nvim/ex_cmds2.c @@ -10,6 +10,7 @@ * ex_cmds2.c: some more functions for command line commands */ +#include #include #include #include @@ -2422,6 +2423,7 @@ do_source ( save_current_SID = current_SID; FileID file_id; bool file_id_ok = os_fileid((char *)fname_exp, &file_id); + assert(script_items.ga_len >= 0); for (current_SID = script_items.ga_len; current_SID > 0; --current_SID) { si = &SCRIPT_ITEM(current_SID); // Compare dev/ino when possible, it catches symbolic links.