IntenseFinance/neovim
3
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-02-25 18:55:25 -06:00
Code Issues Packages Projects Releases Wiki Activity

vim-patch:9.0.0770: quickfix commands may keep memory allocated

Browse Source 
Problem:    Quickfix commands may keep memory allocated.
Solution:   Free memory when it's a bit much. (Yegappan Lakshmanan,
            closes vim/vim#11379)

d8cd6f7427

Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
This commit is contained in:
zeertzjq 2023-03-05 17:03:00 +08:00
parent 1adad44b7c
commit 749fe2c383
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/nvim/quickfix.c
View File

@ -292,12 +292,26 @@ static garray_T *qfga_get(void)
ga_init(&qfga, 1, 256);
}
// Retain ga_data from previous use. Reset the length to zero.
// Reset the length to zero. Retain ga_data from previous use to avoid
// many alloc/free calls.
qfga.ga_len = 0;
return &qfga;
}
/// The "qfga" grow array buffer is reused across multiple quickfix commands as
/// a temporary buffer to reduce the number of alloc/free calls. But if the
/// buffer size is large, then to avoid holding on to that memory, clear the
/// grow array. Otherwise just reset the grow array length.
static void qfga_clear(void)
{
if (qfga.ga_maxlen > 1000) {
ga_clear(&qfga);
} else {
qfga.ga_len = 0;
}
}
// Counter to prevent autocmds from freeing up location lists when they are
// still being used.
static int quickfix_busy = 0;
@ -2847,6 +2861,8 @@ static void qf_jump_print_msg(qf_info_T *qi, int qf_index, qfline_T *qf_ptr, buf
msg_ext_set_kind("quickfix");
msg_attr_keep(gap->ga_data, 0, true, false);
msg_scroll = (int)i;
qfga_clear();
}
/// Find a usable window for opening a file from the quickfix/location list. If
@ -3204,6 +3220,7 @@ void qf_list(exarg_T *eap)
}
os_breakcheck();
}
qfga_clear();
}
/// Remove newlines and leading whitespace from an error message.
@ -4147,6 +4164,8 @@ static void qf_fill_buffer(qf_list_T *qfl, buf_T *buf, qfline_T *old_last, int q
// Delete the empty line which is now at the end
(void)ml_delete(lnum + 1, false);
}
qfga_clear();
}
// Correct cursor position.