IntenseFinance/neovim
3
0
Fork 0
mirror of https://github.com/neovim/neovim.git synced 2025-02-25 18:55:25 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix warnings: quickfix.c: qf_add_entry(): Np dereference: FP.

Browse Source 
Problem    : Dereference of null pointer @ 921.
Diagnostic : False positive.
Rationale  : If `qi->qf_lists[qi->qf_curlist].qf_count == 0` doesn't
             hold, we should be calling function with nonnull `*prevp`.
Resolution : Assert nonnull.
This commit is contained in:
Eliseo Martínez 2014-11-12 10:39:44 +01:00
parent 3d57bcee7d
commit 83a32aad82
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/nvim/quickfix.c
View File

@ -10,6 +10,7 @@
* quickfix.c: functions for quickfix mode, using a file with error messages * quickfix.c: functions for quickfix mode, using a file with error messages
*/ */
#include <assert.h>
#include <errno.h> #include <errno.h>
#include <inttypes.h> #include <inttypes.h>
#include <stdbool.h> #include <stdbool.h>
@ -880,7 +881,7 @@ void qf_free_all(win_T *wp)
static int static int
qf_add_entry ( qf_add_entry (
qf_info_T *qi, /* quickfix list */ qf_info_T *qi, /* quickfix list */
qfline_T **prevp, /* pointer to previously added entry or NULL */ qfline_T **prevp, /* nonnull pointer (to previously added entry or NULL) */
char_u *dir, /* optional directory name */ char_u *dir, /* optional directory name */
char_u *fname, /* file name or NULL */ char_u *fname, /* file name or NULL */
int bufnum, /* buffer number or zero */ int bufnum, /* buffer number or zero */
@ -920,6 +921,7 @@ qf_add_entry (
qi->qf_lists[qi->qf_curlist].qf_start = qfp; qi->qf_lists[qi->qf_curlist].qf_start = qfp;
qfp->qf_prev = qfp; /* first element points to itself */ qfp->qf_prev = qfp; /* first element points to itself */
} else { } else {
assert(*prevp);
qfp->qf_prev = *prevp; qfp->qf_prev = *prevp;
(*prevp)->qf_next = qfp; (*prevp)->qf_next = qfp;
} }