os_file_is_*: libuv impl

- uv_fs_access() is far more robust than access(). In particular, it
  handles utf16 paths (Windows).
- Still need R_OK, W_OK in win_defs.h
This commit is contained in:
Justin M. Keyes 2015-08-17 00:44:58 -04:00
parent b1e18dc393
commit 86c38ef126

View File

@ -285,7 +285,10 @@ bool os_file_is_readonly(const char *name)
bool os_file_is_readable(const char *name) bool os_file_is_readable(const char *name)
FUNC_ATTR_NONNULL_ALL FUNC_ATTR_WARN_UNUSED_RESULT FUNC_ATTR_NONNULL_ALL FUNC_ATTR_WARN_UNUSED_RESULT
{ {
return (access(name, R_OK) == 0); uv_fs_t req;
int r = uv_fs_access(&fs_loop, &req, name, R_OK, NULL);
uv_fs_req_cleanup(&req);
return (r == 0);
} }
/// Check if a file is writable. /// Check if a file is writable.
@ -296,11 +299,11 @@ bool os_file_is_readable(const char *name)
int os_file_is_writable(const char *name) int os_file_is_writable(const char *name)
FUNC_ATTR_NONNULL_ALL FUNC_ATTR_WARN_UNUSED_RESULT FUNC_ATTR_NONNULL_ALL FUNC_ATTR_WARN_UNUSED_RESULT
{ {
if (access(name, W_OK) == 0) { uv_fs_t req;
if (os_isdir((char_u *)name)) { int r = uv_fs_access(&fs_loop, &req, name, W_OK, NULL);
return 2; uv_fs_req_cleanup(&req);
} if (r == 0) {
return 1; return os_isdir((char_u *)name) ? 2 : 1;
} }
return 0; return 0;
} }